V4L/DVB (12540): v4l: simplify v4l2_i2c_new_subdev and friends

Rewrite v4l2_i2c_new_subdev as a simplified version of v4l2_i2c_new_subdev_cfg
and remove v4l2_i2c_new_probed_subdev and v4l2_i2c_new_probed_subdev_addr.

This simplifies this API substantially.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

1 files changed, 0 insertions, 133 deletions

diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c
index 3a0c64935b0e..f5a93ae3cdf9 100644
--- a/drivers/media/video/v4l2-common.c
+++ b/drivers/media/video/v4l2-common.c
@@ -814,139 +814,6 @@ EXPORT_SYMBOL_GPL(v4l2_i2c_subdev_init);
 
 
 /* Load an i2c sub-device. */
-struct v4l2_subdev *v4l2_i2c_new_subdev(struct v4l2_device *v4l2_dev,
-                struct i2c_adapter *adapter,
-                const char *module_name, const char *client_type, u8 addr)
-{
-        struct v4l2_subdev *sd = NULL;
-        struct i2c_client *client;
-        struct i2c_board_info info;
-
-        BUG_ON(!v4l2_dev);
-
-        if (module_name)
-                request_module(module_name);
-
-        /* Setup the i2c board info with the device type and
-           the device address. */
-        memset(&info, 0, sizeof(info));
-        strlcpy(info.type, client_type, sizeof(info.type));
-        info.addr = addr;
-
-        /* Create the i2c client */
-        client = i2c_new_device(adapter, &info);
-        /* Note: it is possible in the future that
-           c->driver is NULL if the driver is still being loaded.
-           We need better support from the kernel so that we
-           can easily wait for the load to finish. */
-        if (client == NULL || client->driver == NULL)
-                goto error;
-
-        /* Lock the module so we can safely get the v4l2_subdev pointer */
-        if (!try_module_get(client->driver->driver.owner))
-                goto error;
-        sd = i2c_get_clientdata(client);
-
-        /* Register with the v4l2_device which increases the module's
-           use count as well. */
-        if (v4l2_device_register_subdev(v4l2_dev, sd))
-                sd = NULL;
-        /* Decrease the module use count to match the first try_module_get. */
-        module_put(client->driver->driver.owner);
-
-        if (sd) {
-                /* We return errors from v4l2_subdev_call only if we have the
-                   callback as the .s_config is not mandatory */
-                int err = v4l2_subdev_call(sd, core, s_config, 0, NULL);
-
-                if (err && err != -ENOIOCTLCMD) {
-                        v4l2_device_unregister_subdev(sd);
-                        sd = NULL;
-                }
-        }
-
-error:
-        /* If we have a client but no subdev, then something went wrong and
-           we must unregister the client. */
-        if (client && sd == NULL)
-                i2c_unregister_device(client);
-        return sd;
-}
-EXPORT_SYMBOL_GPL(v4l2_i2c_new_subdev);
-
-/* Probe and load an i2c sub-device. */
-struct v4l2_subdev *v4l2_i2c_new_probed_subdev(struct v4l2_device *v4l2_dev,
-        struct i2c_adapter *adapter,
-        const char *module_name, const char *client_type,
-        const unsigned short *addrs)
-{
-        struct v4l2_subdev *sd = NULL;
-        struct i2c_client *client = NULL;
-        struct i2c_board_info info;
-
-        BUG_ON(!v4l2_dev);
-
-        if (module_name)
-                request_module(module_name);
-
-        /* Setup the i2c board info with the device type and
-           the device address. */
-        memset(&info, 0, sizeof(info));
-        strlcpy(info.type, client_type, sizeof(info.type));
-
-        /* Probe and create the i2c client */
-        client = i2c_new_probed_device(adapter, &info, addrs);
-        /* Note: it is possible in the future that
-           c->driver is NULL if the driver is still being loaded.
-           We need better support from the kernel so that we
-           can easily wait for the load to finish. */
-        if (client == NULL || client->driver == NULL)
-                goto error;
-
-        /* Lock the module so we can safely get the v4l2_subdev pointer */
-        if (!try_module_get(client->driver->driver.owner))
-                goto error;
-        sd = i2c_get_clientdata(client);
-
-        /* Register with the v4l2_device which increases the module's
-           use count as well. */
-        if (v4l2_device_register_subdev(v4l2_dev, sd))
-                sd = NULL;
-        /* Decrease the module use count to match the first try_module_get. */
-        module_put(client->driver->driver.owner);
-
-        if (sd) {
-                /* We return errors from v4l2_subdev_call only if we have the
-                   callback as the .s_config is not mandatory */
-                int err = v4l2_subdev_call(sd, core, s_config, 0, NULL);
-
-                if (err && err != -ENOIOCTLCMD) {
-                        v4l2_device_unregister_subdev(sd);
-                        sd = NULL;
-                }
-        }
-
-error:
-        /* If we have a client but no subdev, then something went wrong and
-           we must unregister the client. */
-        if (client && sd == NULL)
-                i2c_unregister_device(client);
-        return sd;
-}
-EXPORT_SYMBOL_GPL(v4l2_i2c_new_probed_subdev);
-
-struct v4l2_subdev *v4l2_i2c_new_probed_subdev_addr(struct v4l2_device *v4l2_dev,
-                struct i2c_adapter *adapter,
-                const char *module_name, const char *client_type, u8 addr)
-{
-        unsigned short addrs[2] = { addr, I2C_CLIENT_END };
-
-        return v4l2_i2c_new_probed_subdev(v4l2_dev, adapter,
-                        module_name, client_type, addrs);
-}
-EXPORT_SYMBOL_GPL(v4l2_i2c_new_probed_subdev_addr);
-
-/* Load an i2c sub-device. */
 struct v4l2_subdev *v4l2_i2c_new_subdev_board(struct v4l2_device *v4l2_dev,
                 struct i2c_adapter *adapter, const char *module_name,
                 struct i2c_board_info *info, const unsigned short *probe_addrs)