diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2010-05-02 08:00:13 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-05-19 11:58:57 -0400 |
commit | aeb506aaaa08bc1910650666463843a73c34b139 (patch) | |
tree | 6fd23c08887d229f59e0d52fd3edfccca461bfc3 /drivers/media/video/usbvision | |
parent | f2b305cd6711b7b3ce30db93b50bc5d6312950c8 (diff) |
V4L/DVB: usbvision: don't use usb_set_intfdata, let v4l2_device_register handle this
v4l2_device_register already sets intfdata, no need to do this again.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/usbvision')
-rw-r--r-- | drivers/media/video/usbvision/usbvision-video.c | 5 | ||||
-rw-r--r-- | drivers/media/video/usbvision/usbvision.h | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c index d91f01668074..6248a639ba2d 100644 --- a/drivers/media/video/usbvision/usbvision-video.c +++ b/drivers/media/video/usbvision/usbvision-video.c | |||
@@ -1649,8 +1649,6 @@ static int __devinit usbvision_probe(struct usb_interface *intf, | |||
1649 | usbvision_configure_video(usbvision); | 1649 | usbvision_configure_video(usbvision); |
1650 | mutex_unlock(&usbvision->lock); | 1650 | mutex_unlock(&usbvision->lock); |
1651 | 1651 | ||
1652 | |||
1653 | usb_set_intfdata (intf, usbvision); | ||
1654 | usbvision_create_sysfs(usbvision->vdev); | 1652 | usbvision_create_sysfs(usbvision->vdev); |
1655 | 1653 | ||
1656 | PDEBUG(DBG_PROBE, "success"); | 1654 | PDEBUG(DBG_PROBE, "success"); |
@@ -1668,7 +1666,7 @@ static int __devinit usbvision_probe(struct usb_interface *intf, | |||
1668 | */ | 1666 | */ |
1669 | static void __devexit usbvision_disconnect(struct usb_interface *intf) | 1667 | static void __devexit usbvision_disconnect(struct usb_interface *intf) |
1670 | { | 1668 | { |
1671 | struct usb_usbvision *usbvision = usb_get_intfdata(intf); | 1669 | struct usb_usbvision *usbvision = to_usbvision(usb_get_intfdata(intf)); |
1672 | 1670 | ||
1673 | PDEBUG(DBG_PROBE, ""); | 1671 | PDEBUG(DBG_PROBE, ""); |
1674 | 1672 | ||
@@ -1677,7 +1675,6 @@ static void __devexit usbvision_disconnect(struct usb_interface *intf) | |||
1677 | "%s: usb_get_intfdata() failed\n", __func__); | 1675 | "%s: usb_get_intfdata() failed\n", __func__); |
1678 | return; | 1676 | return; |
1679 | } | 1677 | } |
1680 | usb_set_intfdata (intf, NULL); | ||
1681 | 1678 | ||
1682 | mutex_lock(&usbvision->lock); | 1679 | mutex_lock(&usbvision->lock); |
1683 | 1680 | ||
diff --git a/drivers/media/video/usbvision/usbvision.h b/drivers/media/video/usbvision/usbvision.h index 5ab936e252fe..d1b3cc0cd87f 100644 --- a/drivers/media/video/usbvision/usbvision.h +++ b/drivers/media/video/usbvision/usbvision.h | |||
@@ -462,6 +462,11 @@ struct usb_usbvision { | |||
462 | int ComprBlockTypes[4]; | 462 | int ComprBlockTypes[4]; |
463 | }; | 463 | }; |
464 | 464 | ||
465 | static inline struct usb_usbvision *to_usbvision(struct v4l2_device *v4l2_dev) | ||
466 | { | ||
467 | return container_of(v4l2_dev, struct usb_usbvision, v4l2_dev); | ||
468 | } | ||
469 | |||
465 | #define call_all(usbvision, o, f, args...) \ | 470 | #define call_all(usbvision, o, f, args...) \ |
466 | v4l2_device_call_all(&usbvision->v4l2_dev, 0, o, f, ##args) | 471 | v4l2_device_call_all(&usbvision->v4l2_dev, 0, o, f, ##args) |
467 | 472 | ||