diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2007-05-31 18:19:20 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-06-03 21:08:42 -0400 |
commit | 278a3de5abc7901805689a66340b5af9882b4f9a (patch) | |
tree | c18ffd5992fb38e3a6322b220fb56a1da6e5aa77 /drivers/media/video/upd64083.c | |
parent | 007a880d627aee0e854e793099bb33d0c1130678 (diff) |
[AF_UNIX]: Fix datagram connect race causing an OOPS.
Based upon an excellent bug report and initial patch by
Frederik Deweerdt.
The UNIX datagram connect code blindly dereferences other->sk_socket
via the call down to the security_unix_may_send() function.
Without locking 'other' that pointer can go NULL via unix_release_sock()
which does sock_orphan() which also marks the socket SOCK_DEAD.
So we have to lock both 'sk' and 'other' yet avoid all kinds of
potential deadlocks (connect to self is OK for datagram sockets and it
is possible for two datagram sockets to perform a simultaneous connect
to each other). So what we do is have a "double lock" function similar
to how we handle this situation in other areas of the kernel. We take
the lock of the socket pointer with the smallest address first in
order to avoid ABBA style deadlocks.
Once we have them both locked, we check to see if SOCK_DEAD is set
for 'other' and if so, drop everything and retry the lookup.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/media/video/upd64083.c')
0 files changed, 0 insertions, 0 deletions