diff options
author | Jean Delvare <khali@linux-fr.org> | 2005-08-15 13:57:04 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 12:14:35 -0400 |
commit | fae91e72b79ba9a21f0ce7551a1fd7e8984c85a6 (patch) | |
tree | 1db62e590a010d7ece7f170aedbcc72c8f126122 /drivers/media/video/tvmixer.c | |
parent | 5b5439652af79106b792faf79b2c1e787e143ba0 (diff) |
[PATCH] I2C: Drop I2C_DEVNAME and i2c_clientname
I2C_DEVNAME and i2c_clientname were introduced in 2.5.68 [1] to help
media/video driver authors who wanted their code to be compatible with
both Linux 2.4 and 2.6. The cause of the incompatibility has gone since
[2], so I think we can get rid of them, as they tend to make the code
harder to read and longer to preprocess/compile for no more benefit.
I'd hope nobody seriously attempts to keep media/video driver compatible
across Linux trees anymore, BTW.
[1] http://marc.theaimsgroup.com/?l=linux-kernel&m=104930186524598&w=2
[2] http://www.linuxhq.com/kernel/v2.6/0-test3/include/linux/i2c.h
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/media/video/tvmixer.c')
-rw-r--r-- | drivers/media/video/tvmixer.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/video/tvmixer.c b/drivers/media/video/tvmixer.c index f0635b19de30..a43301a154af 100644 --- a/drivers/media/video/tvmixer.c +++ b/drivers/media/video/tvmixer.c | |||
@@ -91,7 +91,7 @@ static int tvmixer_ioctl(struct inode *inode, struct file *file, unsigned int cm | |||
91 | if (cmd == SOUND_MIXER_INFO) { | 91 | if (cmd == SOUND_MIXER_INFO) { |
92 | mixer_info info; | 92 | mixer_info info; |
93 | strlcpy(info.id, "tv card", sizeof(info.id)); | 93 | strlcpy(info.id, "tv card", sizeof(info.id)); |
94 | strlcpy(info.name, i2c_clientname(client), sizeof(info.name)); | 94 | strlcpy(info.name, client->name, sizeof(info.name)); |
95 | info.modify_counter = 42 /* FIXME */; | 95 | info.modify_counter = 42 /* FIXME */; |
96 | if (copy_to_user(argp, &info, sizeof(info))) | 96 | if (copy_to_user(argp, &info, sizeof(info))) |
97 | return -EFAULT; | 97 | return -EFAULT; |
@@ -100,7 +100,7 @@ static int tvmixer_ioctl(struct inode *inode, struct file *file, unsigned int cm | |||
100 | if (cmd == SOUND_OLD_MIXER_INFO) { | 100 | if (cmd == SOUND_OLD_MIXER_INFO) { |
101 | _old_mixer_info info; | 101 | _old_mixer_info info; |
102 | strlcpy(info.id, "tv card", sizeof(info.id)); | 102 | strlcpy(info.id, "tv card", sizeof(info.id)); |
103 | strlcpy(info.name, i2c_clientname(client), sizeof(info.name)); | 103 | strlcpy(info.name, client->name, sizeof(info.name)); |
104 | if (copy_to_user(argp, &info, sizeof(info))) | 104 | if (copy_to_user(argp, &info, sizeof(info))) |
105 | return -EFAULT; | 105 | return -EFAULT; |
106 | return 0; | 106 | return 0; |
@@ -295,7 +295,7 @@ static int tvmixer_clients(struct i2c_client *client) | |||
295 | devices[i].dev = NULL; | 295 | devices[i].dev = NULL; |
296 | devices[i].minor = -1; | 296 | devices[i].minor = -1; |
297 | printk("tvmixer: %s unregistered (#1)\n", | 297 | printk("tvmixer: %s unregistered (#1)\n", |
298 | i2c_clientname(client)); | 298 | client->name); |
299 | return 0; | 299 | return 0; |
300 | } | 300 | } |
301 | } | 301 | } |
@@ -354,7 +354,7 @@ static void __exit tvmixer_cleanup_module(void) | |||
354 | if (devices[i].minor != -1) { | 354 | if (devices[i].minor != -1) { |
355 | unregister_sound_mixer(devices[i].minor); | 355 | unregister_sound_mixer(devices[i].minor); |
356 | printk("tvmixer: %s unregistered (#2)\n", | 356 | printk("tvmixer: %s unregistered (#2)\n", |
357 | i2c_clientname(devices[i].dev)); | 357 | devices[i].dev->name); |
358 | } | 358 | } |
359 | } | 359 | } |
360 | } | 360 | } |