diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2010-09-26 08:01:26 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-10-20 23:06:14 -0400 |
commit | 0e0809a58869e3e422985f868ad5e0da1fc0ba85 (patch) | |
tree | e4895d60a050e15d6c4b21aa7dbc4090199efdf3 /drivers/media/video/tlg2300 | |
parent | 08bff03ed697a583612b62a6ac566bd5bce98012 (diff) |
V4L/DVB: videobuf: add queue argument to videobuf_waiton()
videobuf_waiton() must unlock and relock ext_lock if it has to wait.
For that to happen it needs the videobuf_queue pointer.
Don't attempt to unlock/relock q->ext_lock unless it was locked in the
first place.
vb->state has to be protected by a spinlock to be safe.
This patch is based on code from Mauro Carvalho Chehab <mchehab@redhat.com>.
[mchehab@redhat.com: add extra argument to a few missing places]
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/tlg2300')
-rw-r--r-- | drivers/media/video/tlg2300/pd-video.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c index d0cc012f7ae6..a1ffe18640fe 100644 --- a/drivers/media/video/tlg2300/pd-video.c +++ b/drivers/media/video/tlg2300/pd-video.c | |||
@@ -1434,7 +1434,7 @@ static int pd_video_open(struct file *file) | |||
1434 | V4L2_BUF_TYPE_VIDEO_CAPTURE, | 1434 | V4L2_BUF_TYPE_VIDEO_CAPTURE, |
1435 | V4L2_FIELD_INTERLACED,/* video is interlacd */ | 1435 | V4L2_FIELD_INTERLACED,/* video is interlacd */ |
1436 | sizeof(struct videobuf_buffer),/*it's enough*/ | 1436 | sizeof(struct videobuf_buffer),/*it's enough*/ |
1437 | front); | 1437 | front, NULL); |
1438 | } else if (vfd->vfl_type == VFL_TYPE_VBI | 1438 | } else if (vfd->vfl_type == VFL_TYPE_VBI |
1439 | && !(pd->state & POSEIDON_STATE_VBI)) { | 1439 | && !(pd->state & POSEIDON_STATE_VBI)) { |
1440 | front = kzalloc(sizeof(struct front_face), GFP_KERNEL); | 1440 | front = kzalloc(sizeof(struct front_face), GFP_KERNEL); |
@@ -1451,7 +1451,7 @@ static int pd_video_open(struct file *file) | |||
1451 | V4L2_BUF_TYPE_VBI_CAPTURE, | 1451 | V4L2_BUF_TYPE_VBI_CAPTURE, |
1452 | V4L2_FIELD_NONE, /* vbi is NONE mode */ | 1452 | V4L2_FIELD_NONE, /* vbi is NONE mode */ |
1453 | sizeof(struct videobuf_buffer), | 1453 | sizeof(struct videobuf_buffer), |
1454 | front); | 1454 | front, NULL); |
1455 | } else { | 1455 | } else { |
1456 | /* maybe add FM support here */ | 1456 | /* maybe add FM support here */ |
1457 | log("other "); | 1457 | log("other "); |