diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2010-12-29 12:29:55 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-12-30 05:02:29 -0500 |
commit | 657f2271050beabe725ba101c1d840f51a41f33d (patch) | |
tree | 740e898564868e8900ed3b61fc6d57b44e114b57 /drivers/media/video/sn9c102 | |
parent | 3ea2b673a55cee528f83653e711d09425ed4d8b6 (diff) |
[media] v4l: fix handling of v4l2_input.capabilities
The v4l core sets the v4l2_input.capabilities field based on the supplied
v4l2_ioctl_ops. However, several drivers do a memset or memcpy of the v4l2_input
struct, thus overwriting that field incorrectly.
Either remove the memset (which is already done by the v4l core), or add the
proper capabilities field in case of a memcpy.
The same is also true for v4l2_output, but that only affected the ivtv driver.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/sn9c102')
-rw-r--r-- | drivers/media/video/sn9c102/sn9c102_core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c index f49fbfb7dc13..84984f64b234 100644 --- a/drivers/media/video/sn9c102/sn9c102_core.c +++ b/drivers/media/video/sn9c102/sn9c102_core.c | |||
@@ -2189,6 +2189,7 @@ sn9c102_vidioc_enuminput(struct sn9c102_device* cam, void __user * arg) | |||
2189 | memset(&i, 0, sizeof(i)); | 2189 | memset(&i, 0, sizeof(i)); |
2190 | strcpy(i.name, "Camera"); | 2190 | strcpy(i.name, "Camera"); |
2191 | i.type = V4L2_INPUT_TYPE_CAMERA; | 2191 | i.type = V4L2_INPUT_TYPE_CAMERA; |
2192 | i.capabilities = V4L2_IN_CAP_STD; | ||
2192 | 2193 | ||
2193 | if (copy_to_user(arg, &i, sizeof(i))) | 2194 | if (copy_to_user(arg, &i, sizeof(i))) |
2194 | return -EFAULT; | 2195 | return -EFAULT; |