diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-11-28 07:08:53 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-12-11 05:07:41 -0500 |
commit | 773ddbd228dc16a4829836e1dc16383e44c8575e (patch) | |
tree | c8142c09a4bc0cb1ca376245f5f0a06bc1050442 /drivers/media/video/saa7164 | |
parent | ed942c507465287777a5342f83af1638ba05a6ac (diff) |
[media] saa7164: fix endian conversion in saa7164_bus_set()
The msg->command field is 32 bits, and we should fill it with a call
to cpu_to_le32(). The current code is broke on big endian systems.
On little endian systems it truncates the 32 bit value to 16 bits
which probably still works fine.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steven Toth <stoth@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/saa7164')
-rw-r--r-- | drivers/media/video/saa7164/saa7164-bus.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/video/saa7164/saa7164-bus.c b/drivers/media/video/saa7164/saa7164-bus.c index 466e1b02f91f..a7f58a998752 100644 --- a/drivers/media/video/saa7164/saa7164-bus.c +++ b/drivers/media/video/saa7164/saa7164-bus.c | |||
@@ -149,7 +149,7 @@ int saa7164_bus_set(struct saa7164_dev *dev, struct tmComResInfo* msg, | |||
149 | saa7164_bus_verify(dev); | 149 | saa7164_bus_verify(dev); |
150 | 150 | ||
151 | msg->size = cpu_to_le16(msg->size); | 151 | msg->size = cpu_to_le16(msg->size); |
152 | msg->command = cpu_to_le16(msg->command); | 152 | msg->command = cpu_to_le32(msg->command); |
153 | msg->controlselector = cpu_to_le16(msg->controlselector); | 153 | msg->controlselector = cpu_to_le16(msg->controlselector); |
154 | 154 | ||
155 | if (msg->size > dev->bus.m_wMaxReqSize) { | 155 | if (msg->size > dev->bus.m_wMaxReqSize) { |
@@ -464,7 +464,7 @@ int saa7164_bus_get(struct saa7164_dev *dev, struct tmComResInfo* msg, | |||
464 | 464 | ||
465 | peekout: | 465 | peekout: |
466 | msg->size = le16_to_cpu(msg->size); | 466 | msg->size = le16_to_cpu(msg->size); |
467 | msg->command = le16_to_cpu(msg->command); | 467 | msg->command = le32_to_cpu(msg->command); |
468 | msg->controlselector = le16_to_cpu(msg->controlselector); | 468 | msg->controlselector = le16_to_cpu(msg->controlselector); |
469 | ret = SAA_OK; | 469 | ret = SAA_OK; |
470 | out: | 470 | out: |