aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/saa7134
diff options
context:
space:
mode:
authorHans Verkuil <hverkuil@xs4all.nl>2009-02-13 08:57:48 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-03-30 11:42:46 -0400
commit2ba588942c45a03a29a7a097e62bf0beceddb0e8 (patch)
tree8bb6dbc96fcf2f6b68cd933626b9d7b60fe318f0 /drivers/media/video/saa7134
parent1b6f1d9603a46a73ceed8daf7a3285559727fec3 (diff)
V4L/DVB (10544): v4l2-common: add comments warning that about the sort order
Control arrays as are used with v4l2_ctrl_next must be sorted from low to high. Add a comment at the top of all such arrays to warn about this. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/saa7134')
-rw-r--r--drivers/media/video/saa7134/saa7134-empress.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/video/saa7134/saa7134-empress.c b/drivers/media/video/saa7134/saa7134-empress.c
index d9d9607044a7..2e15bb7c3f0a 100644
--- a/drivers/media/video/saa7134/saa7134-empress.c
+++ b/drivers/media/video/saa7134/saa7134-empress.c
@@ -352,6 +352,7 @@ static int empress_s_ctrl(struct file *file, void *priv,
352static int empress_queryctrl(struct file *file, void *priv, 352static int empress_queryctrl(struct file *file, void *priv,
353 struct v4l2_queryctrl *c) 353 struct v4l2_queryctrl *c)
354{ 354{
355 /* Must be sorted from low to high control ID! */
355 static const u32 user_ctrls[] = { 356 static const u32 user_ctrls[] = {
356 V4L2_CID_USER_CLASS, 357 V4L2_CID_USER_CLASS,
357 V4L2_CID_BRIGHTNESS, 358 V4L2_CID_BRIGHTNESS,
@@ -364,6 +365,7 @@ static int empress_queryctrl(struct file *file, void *priv,
364 0 365 0
365 }; 366 };
366 367
368 /* Must be sorted from low to high control ID! */
367 static const u32 mpeg_ctrls[] = { 369 static const u32 mpeg_ctrls[] = {
368 V4L2_CID_MPEG_CLASS, 370 V4L2_CID_MPEG_CLASS,
369 V4L2_CID_MPEG_STREAM_TYPE, 371 V4L2_CID_MPEG_STREAM_TYPE,