diff options
author | Trent Piepho <xyzzy@speakeasy.org> | 2007-01-30 21:26:01 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-02-21 10:35:11 -0500 |
commit | 05ad390724d1f307111a322325df83282a1479e6 (patch) | |
tree | 8b8dc80c42e3139ae8aa308f80633b92079835f5 /drivers/media/video/pwc | |
parent | 6827709a6148a6e8530d90027b4f31aa0aaa5ae5 (diff) |
V4L/DVB (5166): Remove obsolete alias defines of CONFIG_* settings
The out of tree v4l-dvb build system didn't always override the kernel's
configuration settings with v4l-dvb's settings correctly. To work around
this, makefiles would define some new macro based on the setting of a
config variable. e.g. the pwc Makefile would define CONFIG_PWC_DEBUG if
CONFIG_USB_PWC_DEBUG (which is defined via Kconfig) was set.
The v4l-dvb build system should now always override correctly, and this
is no longer necessary. This patch gets ride of these extra defines and
just uses the CONFIG_* settings directly.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/pwc')
-rw-r--r-- | drivers/media/video/pwc/Makefile | 8 | ||||
-rw-r--r-- | drivers/media/video/pwc/pwc-if.c | 8 | ||||
-rw-r--r-- | drivers/media/video/pwc/pwc-v4l.c | 2 | ||||
-rw-r--r-- | drivers/media/video/pwc/pwc.h | 9 |
4 files changed, 7 insertions, 20 deletions
diff --git a/drivers/media/video/pwc/Makefile b/drivers/media/video/pwc/Makefile index 9db2260d10cc..f5c8ec261e87 100644 --- a/drivers/media/video/pwc/Makefile +++ b/drivers/media/video/pwc/Makefile | |||
@@ -2,11 +2,3 @@ pwc-objs := pwc-if.o pwc-misc.o pwc-ctrl.o pwc-v4l.o pwc-uncompress.o | |||
2 | pwc-objs += pwc-dec1.o pwc-dec23.o pwc-kiara.o pwc-timon.o | 2 | pwc-objs += pwc-dec1.o pwc-dec23.o pwc-kiara.o pwc-timon.o |
3 | 3 | ||
4 | obj-$(CONFIG_USB_PWC) += pwc.o | 4 | obj-$(CONFIG_USB_PWC) += pwc.o |
5 | |||
6 | ifeq ($(CONFIG_USB_PWC_DEBUG),y) | ||
7 | EXTRA_CFLAGS += -DCONFIG_PWC_DEBUG=1 | ||
8 | else | ||
9 | EXTRA_CFLAGS += -DCONFIG_PWC_DEBUG=0 | ||
10 | endif | ||
11 | |||
12 | |||
diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c index 9825fd348108..27ed76986ca2 100644 --- a/drivers/media/video/pwc/pwc-if.c +++ b/drivers/media/video/pwc/pwc-if.c | |||
@@ -128,7 +128,7 @@ static int default_size = PSZ_QCIF; | |||
128 | static int default_fps = 10; | 128 | static int default_fps = 10; |
129 | static int default_fbufs = 3; /* Default number of frame buffers */ | 129 | static int default_fbufs = 3; /* Default number of frame buffers */ |
130 | int pwc_mbufs = 2; /* Default number of mmap() buffers */ | 130 | int pwc_mbufs = 2; /* Default number of mmap() buffers */ |
131 | #if CONFIG_PWC_DEBUG | 131 | #ifdef CONFIG_USB_PWC_DEBUG |
132 | int pwc_trace = PWC_DEBUG_LEVEL; | 132 | int pwc_trace = PWC_DEBUG_LEVEL; |
133 | #endif | 133 | #endif |
134 | static int power_save = 0; | 134 | static int power_save = 0; |
@@ -1051,7 +1051,7 @@ static void pwc_remove_sysfs_files(struct video_device *vdev) | |||
1051 | video_device_remove_file(vdev, &class_device_attr_button); | 1051 | video_device_remove_file(vdev, &class_device_attr_button); |
1052 | } | 1052 | } |
1053 | 1053 | ||
1054 | #if CONFIG_PWC_DEBUG | 1054 | #ifdef CONFIG_USB_PWC_DEBUG |
1055 | static const char *pwc_sensor_type_to_string(unsigned int sensor_type) | 1055 | static const char *pwc_sensor_type_to_string(unsigned int sensor_type) |
1056 | { | 1056 | { |
1057 | switch(sensor_type) { | 1057 | switch(sensor_type) { |
@@ -1835,7 +1835,7 @@ module_param(size, charp, 0444); | |||
1835 | module_param(fps, int, 0444); | 1835 | module_param(fps, int, 0444); |
1836 | module_param(fbufs, int, 0444); | 1836 | module_param(fbufs, int, 0444); |
1837 | module_param(mbufs, int, 0444); | 1837 | module_param(mbufs, int, 0444); |
1838 | #if CONFIG_PWC_DEBUG | 1838 | #ifdef CONFIG_USB_PWC_DEBUG |
1839 | module_param_named(trace, pwc_trace, int, 0644); | 1839 | module_param_named(trace, pwc_trace, int, 0644); |
1840 | #endif | 1840 | #endif |
1841 | module_param(power_save, int, 0444); | 1841 | module_param(power_save, int, 0444); |
@@ -1908,7 +1908,7 @@ static int __init usb_pwc_init(void) | |||
1908 | default_fbufs = fbufs; | 1908 | default_fbufs = fbufs; |
1909 | PWC_DEBUG_MODULE("Number of frame buffers set to %d.\n", default_fbufs); | 1909 | PWC_DEBUG_MODULE("Number of frame buffers set to %d.\n", default_fbufs); |
1910 | } | 1910 | } |
1911 | #if CONFIG_PWC_DEBUG | 1911 | #ifdef CONFIG_USB_PWC_DEBUG |
1912 | if (pwc_trace >= 0) { | 1912 | if (pwc_trace >= 0) { |
1913 | PWC_DEBUG_MODULE("Trace options: 0x%04x\n", pwc_trace); | 1913 | PWC_DEBUG_MODULE("Trace options: 0x%04x\n", pwc_trace); |
1914 | } | 1914 | } |
diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index b7eb3ce3b968..d5e6bc850643 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b/drivers/media/video/pwc/pwc-v4l.c | |||
@@ -350,7 +350,7 @@ int pwc_video_do_ioctl(struct inode *inode, struct file *file, | |||
350 | if (pdev == NULL) | 350 | if (pdev == NULL) |
351 | return -EFAULT; | 351 | return -EFAULT; |
352 | 352 | ||
353 | #if CONFIG_PWC_DEBUG | 353 | #ifdef CONFIG_USB_PWC_DEBUG |
354 | if (PWC_DEBUG_LEVEL_IOCTL & pwc_trace) | 354 | if (PWC_DEBUG_LEVEL_IOCTL & pwc_trace) |
355 | v4l_printk_ioctl(cmd); | 355 | v4l_printk_ioctl(cmd); |
356 | #endif | 356 | #endif |
diff --git a/drivers/media/video/pwc/pwc.h b/drivers/media/video/pwc/pwc.h index 7e9c4237d1e8..e778a2b8c280 100644 --- a/drivers/media/video/pwc/pwc.h +++ b/drivers/media/video/pwc/pwc.h | |||
@@ -39,11 +39,6 @@ | |||
39 | #include "pwc-uncompress.h" | 39 | #include "pwc-uncompress.h" |
40 | #include <media/pwc-ioctl.h> | 40 | #include <media/pwc-ioctl.h> |
41 | 41 | ||
42 | /* Turn some debugging options on/off */ | ||
43 | #ifndef CONFIG_PWC_DEBUG | ||
44 | #define CONFIG_PWC_DEBUG 1 | ||
45 | #endif | ||
46 | |||
47 | /* Version block */ | 42 | /* Version block */ |
48 | #define PWC_MAJOR 10 | 43 | #define PWC_MAJOR 10 |
49 | #define PWC_MINOR 0 | 44 | #define PWC_MINOR 0 |
@@ -76,7 +71,7 @@ | |||
76 | #define PWC_DEBUG_TRACE(fmt, args...) PWC_DEBUG(TRACE, fmt, ##args) | 71 | #define PWC_DEBUG_TRACE(fmt, args...) PWC_DEBUG(TRACE, fmt, ##args) |
77 | 72 | ||
78 | 73 | ||
79 | #if CONFIG_PWC_DEBUG | 74 | #ifdef CONFIG_USB_PWC_DEBUG |
80 | 75 | ||
81 | #define PWC_DEBUG_LEVEL (PWC_DEBUG_LEVEL_MODULE) | 76 | #define PWC_DEBUG_LEVEL (PWC_DEBUG_LEVEL_MODULE) |
82 | 77 | ||
@@ -270,7 +265,7 @@ extern "C" { | |||
270 | #endif | 265 | #endif |
271 | 266 | ||
272 | /* Global variables */ | 267 | /* Global variables */ |
273 | #if CONFIG_PWC_DEBUG | 268 | #ifdef CONFIG_USB_PWC_DEBUG |
274 | extern int pwc_trace; | 269 | extern int pwc_trace; |
275 | #endif | 270 | #endif |
276 | extern int pwc_mbufs; | 271 | extern int pwc_mbufs; |