aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/pvrusb2
diff options
context:
space:
mode:
authorMike Isely <isely@pobox.com>2008-08-30 14:11:16 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-10-12 07:36:57 -0400
commit157afbc0de7d99cde39a5525b4c43acd4e02ef82 (patch)
tree930ddb487f77158a96c42c21f330c4194e611f6d /drivers/media/video/pvrusb2
parent5f33df1443cd53283279d017b45ed1b1bc66f622 (diff)
V4L/DVB (8894): pvrusb2: Remove BKL
The earlier change from Hans Verkuil that pushed the BKL from video_open() down into the drivers should be unneeded for the pvrusb2 driver. This driver's implementation for open already protects its internal structures through other means, thus the BKL is not required. This change reverses Hans' previous change, for the pvrusb2 driver. It probably would have been a good idea for Hans to previously have asked for my ack before committing his change. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/pvrusb2')
-rw-r--r--drivers/media/video/pvrusb2/pvrusb2-v4l2.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
index 26ffaa276c51..00306faeac01 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
@@ -932,7 +932,6 @@ static int pvr2_v4l2_open(struct inode *inode, struct file *file)
932 unsigned int input_cnt,idx; 932 unsigned int input_cnt,idx;
933 int ret = 0; 933 int ret = 0;
934 934
935 lock_kernel();
936 dip = container_of(video_devdata(file),struct pvr2_v4l2_dev,devbase); 935 dip = container_of(video_devdata(file),struct pvr2_v4l2_dev,devbase);
937 936
938 vp = dip->v4lp; 937 vp = dip->v4lp;
@@ -943,13 +942,11 @@ static int pvr2_v4l2_open(struct inode *inode, struct file *file)
943 if (!pvr2_hdw_dev_ok(hdw)) { 942 if (!pvr2_hdw_dev_ok(hdw)) {
944 pvr2_trace(PVR2_TRACE_OPEN_CLOSE, 943 pvr2_trace(PVR2_TRACE_OPEN_CLOSE,
945 "pvr2_v4l2_open: hardware not ready"); 944 "pvr2_v4l2_open: hardware not ready");
946 unlock_kernel();
947 return -EIO; 945 return -EIO;
948 } 946 }
949 947
950 fhp = kzalloc(sizeof(*fhp),GFP_KERNEL); 948 fhp = kzalloc(sizeof(*fhp),GFP_KERNEL);
951 if (!fhp) { 949 if (!fhp) {
952 unlock_kernel();
953 return -ENOMEM; 950 return -ENOMEM;
954 } 951 }
955 952
@@ -979,7 +976,6 @@ static int pvr2_v4l2_open(struct inode *inode, struct file *file)
979 fhp); 976 fhp);
980 977
981 kfree(fhp); 978 kfree(fhp);
982 unlock_kernel();
983 return ret; 979 return ret;
984 } 980 }
985 981
@@ -996,7 +992,6 @@ static int pvr2_v4l2_open(struct inode *inode, struct file *file)
996 "Destroying pvr_v4l2_fh id=%p (input map failure)", 992 "Destroying pvr_v4l2_fh id=%p (input map failure)",
997 fhp); 993 fhp);
998 kfree(fhp); 994 kfree(fhp);
999 unlock_kernel();
1000 return -ENOMEM; 995 return -ENOMEM;
1001 } 996 }
1002 input_cnt = 0; 997 input_cnt = 0;
@@ -1020,7 +1015,6 @@ static int pvr2_v4l2_open(struct inode *inode, struct file *file)
1020 v4l2_prio_open(&vp->prio,&fhp->prio); 1015 v4l2_prio_open(&vp->prio,&fhp->prio);
1021 1016
1022 fhp->fw_mode_flag = pvr2_hdw_cpufw_get_enabled(hdw); 1017 fhp->fw_mode_flag = pvr2_hdw_cpufw_get_enabled(hdw);
1023 unlock_kernel();
1024 1018
1025 return 0; 1019 return 0;
1026} 1020}