diff options
author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2011-06-04 14:06:47 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-07-27 16:53:22 -0400 |
commit | 28281a71eb3bc08a0fb9514886e7d6e868f71b3f (patch) | |
tree | 7c17c295b3bba4693eb44c80315945b26823d9f4 /drivers/media/video/mx2_camera.c | |
parent | 497833c6813dde5ca27cc94e28c973d601d601e1 (diff) |
[media] V4L: mx2_camera: .try_fmt shouldn't fail
If the user is requesting too large a frame, instead of failing
select an acceptable geometry, preserving the requested aspect ratio.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/mx2_camera.c')
-rw-r--r-- | drivers/media/video/mx2_camera.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index e05e80090959..55d48442c2eb 100644 --- a/drivers/media/video/mx2_camera.c +++ b/drivers/media/video/mx2_camera.c | |||
@@ -973,11 +973,16 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd, | |||
973 | if (pix->bytesperline < 0) | 973 | if (pix->bytesperline < 0) |
974 | return pix->bytesperline; | 974 | return pix->bytesperline; |
975 | pix->sizeimage = pix->height * pix->bytesperline; | 975 | pix->sizeimage = pix->height * pix->bytesperline; |
976 | if (pix->sizeimage > (4 * 0x3ffff)) { /* CSIRXCNT limit */ | 976 | /* Check against the CSIRXCNT limit */ |
977 | dev_warn(icd->dev.parent, | 977 | if (pix->sizeimage > 4 * 0x3ffff) { |
978 | "Image size (%u) above limit\n", | 978 | /* Adjust geometry, preserve aspect ratio */ |
979 | pix->sizeimage); | 979 | unsigned int new_height = int_sqrt(4 * 0x3ffff * |
980 | return -EINVAL; | 980 | pix->height / pix->bytesperline); |
981 | pix->width = new_height * pix->width / pix->height; | ||
982 | pix->height = new_height; | ||
983 | pix->bytesperline = soc_mbus_bytes_per_line(pix->width, | ||
984 | xlate->host_fmt); | ||
985 | BUG_ON(pix->bytesperline < 0); | ||
981 | } | 986 | } |
982 | } | 987 | } |
983 | 988 | ||