V4L/DVB (8104): cx18/ivtv: ioctl debugging improvements

Completely rely on the video_ioctl2 debugging facilities rather than
doing it ourselves.

Fill in some missing fields in ivtv with VIDIOC_G_FBUF.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

4 files changed, 21 insertions, 23 deletions

diff --git a/drivers/media/video/ivtv/ivtv-controls.c b/drivers/media/video/ivtv/ivtv-controls.c
index 06723bac99c5..2df9b0668f1f 100644
--- a/drivers/media/video/ivtv/ivtv-controls.c
+++ b/drivers/media/video/ivtv/ivtv-controls.c
@@ -53,8 +53,6 @@ int ivtv_queryctrl(struct file *file, void *fh, struct v4l2_queryctrl *qctrl)
         struct ivtv *itv = ((struct ivtv_open_id *)fh)->itv;
         const char *name;
 
-        IVTV_DEBUG_IOCTL("VIDIOC_QUERYCTRL(%08x)\n", qctrl->id);
-
         qctrl->id = v4l2_ctrl_next(ctrl_classes, qctrl->id);
         if (qctrl->id == 0)
                 return -EINVAL;
@@ -91,10 +89,8 @@ int ivtv_queryctrl(struct file *file, void *fh, struct v4l2_queryctrl *qctrl)
 
 int ivtv_querymenu(struct file *file, void *fh, struct v4l2_querymenu *qmenu)
 {
-        struct ivtv *itv = ((struct ivtv_open_id *)fh)->itv;
         struct v4l2_queryctrl qctrl;
 
-        IVTV_DEBUG_IOCTL("VIDIOC_QUERYMENU\n");
         qctrl.id = qmenu->id;
         ivtv_queryctrl(file, fh, &qctrl);
         return v4l2_ctrl_query_menu(qmenu, &qctrl, cx2341x_ctrl_get_menu(qmenu->id));
@@ -103,9 +99,6 @@ int ivtv_querymenu(struct file *file, void *fh, struct v4l2_querymenu *qmenu)
 int ivtv_s_ctrl(struct file *file, void *fh, struct v4l2_control *vctrl)
 {
         struct ivtv *itv = ((struct ivtv_open_id *)fh)->itv;
-        s32 v = vctrl->value;
-
-        IVTV_DEBUG_IOCTL("VIDIOC_S_CTRL(%08x, %x)\n", vctrl->id, v);
 
         switch (vctrl->id) {
                 /* Standard V4L2 controls */
@@ -124,7 +117,7 @@ int ivtv_s_ctrl(struct file *file, void *fh, struct v4l2_control *vctrl)
                 return ivtv_i2c_hw(itv, itv->card->hw_audio_ctrl, VIDIOC_S_CTRL, vctrl);
 
         default:
-                IVTV_DEBUG_IOCTL("invalid control %x\n", vctrl->id);
+                IVTV_DEBUG_IOCTL("invalid control 0x%x\n", vctrl->id);
                 return -EINVAL;
         }
         return 0;
@@ -134,8 +127,6 @@ int ivtv_g_ctrl(struct file *file, void *fh, struct v4l2_control *vctrl)
 {
         struct ivtv *itv = ((struct ivtv_open_id *)fh)->itv;
 
-        IVTV_DEBUG_IOCTL("VIDIOC_G_CTRL(%08x)\n", vctrl->id);
-
         switch (vctrl->id) {
                 /* Standard V4L2 controls */
         case V4L2_CID_BRIGHTNESS:
@@ -152,7 +143,7 @@ int ivtv_g_ctrl(struct file *file, void *fh, struct v4l2_control *vctrl)
         case V4L2_CID_AUDIO_LOUDNESS:
                 return ivtv_i2c_hw(itv, itv->card->hw_audio_ctrl, VIDIOC_G_CTRL, vctrl);
         default:
-                IVTV_DEBUG_IOCTL("invalid control %x\n", vctrl->id);
+                IVTV_DEBUG_IOCTL("invalid control 0x%x\n", vctrl->id);
                 return -EINVAL;
         }
         return 0;
@@ -219,7 +210,6 @@ int ivtv_g_ext_ctrls(struct file *file, void *fh, struct v4l2_ext_controls *c)
                 }
                 return err;
         }
-        IVTV_DEBUG_IOCTL("VIDIOC_G_EXT_CTRLS\n");
         if (c->ctrl_class == V4L2_CTRL_CLASS_MPEG)
                 return cx2341x_ext_ctrls(&itv->params, 0, c, VIDIOC_G_EXT_CTRLS);
         return -EINVAL;
@@ -246,7 +236,6 @@ int ivtv_s_ext_ctrls(struct file *file, void *fh, struct v4l2_ext_controls *c)
                 }
                 return err;
         }
-        IVTV_DEBUG_IOCTL("VIDIOC_S_EXT_CTRLS\n");
         if (c->ctrl_class == V4L2_CTRL_CLASS_MPEG) {
                 static u32 freqs[3] = { 44100, 48000, 32000 };
                 struct cx2341x_mpeg_params p = itv->params;
@@ -286,7 +275,6 @@ int ivtv_try_ext_ctrls(struct file *file, void *fh, struct v4l2_ext_controls *c)
 {
         struct ivtv *itv = ((struct ivtv_open_id *)fh)->itv;
 
-        IVTV_DEBUG_IOCTL("VIDIOC_TRY_EXT_CTRLS\n");
         if (c->ctrl_class == V4L2_CTRL_CLASS_MPEG)
                 return cx2341x_ext_ctrls(&itv->params, atomic_read(&itv->capturing), c, VIDIOC_TRY_EXT_CTRLS);
         return -EINVAL;
diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media/video/ivtv/ivtv-ioctl.c
index aa222056dd47..8d602cb6ba68 100644
--- a/drivers/media/video/ivtv/ivtv-ioctl.c
+++ b/drivers/media/video/ivtv/ivtv-ioctl.c
@@ -1336,6 +1336,8 @@ static int ivtv_g_fbuf(struct file *file, void *fh, struct v4l2_framebuffer *fb)
 
         if (!(itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT_OVERLAY))
                 return -EINVAL;
+        if (!itv->osd_video_pbase)
+                return -EINVAL;
 
         fb->capability = V4L2_FBUF_CAP_EXTERNOVERLAY | V4L2_FBUF_CAP_CHROMAKEY |
                 V4L2_FBUF_CAP_GLOBAL_ALPHA;
@@ -1349,11 +1351,15 @@ static int ivtv_g_fbuf(struct file *file, void *fh, struct v4l2_framebuffer *fb)
         fb->fmt.height = itv->osd_rect.height;
         fb->fmt.field = V4L2_FIELD_INTERLACED;
         fb->fmt.bytesperline = fb->fmt.width;
+        fb->fmt.colorspace = V4L2_COLORSPACE_SMPTE170M;
+        fb->fmt.field = V4L2_FIELD_INTERLACED;
+        fb->fmt.priv = 0;
         if (fb->fmt.pixelformat != V4L2_PIX_FMT_PAL8)
                 fb->fmt.bytesperline *= 2;
         if (fb->fmt.pixelformat == V4L2_PIX_FMT_RGB32 ||
             fb->fmt.pixelformat == V4L2_PIX_FMT_YUV32)
                 fb->fmt.bytesperline *= 2;
+        fb->fmt.sizeimage = fb->fmt.bytesperline * fb->fmt.height;
         fb->base = (void *)itv->osd_video_pbase;
         fb->flags = 0;
 
@@ -1396,6 +1402,8 @@ static int ivtv_s_fbuf(struct file *file, void *fh, struct v4l2_framebuffer *fb)
 
         if (!(itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT_OVERLAY))
                 return -EINVAL;
+        if (!itv->osd_video_pbase)
+                return -EINVAL;
 
         itv->osd_global_alpha_state = (fb->flags & V4L2_FBUF_FLAG_GLOBAL_ALPHA) != 0;
         itv->osd_local_alpha_state =
@@ -1744,6 +1752,7 @@ static int ivtv_default(struct file *file, void *fh, int cmd, void *arg)
 static int ivtv_serialized_ioctl(struct ivtv *itv, struct inode *inode, struct file *filp,
                 unsigned int cmd, unsigned long arg)
 {
+        struct video_device *vfd = video_devdata(filp);
         struct ivtv_open_id *id = (struct ivtv_open_id *)filp->private_data;
         int ret;
 
@@ -1812,13 +1821,11 @@ static int ivtv_serialized_ioctl(struct ivtv *itv, struct inode *inode, struct f
                         return ret;
         }
 
-        if (ivtv_debug & IVTV_DBGFLG_IOCTL) {
-                printk(KERN_INFO "ivtv%d ioctl: ", itv->num);
-                v4l_printk_ioctl(cmd);
-                printk("\n");
-        }
-
-        return video_ioctl2(inode, filp, cmd, arg);
+        if (ivtv_debug & IVTV_DBGFLG_IOCTL)
+                vfd->debug = V4L2_DEBUG_IOCTL | V4L2_DEBUG_IOCTL_ARG;
+        ret = video_ioctl2(inode, filp, cmd, arg);
+        vfd->debug = 0;
+        return ret;
 }
 
 int ivtv_v4l2_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
diff --git a/drivers/media/video/ivtv/ivtv-streams.c b/drivers/media/video/ivtv/ivtv-streams.c
index f8883b487f4a..8e3addd45090 100644
--- a/drivers/media/video/ivtv/ivtv-streams.c
+++ b/drivers/media/video/ivtv/ivtv-streams.c
@@ -213,8 +213,8 @@ static int ivtv_prep_dev(struct ivtv *itv, int type)
         if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
                 s->v4l2dev->type |= VID_TYPE_MPEG_DECODER;
         }
-        snprintf(s->v4l2dev->name, sizeof(s->v4l2dev->name), "ivtv%d %s",
-                        itv->num, s->name);
+        snprintf(s->v4l2dev->name, sizeof(s->v4l2dev->name), "ivtv%d",
+                        itv->num);
 
         s->v4l2dev->minor = minor;
         s->v4l2dev->dev = &itv->dev->dev;
diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
index e8dbee443946..14f93341f061 100644
--- a/drivers/media/video/ivtv/ivtvfb.c
+++ b/drivers/media/video/ivtv/ivtvfb.c
@@ -789,6 +789,9 @@ static int _ivtvfb_check_var(struct fb_var_screeninfo *var, struct ivtv *itv)
         else
                 var->pixclock = pixclock;
 
+        itv->osd_rect.width = var->xres;
+        itv->osd_rect.height = var->yres;
+
         IVTVFB_DEBUG_INFO("Display size: %dx%d (virtual %dx%d) @ %dbpp\n",
                       var->xres, var->yres,
                       var->xres_virtual, var->yres_virtual,