V4L/DVB (11844): ir-kbd-i2c: Switch to the new-style device binding model

Let card drivers probe for IR receiver devices and instantiate them if
found. Ultimately it would be better if we could stop probing
completely, but I suspect this won't be possible for all card types.

There's certainly room for cleanups. For example, some drivers are
sharing I2C adapter IDs, so they also had to share the list of I2C
addresses being probed for an IR receiver. Now that each driver
explicitly says which addresses should be probed, maybe some addresses
can be dropped from some drivers.

Also, the special cases in saa7134-i2c should probably be handled on a
per-board basis. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

1 files changed, 28 insertions, 3 deletions

diff --git a/drivers/media/video/ivtv/ivtv-i2c.c b/drivers/media/video/ivtv/ivtv-i2c.c
index 9e3d32b8004c..0ecde9ca05c1 100644
--- a/drivers/media/video/ivtv/ivtv-i2c.c
+++ b/drivers/media/video/ivtv/ivtv-i2c.c
@@ -579,9 +579,11 @@ static struct i2c_client ivtv_i2c_client_template = {
         .name = "ivtv internal",
 };
 
-/* init + register i2c algo-bit adapter */
+/* init + register i2c adapter + instantiate IR receiver */
 int init_ivtv_i2c(struct ivtv *itv)
 {
+        int retval;
+
         IVTV_DEBUG_I2C("i2c init\n");
 
         /* Sanity checks for the I2C hardware arrays. They must be the
@@ -619,9 +621,32 @@ int init_ivtv_i2c(struct ivtv *itv)
         ivtv_setsda(itv, 1);
 
         if (itv->options.newi2c > 0)
-                return i2c_add_adapter(&itv->i2c_adap);
+                retval = i2c_add_adapter(&itv->i2c_adap);
         else
-                return i2c_bit_add_bus(&itv->i2c_adap);
+                retval = i2c_bit_add_bus(&itv->i2c_adap);
+
+        /* Instantiate the IR receiver device, if present */
+        if (retval == 0) {
+                struct i2c_board_info info;
+                /* The external IR receiver is at i2c address 0x34 (0x35 for
+                   reads).  Future Hauppauge cards will have an internal
+                   receiver at 0x30 (0x31 for reads).  In theory, both can be
+                   fitted, and Hauppauge suggest an external overrides an
+                   internal.
+
+                   That's why we probe 0x1a (~0x34) first. CB
+                */
+                const unsigned short addr_list[] = {
+                        0x1a, 0x18, 0x64, 0x30,
+                        I2C_CLIENT_END
+                };
+
+                memset(&info, 0, sizeof(struct i2c_board_info));
+                strlcpy(info.type, "ir_video", I2C_NAME_SIZE);
+                i2c_new_probed_device(&itv->i2c_adap, &info, addr_list);
+        }
+
+        return retval;
 }
 
 void exit_ivtv_i2c(struct ivtv *itv)