diff options
author | Jean-Francois Moine <moinejf@free.fr> | 2009-12-12 04:58:01 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-12-15 21:18:49 -0500 |
commit | 83955556669f69fccfd332b52e9b1796d60c77bd (patch) | |
tree | 29b94e2cb24c5de83523838a7dfaa0fe88cf53b8 /drivers/media/video/gspca/ov519.c | |
parent | 37b372e5ebe187037e01885151a0afb546a38520 (diff) |
V4L/DVB (13626): gspca - many subdrivers: Fix some warnings.
- gl860.c:332:15: warning: cast to restricted __le16
- gl860.c:333:15: warning: cast to restricted __le16
- gl860-mi1320.c:348:5: warning: symbol 'mi1320_camera_settings' was not declared. Should it be static?
- gl860-mi2020.c:772:5: warning: symbol 'mi2020_camera_settings' was not declared. Should it be static?
- m5602_ov9650.c:444:7: warning: symbol 'data' shadows an earlier one
- m5602_core.c:84:5: warning: symbol 'm5602_wait_for_i2c' was not declared. Should it be static?
- m5602_core.c:391:6: warning: symbol 'm5602_disconnect' was not declared. Should it be static?
- m5602_s5k4aa.c:530:23: warning: dubious: x | !y
- m5602_s5k4aa.c:575:23: warning: dubious: x | !y
- gspca.c:1196:13: warning: potentially expensive pointer subtraction
- mr97310a.c:70:5: warning: symbol 'force_sensor_type' was not declared. Should it be static?
- ov519.c:2025:4: warning: do-while statement is not a compound statement
- ov519.c:2063:4: warning: do-while statement is not a compound statement
- ov519.c:2089:4: warning: do-while statement is not a compound statement
- ov519.c:1985:34: warning: incorrect type in assignment (different base types)
- sn9c20x.c:1164:5: warning: symbol 'i2c_r1' was not declared. Should it be static?
- sn9c20x.c:1189:5: warning: symbol 'i2c_r2' was not declared. Should it be static?
- sn9c20x.c:2237:27: warning: right shift by bigger than source value
- sn9c20x.c:2237:27: warning: right shift by bigger than source value
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/gspca/ov519.c')
-rw-r--r-- | drivers/media/video/gspca/ov519.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/media/video/gspca/ov519.c b/drivers/media/video/gspca/ov519.c index ad9ec339981d..b4f965731244 100644 --- a/drivers/media/video/gspca/ov519.c +++ b/drivers/media/video/gspca/ov519.c | |||
@@ -1982,7 +1982,7 @@ static int ov518_reg_w32(struct sd *sd, __u16 index, u32 value, int n) | |||
1982 | { | 1982 | { |
1983 | int ret; | 1983 | int ret; |
1984 | 1984 | ||
1985 | *((u32 *)sd->gspca_dev.usb_buf) = __cpu_to_le32(value); | 1985 | *((__le32 *) sd->gspca_dev.usb_buf) = __cpu_to_le32(value); |
1986 | 1986 | ||
1987 | ret = usb_control_msg(sd->gspca_dev.dev, | 1987 | ret = usb_control_msg(sd->gspca_dev.dev, |
1988 | usb_sndctrlpipe(sd->gspca_dev.dev, 0), | 1988 | usb_sndctrlpipe(sd->gspca_dev.dev, 0), |
@@ -2021,9 +2021,9 @@ static int ov511_i2c_w(struct sd *sd, __u8 reg, __u8 value) | |||
2021 | if (rc < 0) | 2021 | if (rc < 0) |
2022 | return rc; | 2022 | return rc; |
2023 | 2023 | ||
2024 | do | 2024 | do { |
2025 | rc = reg_r(sd, R511_I2C_CTL); | 2025 | rc = reg_r(sd, R511_I2C_CTL); |
2026 | while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ | 2026 | } while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ |
2027 | 2027 | ||
2028 | if (rc < 0) | 2028 | if (rc < 0) |
2029 | return rc; | 2029 | return rc; |
@@ -2055,9 +2055,9 @@ static int ov511_i2c_r(struct sd *sd, __u8 reg) | |||
2055 | if (rc < 0) | 2055 | if (rc < 0) |
2056 | return rc; | 2056 | return rc; |
2057 | 2057 | ||
2058 | do | 2058 | do { |
2059 | rc = reg_r(sd, R511_I2C_CTL); | 2059 | rc = reg_r(sd, R511_I2C_CTL); |
2060 | while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ | 2060 | } while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ |
2061 | 2061 | ||
2062 | if (rc < 0) | 2062 | if (rc < 0) |
2063 | return rc; | 2063 | return rc; |
@@ -2081,9 +2081,9 @@ static int ov511_i2c_r(struct sd *sd, __u8 reg) | |||
2081 | if (rc < 0) | 2081 | if (rc < 0) |
2082 | return rc; | 2082 | return rc; |
2083 | 2083 | ||
2084 | do | 2084 | do { |
2085 | rc = reg_r(sd, R511_I2C_CTL); | 2085 | rc = reg_r(sd, R511_I2C_CTL); |
2086 | while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ | 2086 | } while (rc > 0 && ((rc & 1) == 0)); /* Retry until idle */ |
2087 | 2087 | ||
2088 | if (rc < 0) | 2088 | if (rc < 0) |
2089 | return rc; | 2089 | return rc; |