diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-11-29 06:19:59 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-12-05 15:42:21 -0500 |
commit | 055cd55601f948675006ca90362fc2bfaae90a86 (patch) | |
tree | a878c55c30b0ae30334f3523d8dd67940d32a7f3 /drivers/media/video/em28xx | |
parent | 0278155c84af42d78785731263b69fb49f945ea7 (diff) |
V4L/DVB (13537): ir: Prepare the code for dynamic keycode table allocation
Currently, the IR table is initialized by calling ir_input_init(). However,
this function doesn't return any error code, nor has a function to be called
when de-initializing the IR's.
Change the return argment to integer and make sure that each driver will
handle the error code. Also adds a function to free any resources that may
be allocating there: ir_input_free().
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/em28xx')
-rw-r--r-- | drivers/media/video/em28xx/em28xx-input.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c index 5550de9c669f..d96ec7c09dca 100644 --- a/drivers/media/video/em28xx/em28xx-input.c +++ b/drivers/media/video/em28xx/em28xx-input.c | |||
@@ -367,7 +367,11 @@ int em28xx_ir_init(struct em28xx *dev) | |||
367 | usb_make_path(dev->udev, ir->phys, sizeof(ir->phys)); | 367 | usb_make_path(dev->udev, ir->phys, sizeof(ir->phys)); |
368 | strlcat(ir->phys, "/input0", sizeof(ir->phys)); | 368 | strlcat(ir->phys, "/input0", sizeof(ir->phys)); |
369 | 369 | ||
370 | ir_input_init(input_dev, &ir->ir, IR_TYPE_OTHER, dev->board.ir_codes); | 370 | err = ir_input_init(input_dev, &ir->ir, IR_TYPE_OTHER, |
371 | dev->board.ir_codes); | ||
372 | if (err < 0) | ||
373 | goto err_out_free; | ||
374 | |||
371 | input_dev->name = ir->name; | 375 | input_dev->name = ir->name; |
372 | input_dev->phys = ir->phys; | 376 | input_dev->phys = ir->phys; |
373 | input_dev->id.bustype = BUS_USB; | 377 | input_dev->id.bustype = BUS_USB; |
@@ -392,6 +396,7 @@ int em28xx_ir_init(struct em28xx *dev) | |||
392 | em28xx_ir_stop(ir); | 396 | em28xx_ir_stop(ir); |
393 | dev->ir = NULL; | 397 | dev->ir = NULL; |
394 | err_out_free: | 398 | err_out_free: |
399 | ir_input_free(input_dev); | ||
395 | input_free_device(input_dev); | 400 | input_free_device(input_dev); |
396 | kfree(ir); | 401 | kfree(ir); |
397 | return err; | 402 | return err; |
@@ -406,6 +411,7 @@ int em28xx_ir_fini(struct em28xx *dev) | |||
406 | return 0; | 411 | return 0; |
407 | 412 | ||
408 | em28xx_ir_stop(ir); | 413 | em28xx_ir_stop(ir); |
414 | ir_input_free(ir->input); | ||
409 | input_unregister_device(ir->input); | 415 | input_unregister_device(ir->input); |
410 | kfree(ir); | 416 | kfree(ir); |
411 | 417 | ||