diff options
author | Devin Heitmueller <devin.heitmueller@gmail.com> | 2008-04-17 20:41:16 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-24 13:09:41 -0400 |
commit | 83244025e70aadd7e8baad520decf5d53d534d8f (patch) | |
tree | d2566cc2a2156d8a563287e16fd391601bde8db0 /drivers/media/video/em28xx | |
parent | 6ea54d938b6f81baa0952a8b15d3e67e6c268b8f (diff) |
V4L/DVB (7608): em28xx-dvb: Some cleanups and fixes
em28xx-dvb.c:
- Remove unneeded xc3028_ctrl structure. The driver automatically preserves
the previous value
tuner-xc2028.c:
- Make the return type for xc2028_get_reg signed, since all of the callers
are looking for "< 0" to detect errors.
Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/em28xx')
-rw-r--r-- | drivers/media/video/em28xx/em28xx-dvb.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index 21b8f1d48024..39581d976e01 100644 --- a/drivers/media/video/em28xx/em28xx-dvb.c +++ b/drivers/media/video/em28xx/em28xx-dvb.c | |||
@@ -214,17 +214,13 @@ static struct zl10353_config em28xx_zl10353_with_xc3028 = { | |||
214 | static int attach_xc3028(u8 addr, struct em28xx *dev) | 214 | static int attach_xc3028(u8 addr, struct em28xx *dev) |
215 | { | 215 | { |
216 | struct dvb_frontend *fe; | 216 | struct dvb_frontend *fe; |
217 | struct xc2028_ctrl ctl; | ||
218 | struct xc2028_config cfg; | 217 | struct xc2028_config cfg; |
219 | 218 | ||
220 | memset(&cfg, 0, sizeof(cfg)); | 219 | memset(&cfg, 0, sizeof(cfg)); |
221 | cfg.i2c_adap = &dev->i2c_adap; | 220 | cfg.i2c_adap = &dev->i2c_adap; |
222 | cfg.i2c_addr = addr; | 221 | cfg.i2c_addr = addr; |
223 | cfg.ctrl = &ctl; | ||
224 | cfg.callback = em28xx_tuner_callback; | 222 | cfg.callback = em28xx_tuner_callback; |
225 | 223 | ||
226 | em28xx_setup_xc3028(dev, &ctl); | ||
227 | |||
228 | if (!dev->dvb->frontend) { | 224 | if (!dev->dvb->frontend) { |
229 | printk(KERN_ERR "%s/2: dvb frontend not attached. " | 225 | printk(KERN_ERR "%s/2: dvb frontend not attached. " |
230 | "Can't attach xc3028\n", | 226 | "Can't attach xc3028\n", |