diff options
author | Chris Rankin <rankincj@yahoo.com> | 2011-09-04 14:38:14 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-09-18 06:58:01 -0400 |
commit | 16e3d2f4fab6e001a79705fa273418afc10188f8 (patch) | |
tree | c3d3ae94639e5c7c6f65394aeaeb55c2340ccc02 /drivers/media/video/em28xx | |
parent | 7577911244c437f4a4abac5e4b67b059c06dbe9d (diff) |
[media] EM28xx - Fix memory leak on disconnect or error
Release the dev->alt_max_pkt_size buffer in all cases.
Signed-off-by: Chris Rankin <rankincj@yahoo.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/em28xx')
-rw-r--r-- | drivers/media/video/em28xx/em28xx-cards.c | 1 | ||||
-rw-r--r-- | drivers/media/video/em28xx/em28xx-video.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c index 5fddcd0869de..013e946bdc45 100644 --- a/drivers/media/video/em28xx/em28xx-cards.c +++ b/drivers/media/video/em28xx/em28xx-cards.c | |||
@@ -3201,6 +3201,7 @@ static int em28xx_usb_probe(struct usb_interface *interface, | |||
3201 | retval = em28xx_init_dev(&dev, udev, interface, nr); | 3201 | retval = em28xx_init_dev(&dev, udev, interface, nr); |
3202 | if (retval) { | 3202 | if (retval) { |
3203 | mutex_unlock(&dev->lock); | 3203 | mutex_unlock(&dev->lock); |
3204 | kfree(dev->alt_max_pkt_size); | ||
3204 | kfree(dev); | 3205 | kfree(dev); |
3205 | goto err; | 3206 | goto err; |
3206 | } | 3207 | } |
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c index d176dc0394e2..61f35c8d66d2 100644 --- a/drivers/media/video/em28xx/em28xx-video.c +++ b/drivers/media/video/em28xx/em28xx-video.c | |||
@@ -2200,6 +2200,7 @@ static int em28xx_v4l2_close(struct file *filp) | |||
2200 | free the remaining resources */ | 2200 | free the remaining resources */ |
2201 | if (dev->state & DEV_DISCONNECTED) { | 2201 | if (dev->state & DEV_DISCONNECTED) { |
2202 | em28xx_release_resources(dev); | 2202 | em28xx_release_resources(dev); |
2203 | kfree(dev->alt_max_pkt_size); | ||
2203 | kfree(dev); | 2204 | kfree(dev); |
2204 | return 0; | 2205 | return 0; |
2205 | } | 2206 | } |