diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-11-25 08:06:21 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-12-29 14:53:42 -0500 |
commit | 1bee0184f6ffba1263a4b1e5732cde2c5292d843 (patch) | |
tree | 9539e3a347c0620c41b444a316df3a286a335ccf /drivers/media/video/em28xx/em28xx-cards.c | |
parent | ec5de990d912c0d5cca98e030bf6447c1529f56d (diff) |
V4L/DVB (9754): em28xx: improve debug messages
Now, the first message states board names. Also, removed printing the alternate
settings by default. I2C messages are now clearer.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/em28xx/em28xx-cards.c')
-rw-r--r-- | drivers/media/video/em28xx/em28xx-cards.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c index 8b82c5528a16..3013abd00e05 100644 --- a/drivers/media/video/em28xx/em28xx-cards.c +++ b/drivers/media/video/em28xx/em28xx-cards.c | |||
@@ -1274,6 +1274,10 @@ void em28xx_pre_card_setup(struct em28xx *dev) | |||
1274 | { | 1274 | { |
1275 | int rc; | 1275 | int rc; |
1276 | 1276 | ||
1277 | em28xx_set_model(dev); | ||
1278 | |||
1279 | em28xx_info("Found %s\n", dev->board.name); | ||
1280 | |||
1277 | /* Set the default GPO/GPIO for legacy devices */ | 1281 | /* Set the default GPO/GPIO for legacy devices */ |
1278 | dev->reg_gpo_num = EM2880_R04_GPO; | 1282 | dev->reg_gpo_num = EM2880_R04_GPO; |
1279 | dev->reg_gpio_num = EM28XX_R08_GPIO; | 1283 | dev->reg_gpio_num = EM28XX_R08_GPIO; |
@@ -1284,7 +1288,8 @@ void em28xx_pre_card_setup(struct em28xx *dev) | |||
1284 | rc = em28xx_read_reg(dev, EM28XX_R0A_CHIPID); | 1288 | rc = em28xx_read_reg(dev, EM28XX_R0A_CHIPID); |
1285 | if (rc > 0) { | 1289 | if (rc > 0) { |
1286 | dev->chip_id = rc; | 1290 | dev->chip_id = rc; |
1287 | switch (rc) { | 1291 | |
1292 | switch (dev->chip_id) { | ||
1288 | case CHIP_ID_EM2750: | 1293 | case CHIP_ID_EM2750: |
1289 | em28xx_info("chip ID is em2750\n"); | 1294 | em28xx_info("chip ID is em2750\n"); |
1290 | break; | 1295 | break; |
@@ -1307,7 +1312,7 @@ void em28xx_pre_card_setup(struct em28xx *dev) | |||
1307 | dev->wait_after_write = 0; | 1312 | dev->wait_after_write = 0; |
1308 | break; | 1313 | break; |
1309 | default: | 1314 | default: |
1310 | em28xx_info("em28xx chip ID = %d\n", rc); | 1315 | em28xx_info("em28xx chip ID = %d\n", dev->chip_id); |
1311 | } | 1316 | } |
1312 | } | 1317 | } |
1313 | 1318 | ||
@@ -1316,8 +1321,6 @@ void em28xx_pre_card_setup(struct em28xx *dev) | |||
1316 | if (rc >= 0) | 1321 | if (rc >= 0) |
1317 | dev->reg_gpo = rc; | 1322 | dev->reg_gpo = rc; |
1318 | 1323 | ||
1319 | em28xx_set_model(dev); | ||
1320 | |||
1321 | /* Those are the default values for the majority of boards | 1324 | /* Those are the default values for the majority of boards |
1322 | Use those values if not specified otherwise at boards entry | 1325 | Use those values if not specified otherwise at boards entry |
1323 | */ | 1326 | */ |