V4L/DVB (5815): Cx88: i2c structure templates clean-up

Clean up the use of structure templates in cx88-i2c and cx88-vp3054-i2c.
For one thing, a real template is supposed to be read-only. And in some
cases it's more efficient to initialize the few fields we need
individually.

This clean-up shrinks cx88-i2c.o by 33% and cx88-vp3054-i2c.o by 49%
(x86_64).

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

1 files changed, 3 insertions, 9 deletions

diff --git a/drivers/media/video/cx88/cx88-vp3054-i2c.c b/drivers/media/video/cx88/cx88-vp3054-i2c.c
index 82bc3a28aa22..cd0877636a32 100644
--- a/drivers/media/video/cx88/cx88-vp3054-i2c.c
+++ b/drivers/media/video/cx88/cx88-vp3054-i2c.c
@@ -94,7 +94,7 @@ static int vp3054_bit_getsda(void *data)
 
 /* ----------------------------------------------------------------------- */
 
-static struct i2c_algo_bit_data vp3054_i2c_algo_template = {
+static const struct i2c_algo_bit_data vp3054_i2c_algo_template = {
         .setsda  = vp3054_bit_setsda,
         .setscl  = vp3054_bit_setscl,
         .getsda  = vp3054_bit_getsda,
@@ -105,12 +105,6 @@ static struct i2c_algo_bit_data vp3054_i2c_algo_template = {
 
 /* ----------------------------------------------------------------------- */
 
-static struct i2c_adapter vp3054_i2c_adap_template = {
-        .name              = "cx2388x",
-        .owner             = THIS_MODULE,
-        .id                = I2C_HW_B_CX2388x,
-};
-
 int vp3054_i2c_probe(struct cx8802_dev *dev)
 {
         struct cx88_core *core = dev->core;
@@ -125,8 +119,6 @@ int vp3054_i2c_probe(struct cx8802_dev *dev)
                 return -ENOMEM;
         vp3054_i2c = dev->card_priv;
 
-        memcpy(&vp3054_i2c->adap, &vp3054_i2c_adap_template,
-               sizeof(vp3054_i2c->adap));
         memcpy(&vp3054_i2c->algo, &vp3054_i2c_algo_template,
                sizeof(vp3054_i2c->algo));
 
@@ -135,6 +127,8 @@ int vp3054_i2c_probe(struct cx8802_dev *dev)
         vp3054_i2c->adap.dev.parent = &dev->pci->dev;
         strlcpy(vp3054_i2c->adap.name, core->name,
                 sizeof(vp3054_i2c->adap.name));
+        vp3054_i2c->adap.owner = THIS_MODULE;
+        vp3054_i2c->adap.id = I2C_HW_B_CX2388x;
         vp3054_i2c->algo.data = dev;
         i2c_set_adapdata(&vp3054_i2c->adap, dev);
         vp3054_i2c->adap.algo_data = &vp3054_i2c->algo;