diff options
author | Michael Krufky <mkrufky@linuxtv.org> | 2008-05-10 13:34:09 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-05-14 01:56:46 -0400 |
commit | 48723543aff1f46091840222490ded5fe09c0e37 (patch) | |
tree | ce076b78ecae43f7ae22849277db6d496780cc8b /drivers/media/video/cx23885 | |
parent | 07c87a833e9ef92280ed24ab85cd4eb49cbca9c0 (diff) |
V4L/DVB (7893): xc5000: bug-fix: allow multiple devices in a single system
The current code passes a context pointer in the xc5000_config struct.
This context pointer is used in the tuner_callback function, used to
reset the device after firmware download.
The xc5000_config struct is a static structure, whose .priv member was
being assigned before calling xc5000_attach(). If there are more than
one of the same device type installed on a single system, the last one
to assign xc5000_config.priv will "win", and all others will cease to
function properly.
This patch passes the context pointer in xc5000_attach() rather that
storing it within the static struct xc5000_config.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/cx23885')
-rw-r--r-- | drivers/media/video/cx23885/cx23885-dvb.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index 47e3f9e035f9..022aa391937a 100644 --- a/drivers/media/video/cx23885/cx23885-dvb.c +++ b/drivers/media/video/cx23885/cx23885-dvb.c | |||
@@ -384,12 +384,10 @@ static int dvb_register(struct cx23885_tsport *port) | |||
384 | port->dvb.frontend = dvb_attach(s5h1409_attach, | 384 | port->dvb.frontend = dvb_attach(s5h1409_attach, |
385 | &hauppauge_hvr1500q_config, | 385 | &hauppauge_hvr1500q_config, |
386 | &dev->i2c_bus[0].i2c_adap); | 386 | &dev->i2c_bus[0].i2c_adap); |
387 | if (port->dvb.frontend != NULL) { | 387 | if (port->dvb.frontend != NULL) |
388 | hauppauge_hvr1500q_tunerconfig.priv = i2c_bus; | ||
389 | dvb_attach(xc5000_attach, port->dvb.frontend, | 388 | dvb_attach(xc5000_attach, port->dvb.frontend, |
390 | &i2c_bus->i2c_adap, | 389 | &i2c_bus->i2c_adap, |
391 | &hauppauge_hvr1500q_tunerconfig); | 390 | &hauppauge_hvr1500q_tunerconfig, i2c_bus); |
392 | } | ||
393 | break; | 391 | break; |
394 | case CX23885_BOARD_HAUPPAUGE_HVR1500: | 392 | case CX23885_BOARD_HAUPPAUGE_HVR1500: |
395 | i2c_bus = &dev->i2c_bus[1]; | 393 | i2c_bus = &dev->i2c_bus[1]; |