aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/cx18/cx18-firmware.c
diff options
context:
space:
mode:
authorAndy Walls <awalls@radix.net>2008-11-09 16:14:07 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-12-30 06:38:04 -0500
commitd20ceecd0c5370cfe6b6eee2f63fecb65222c747 (patch)
treebb6f74956d73d4208aaeaf35a9af82904da3997d /drivers/media/video/cx18/cx18-firmware.c
parent2d1a1b055be8598dbcc8a7b905d07bcf05eaff3a (diff)
V4L/DVB (9598): cx18: Prevent CX23418 from clearing it's outgoing ack interrupts to driver
When the CX23418 CPU unit sent out an ack interrupt to the linux driver, it also received that interrupt and cleared the flag before the linux driver could see what the interrupt was for. This fix prevents the CPU from receiving an IRQ for it's own outgoing ack's to the linux driver. This fix is critical now that the linux driver doesn't poll but relies on these ack interrupts. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/cx18/cx18-firmware.c')
-rw-r--r--drivers/media/video/cx18/cx18-firmware.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/media/video/cx18/cx18-firmware.c b/drivers/media/video/cx18/cx18-firmware.c
index ab02da727519..06f5563d6d5a 100644
--- a/drivers/media/video/cx18/cx18-firmware.c
+++ b/drivers/media/video/cx18/cx18-firmware.c
@@ -380,6 +380,17 @@ int cx18_firmware_init(struct cx18 *cx)
380 if (sz <= 0) 380 if (sz <= 0)
381 return -EIO; 381 return -EIO;
382 } 382 }
383
384 /*
385 * The CPU firmware apparently sets up to receive an interrupt for it's
386 * outgoing IRQ_CPU_TO_EPU_ACK to us (*boggle*). We get an interrupt
387 * when it sends us an ack, but by the time we process it, that flag in
388 * the SW2 status register has been cleared by the CPU firmware.
389 * We'll prevent that not so useful behavior by clearing the CPU's
390 * interrupt enables for Ack IRQ's we want to process.
391 */
392 cx18_sw2_irq_disable_cpu(cx, IRQ_CPU_TO_EPU_ACK | IRQ_APU_TO_EPU_ACK);
393
383 /* initialize GPIO */ 394 /* initialize GPIO */
384 cx18_write_reg_expect(cx, 0x14001400, 0xc78110, 0x00001400, 0x14001400); 395 cx18_write_reg_expect(cx, 0x14001400, 0xc78110, 0x00001400, 0x14001400);
385 return 0; 396 return 0;