diff options
author | Michael Krufky <mkrufky@linuxtv.org> | 2008-09-06 13:56:58 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-10-12 07:37:01 -0400 |
commit | 30650961907368b1077cade35455fe931b14da6b (patch) | |
tree | a27bbcb9319529b6d13da933adff4c069a12b853 /drivers/media/video/au0828/au0828-dvb.c | |
parent | 2a6003c20771ca16fc6386b5fd258df2f2fa8232 (diff) |
V4L/DVB (8951): xc5000: dont pass devptr in xc5000_attach()
Dont pass devptr in xc5000_attach, dont store it in xc5000_priv.
This pointer is passed into the tuner_callback function, which always
expects a pointer to fe->dvb->priv or i2c_adapter->algo_data.
This prevents future possible bugs in new drivers, such as using a "devptr"
other that the standard fe->dvb->priv in a DVB driver.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/au0828/au0828-dvb.c')
-rw-r--r-- | drivers/media/video/au0828/au0828-dvb.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/media/video/au0828/au0828-dvb.c b/drivers/media/video/au0828/au0828-dvb.c index ba94be7e0ac1..96246959dce1 100644 --- a/drivers/media/video/au0828/au0828-dvb.c +++ b/drivers/media/video/au0828/au0828-dvb.c | |||
@@ -358,9 +358,8 @@ int au0828_dvb_register(struct au0828_dev *dev) | |||
358 | &hauppauge_hvr950q_config, | 358 | &hauppauge_hvr950q_config, |
359 | &dev->i2c_adap); | 359 | &dev->i2c_adap); |
360 | if (dvb->frontend != NULL) | 360 | if (dvb->frontend != NULL) |
361 | dvb_attach(xc5000_attach, dvb->frontend, | 361 | dvb_attach(xc5000_attach, dvb->frontend, &dev->i2c_adap, |
362 | &dev->i2c_adap, | 362 | &hauppauge_hvr950q_tunerconfig); |
363 | &hauppauge_hvr950q_tunerconfig, dev); | ||
364 | break; | 363 | break; |
365 | case AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL: | 364 | case AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL: |
366 | dvb->frontend = dvb_attach(au8522_attach, | 365 | dvb->frontend = dvb_attach(au8522_attach, |