diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-10-27 13:54:01 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-10-28 05:38:35 -0400 |
commit | 9825f376533c8550dc2f8d78a5a9af6612490a1a (patch) | |
tree | ad7c8d8465d39a0676f1f802a457ec543de44b68 /drivers/media/usb | |
parent | ede4c3a5a6c0d4490e39a1695570c7a6e9cf7b33 (diff) |
[media] jeilinj: fix return of the response code
drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
The code still doesn't make much sense, as response is never tested
there.
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/usb')
-rw-r--r-- | drivers/media/usb/gspca/jeilinj.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/usb/gspca/jeilinj.c b/drivers/media/usb/gspca/jeilinj.c index b897aa86f315..1ba29fe7fada 100644 --- a/drivers/media/usb/gspca/jeilinj.c +++ b/drivers/media/usb/gspca/jeilinj.c | |||
@@ -114,7 +114,7 @@ static void jlj_write2(struct gspca_dev *gspca_dev, unsigned char *command) | |||
114 | } | 114 | } |
115 | 115 | ||
116 | /* Responses are one byte only */ | 116 | /* Responses are one byte only */ |
117 | static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response) | 117 | static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char *response) |
118 | { | 118 | { |
119 | int retval; | 119 | int retval; |
120 | 120 | ||
@@ -123,7 +123,7 @@ static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response) | |||
123 | retval = usb_bulk_msg(gspca_dev->dev, | 123 | retval = usb_bulk_msg(gspca_dev->dev, |
124 | usb_rcvbulkpipe(gspca_dev->dev, 0x84), | 124 | usb_rcvbulkpipe(gspca_dev->dev, 0x84), |
125 | gspca_dev->usb_buf, 1, NULL, 500); | 125 | gspca_dev->usb_buf, 1, NULL, 500); |
126 | response = gspca_dev->usb_buf[0]; | 126 | *response = gspca_dev->usb_buf[0]; |
127 | if (retval < 0) { | 127 | if (retval < 0) { |
128 | pr_err("read command [%02x] error %d\n", | 128 | pr_err("read command [%02x] error %d\n", |
129 | gspca_dev->usb_buf[0], retval); | 129 | gspca_dev->usb_buf[0], retval); |
@@ -260,7 +260,7 @@ static int jlj_start(struct gspca_dev *gspca_dev) | |||
260 | if (start_commands[i].delay) | 260 | if (start_commands[i].delay) |
261 | msleep(start_commands[i].delay); | 261 | msleep(start_commands[i].delay); |
262 | if (start_commands[i].ack_wanted) | 262 | if (start_commands[i].ack_wanted) |
263 | jlj_read1(gspca_dev, response); | 263 | jlj_read1(gspca_dev, &response); |
264 | } | 264 | } |
265 | setcamquality(gspca_dev, v4l2_ctrl_g_ctrl(sd->jpegqual)); | 265 | setcamquality(gspca_dev, v4l2_ctrl_g_ctrl(sd->jpegqual)); |
266 | msleep(2); | 266 | msleep(2); |