diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-01-24 15:49:18 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-01-24 15:49:18 -0500 |
commit | a32f7d1ad3744914273c6907204c2ab3b5d496a0 (patch) | |
tree | 1c5ae321ee85665707177547c07810ff7e09e1ab /drivers/media/usb | |
parent | 6b9e50c463efc5c361496ae6a895cc966ff8025b (diff) | |
parent | 68d6f84ba0c47e658beff3a4bf0c43acee4b4690 (diff) |
Merge branch 'v4l_for_linus' into staging/for_v3.9
* v4l_for_linus: (464 commits)
[media] uvcvideo: Set error_idx properly for S_EXT_CTRLS failures
[media] uvcvideo: Cleanup leftovers of partial revert
[media] uvcvideo: Return -EACCES when trying to set a read-only control
Linux 3.8-rc3
mm: reinstante dropped pmd_trans_splitting() check
cred: Remove tgcred pointer from struct cred
drm/ttm: fix fence locking in ttm_buffer_object_transfer
ARM: clps711x: Fix bad merge of clockevents setup
ARM: highbank: save and restore L2 cache and GIC on suspend
ARM: highbank: add a power request clear
ARM: highbank: fix secondary boot and hotplug
ARM: highbank: fix typos with hignbank in power request functions
ARM: dts: fix highbank cpu mpidr values
ARM: dts: add device_type prop to cpu nodes on Calxeda platforms
drm/prime: drop reference on imported dma-buf come from gem
xen/netfront: improve truesize tracking
ARM: mx5: Fix MX53 flexcan2 clock
ARM: OMAP2+: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
sctp: fix Kconfig bug in default cookie hmac selection
EDAC: Cleanup device deregistering path
...
Conflicts:
drivers/media/pci/dm1105/dm1105.c
drivers/media/platform/soc_camera/mx2_camera.c
Diffstat (limited to 'drivers/media/usb')
-rw-r--r-- | drivers/media/usb/gspca/spca506.c | 3 | ||||
-rw-r--r-- | drivers/media/usb/siano/smsusb.c | 2 | ||||
-rw-r--r-- | drivers/media/usb/usbvision/usbvision-video.c | 10 | ||||
-rw-r--r-- | drivers/media/usb/uvc/uvc_ctrl.c | 15 | ||||
-rw-r--r-- | drivers/media/usb/uvc/uvc_v4l2.c | 18 |
5 files changed, 21 insertions, 27 deletions
diff --git a/drivers/media/usb/gspca/spca506.c b/drivers/media/usb/gspca/spca506.c index bab01c86c315..bcd2c04c770e 100644 --- a/drivers/media/usb/gspca/spca506.c +++ b/drivers/media/usb/gspca/spca506.c | |||
@@ -590,8 +590,7 @@ static const struct usb_device_id device_table[] = { | |||
590 | MODULE_DEVICE_TABLE(usb, device_table); | 590 | MODULE_DEVICE_TABLE(usb, device_table); |
591 | 591 | ||
592 | /* -- device connect -- */ | 592 | /* -- device connect -- */ |
593 | static int __devinit sd_probe(struct usb_interface *intf, | 593 | static int sd_probe(struct usb_interface *intf, const struct usb_device_id *id) |
594 | const struct usb_device_id *id) | ||
595 | { | 594 | { |
596 | return gspca_dev_probe(intf, id, &sd_desc, sizeof(struct sd), | 595 | return gspca_dev_probe(intf, id, &sd_desc, sizeof(struct sd), |
597 | THIS_MODULE); | 596 | THIS_MODULE); |
diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c index aac622200e99..de2c10289eec 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c | |||
@@ -389,7 +389,7 @@ static int smsusb_init_device(struct usb_interface *intf, int board_id) | |||
389 | return rc; | 389 | return rc; |
390 | } | 390 | } |
391 | 391 | ||
392 | static int __devinit smsusb_probe(struct usb_interface *intf, | 392 | static int smsusb_probe(struct usb_interface *intf, |
393 | const struct usb_device_id *id) | 393 | const struct usb_device_id *id) |
394 | { | 394 | { |
395 | struct usb_device *udev = interface_to_usbdev(intf); | 395 | struct usb_device *udev = interface_to_usbdev(intf); |
diff --git a/drivers/media/usb/usbvision/usbvision-video.c b/drivers/media/usb/usbvision/usbvision-video.c index c6bc8ce67375..cd1fe78a5532 100644 --- a/drivers/media/usb/usbvision/usbvision-video.c +++ b/drivers/media/usb/usbvision/usbvision-video.c | |||
@@ -1364,7 +1364,7 @@ static void usbvision_unregister_video(struct usb_usbvision *usbvision) | |||
1364 | } | 1364 | } |
1365 | 1365 | ||
1366 | /* register video4linux devices */ | 1366 | /* register video4linux devices */ |
1367 | static int __devinit usbvision_register_video(struct usb_usbvision *usbvision) | 1367 | static int usbvision_register_video(struct usb_usbvision *usbvision) |
1368 | { | 1368 | { |
1369 | /* Video Device: */ | 1369 | /* Video Device: */ |
1370 | usbvision->vdev = usbvision_vdev_init(usbvision, | 1370 | usbvision->vdev = usbvision_vdev_init(usbvision, |
@@ -1511,8 +1511,8 @@ static void usbvision_configure_video(struct usb_usbvision *usbvision) | |||
1511 | * if it looks like USBVISION video device | 1511 | * if it looks like USBVISION video device |
1512 | * | 1512 | * |
1513 | */ | 1513 | */ |
1514 | static int __devinit usbvision_probe(struct usb_interface *intf, | 1514 | static int usbvision_probe(struct usb_interface *intf, |
1515 | const struct usb_device_id *devid) | 1515 | const struct usb_device_id *devid) |
1516 | { | 1516 | { |
1517 | struct usb_device *dev = usb_get_dev(interface_to_usbdev(intf)); | 1517 | struct usb_device *dev = usb_get_dev(interface_to_usbdev(intf)); |
1518 | struct usb_interface *uif; | 1518 | struct usb_interface *uif; |
@@ -1620,7 +1620,7 @@ static int __devinit usbvision_probe(struct usb_interface *intf, | |||
1620 | * with no ill consequences. | 1620 | * with no ill consequences. |
1621 | * | 1621 | * |
1622 | */ | 1622 | */ |
1623 | static void __devexit usbvision_disconnect(struct usb_interface *intf) | 1623 | static void usbvision_disconnect(struct usb_interface *intf) |
1624 | { | 1624 | { |
1625 | struct usb_usbvision *usbvision = to_usbvision(usb_get_intfdata(intf)); | 1625 | struct usb_usbvision *usbvision = to_usbvision(usb_get_intfdata(intf)); |
1626 | 1626 | ||
@@ -1665,7 +1665,7 @@ static struct usb_driver usbvision_driver = { | |||
1665 | .name = "usbvision", | 1665 | .name = "usbvision", |
1666 | .id_table = usbvision_table, | 1666 | .id_table = usbvision_table, |
1667 | .probe = usbvision_probe, | 1667 | .probe = usbvision_probe, |
1668 | .disconnect = __devexit_p(usbvision_disconnect), | 1668 | .disconnect = usbvision_disconnect, |
1669 | }; | 1669 | }; |
1670 | 1670 | ||
1671 | /* | 1671 | /* |
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 516a5b188ea5..d5baab17a5ef 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c | |||
@@ -1061,7 +1061,7 @@ int uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, | |||
1061 | 1061 | ||
1062 | ctrl = uvc_find_control(chain, v4l2_ctrl->id, &mapping); | 1062 | ctrl = uvc_find_control(chain, v4l2_ctrl->id, &mapping); |
1063 | if (ctrl == NULL) { | 1063 | if (ctrl == NULL) { |
1064 | ret = -ENOENT; | 1064 | ret = -EINVAL; |
1065 | goto done; | 1065 | goto done; |
1066 | } | 1066 | } |
1067 | 1067 | ||
@@ -1099,13 +1099,12 @@ int uvc_query_v4l2_menu(struct uvc_video_chain *chain, | |||
1099 | return -ERESTARTSYS; | 1099 | return -ERESTARTSYS; |
1100 | 1100 | ||
1101 | ctrl = uvc_find_control(chain, query_menu->id, &mapping); | 1101 | ctrl = uvc_find_control(chain, query_menu->id, &mapping); |
1102 | if (ctrl == NULL) { | 1102 | if (ctrl == NULL || mapping->v4l2_type != V4L2_CTRL_TYPE_MENU) { |
1103 | ret = -ENOENT; | 1103 | ret = -EINVAL; |
1104 | goto done; | 1104 | goto done; |
1105 | } | 1105 | } |
1106 | 1106 | ||
1107 | if (mapping->v4l2_type != V4L2_CTRL_TYPE_MENU || | 1107 | if (query_menu->index >= mapping->menu_count) { |
1108 | query_menu->index >= mapping->menu_count) { | ||
1109 | ret = -EINVAL; | 1108 | ret = -EINVAL; |
1110 | goto done; | 1109 | goto done; |
1111 | } | 1110 | } |
@@ -1264,7 +1263,7 @@ static int uvc_ctrl_add_event(struct v4l2_subscribed_event *sev, unsigned elems) | |||
1264 | 1263 | ||
1265 | ctrl = uvc_find_control(handle->chain, sev->id, &mapping); | 1264 | ctrl = uvc_find_control(handle->chain, sev->id, &mapping); |
1266 | if (ctrl == NULL) { | 1265 | if (ctrl == NULL) { |
1267 | ret = -ENOENT; | 1266 | ret = -EINVAL; |
1268 | goto done; | 1267 | goto done; |
1269 | } | 1268 | } |
1270 | 1269 | ||
@@ -1415,7 +1414,7 @@ int uvc_ctrl_get(struct uvc_video_chain *chain, | |||
1415 | 1414 | ||
1416 | ctrl = uvc_find_control(chain, xctrl->id, &mapping); | 1415 | ctrl = uvc_find_control(chain, xctrl->id, &mapping); |
1417 | if (ctrl == NULL) | 1416 | if (ctrl == NULL) |
1418 | return -ENOENT; | 1417 | return -EINVAL; |
1419 | 1418 | ||
1420 | return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); | 1419 | return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); |
1421 | } | 1420 | } |
@@ -1433,7 +1432,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, | |||
1433 | 1432 | ||
1434 | ctrl = uvc_find_control(chain, xctrl->id, &mapping); | 1433 | ctrl = uvc_find_control(chain, xctrl->id, &mapping); |
1435 | if (ctrl == NULL) | 1434 | if (ctrl == NULL) |
1436 | return -ENOENT; | 1435 | return -EINVAL; |
1437 | if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) | 1436 | if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) |
1438 | return -EACCES; | 1437 | return -EACCES; |
1439 | 1438 | ||
diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 8e056046bc20..68d59b527492 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c | |||
@@ -607,10 +607,8 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) | |||
607 | 607 | ||
608 | ret = uvc_ctrl_get(chain, &xctrl); | 608 | ret = uvc_ctrl_get(chain, &xctrl); |
609 | uvc_ctrl_rollback(handle); | 609 | uvc_ctrl_rollback(handle); |
610 | if (ret < 0) | 610 | if (ret >= 0) |
611 | return ret == -ENOENT ? -EINVAL : ret; | 611 | ctrl->value = xctrl.value; |
612 | |||
613 | ctrl->value = xctrl.value; | ||
614 | break; | 612 | break; |
615 | } | 613 | } |
616 | 614 | ||
@@ -634,7 +632,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) | |||
634 | ret = uvc_ctrl_set(chain, &xctrl); | 632 | ret = uvc_ctrl_set(chain, &xctrl); |
635 | if (ret < 0) { | 633 | if (ret < 0) { |
636 | uvc_ctrl_rollback(handle); | 634 | uvc_ctrl_rollback(handle); |
637 | return ret == -ENOENT ? -EINVAL : ret; | 635 | return ret; |
638 | } | 636 | } |
639 | ret = uvc_ctrl_commit(handle, &xctrl, 1); | 637 | ret = uvc_ctrl_commit(handle, &xctrl, 1); |
640 | if (ret == 0) | 638 | if (ret == 0) |
@@ -659,9 +657,8 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) | |||
659 | ret = uvc_ctrl_get(chain, ctrl); | 657 | ret = uvc_ctrl_get(chain, ctrl); |
660 | if (ret < 0) { | 658 | if (ret < 0) { |
661 | uvc_ctrl_rollback(handle); | 659 | uvc_ctrl_rollback(handle); |
662 | ctrls->error_idx = ret == -ENOENT | 660 | ctrls->error_idx = i; |
663 | ? ctrls->count : i; | 661 | return ret; |
664 | return ret == -ENOENT ? -EINVAL : ret; | ||
665 | } | 662 | } |
666 | } | 663 | } |
667 | ctrls->error_idx = 0; | 664 | ctrls->error_idx = 0; |
@@ -688,10 +685,9 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) | |||
688 | ret = uvc_ctrl_set(chain, ctrl); | 685 | ret = uvc_ctrl_set(chain, ctrl); |
689 | if (ret < 0) { | 686 | if (ret < 0) { |
690 | uvc_ctrl_rollback(handle); | 687 | uvc_ctrl_rollback(handle); |
691 | ctrls->error_idx = (ret == -ENOENT && | 688 | ctrls->error_idx = cmd == VIDIOC_S_EXT_CTRLS |
692 | cmd == VIDIOC_S_EXT_CTRLS) | ||
693 | ? ctrls->count : i; | 689 | ? ctrls->count : i; |
694 | return ret == -ENOENT ? -EINVAL : ret; | 690 | return ret; |
695 | } | 691 | } |
696 | } | 692 | } |
697 | 693 | ||