aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/tuners
diff options
context:
space:
mode:
authorAntti Palosaari <crope@iki.fi>2012-12-09 11:42:25 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-01-06 06:08:23 -0500
commit4562620159c6c0c3c11913d518138a27e6ecd957 (patch)
tree38e4142f74995ca7ebe326e5e3600bc7c28bb6f1 /drivers/media/tuners
parent44ff69cd95308c115134f0546317b584fe1bf5b2 (diff)
[media] fc0012: use Kernel dev_foo() logging
Signed-off-by: Antti Palosaari <crope@iki.fi> Acked-by: Hans-Frieder Vogt <hfvogt@gmx.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/tuners')
-rw-r--r--drivers/media/tuners/fc0012-priv.h9
-rw-r--r--drivers/media/tuners/fc0012.c20
-rw-r--r--drivers/media/tuners/fc0012.h2
3 files changed, 15 insertions, 16 deletions
diff --git a/drivers/media/tuners/fc0012-priv.h b/drivers/media/tuners/fc0012-priv.h
index 3b98bf971fb3..1a86ce1d3fcf 100644
--- a/drivers/media/tuners/fc0012-priv.h
+++ b/drivers/media/tuners/fc0012-priv.h
@@ -21,15 +21,6 @@
21#ifndef _FC0012_PRIV_H_ 21#ifndef _FC0012_PRIV_H_
22#define _FC0012_PRIV_H_ 22#define _FC0012_PRIV_H_
23 23
24#define LOG_PREFIX "fc0012"
25
26#undef err
27#define err(f, arg...) printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg)
28#undef info
29#define info(f, arg...) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg)
30#undef warn
31#define warn(f, arg...) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg)
32
33struct fc0012_priv { 24struct fc0012_priv {
34 struct i2c_adapter *i2c; 25 struct i2c_adapter *i2c;
35 const struct fc0012_config *cfg; 26 const struct fc0012_config *cfg;
diff --git a/drivers/media/tuners/fc0012.c b/drivers/media/tuners/fc0012.c
index feb15941cc5b..4491f063e211 100644
--- a/drivers/media/tuners/fc0012.c
+++ b/drivers/media/tuners/fc0012.c
@@ -29,7 +29,9 @@ static int fc0012_writereg(struct fc0012_priv *priv, u8 reg, u8 val)
29 }; 29 };
30 30
31 if (i2c_transfer(priv->i2c, &msg, 1) != 1) { 31 if (i2c_transfer(priv->i2c, &msg, 1) != 1) {
32 err("I2C write reg failed, reg: %02x, val: %02x", reg, val); 32 dev_err(&priv->i2c->dev,
33 "%s: I2C write reg failed, reg: %02x, val: %02x\n",
34 KBUILD_MODNAME, reg, val);
33 return -EREMOTEIO; 35 return -EREMOTEIO;
34 } 36 }
35 return 0; 37 return 0;
@@ -45,7 +47,9 @@ static int fc0012_readreg(struct fc0012_priv *priv, u8 reg, u8 *val)
45 }; 47 };
46 48
47 if (i2c_transfer(priv->i2c, msg, 2) != 2) { 49 if (i2c_transfer(priv->i2c, msg, 2) != 2) {
48 err("I2C read reg failed, reg: %02x", reg); 50 dev_err(&priv->i2c->dev,
51 "%s: I2C read reg failed, reg: %02x\n",
52 KBUILD_MODNAME, reg);
49 return -EREMOTEIO; 53 return -EREMOTEIO;
50 } 54 }
51 return 0; 55 return 0;
@@ -119,7 +123,8 @@ static int fc0012_init(struct dvb_frontend *fe)
119 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */ 123 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */
120 124
121 if (ret) 125 if (ret)
122 err("fc0012_writereg failed: %d", ret); 126 dev_err(&priv->i2c->dev, "%s: fc0012_writereg failed: %d\n",
127 KBUILD_MODNAME, ret);
123 128
124 return ret; 129 return ret;
125} 130}
@@ -261,7 +266,8 @@ static int fc0012_set_params(struct dvb_frontend *fe)
261 break; 266 break;
262 } 267 }
263 } else { 268 } else {
264 err("%s: modulation type not supported!", __func__); 269 dev_err(&priv->i2c->dev, "%s: modulation type not supported!\n",
270 KBUILD_MODNAME);
265 return -EINVAL; 271 return -EINVAL;
266 } 272 }
267 273
@@ -323,7 +329,8 @@ exit:
323 if (fe->ops.i2c_gate_ctrl) 329 if (fe->ops.i2c_gate_ctrl)
324 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */ 330 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */
325 if (ret) 331 if (ret)
326 warn("%s: failed: %d", __func__, ret); 332 dev_warn(&priv->i2c->dev, "%s: %s failed: %d\n",
333 KBUILD_MODNAME, __func__, ret);
327 return ret; 334 return ret;
328} 335}
329 336
@@ -413,7 +420,8 @@ err:
413 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */ 420 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */
414exit: 421exit:
415 if (ret) 422 if (ret)
416 warn("%s: failed: %d", __func__, ret); 423 dev_warn(&priv->i2c->dev, "%s: %s failed: %d\n",
424 KBUILD_MODNAME, __func__, ret);
417 return ret; 425 return ret;
418} 426}
419 427
diff --git a/drivers/media/tuners/fc0012.h b/drivers/media/tuners/fc0012.h
index 3fb53b86813a..54508fcc3469 100644
--- a/drivers/media/tuners/fc0012.h
+++ b/drivers/media/tuners/fc0012.h
@@ -58,7 +58,7 @@ static inline struct dvb_frontend *fc0012_attach(struct dvb_frontend *fe,
58 struct i2c_adapter *i2c, 58 struct i2c_adapter *i2c,
59 const struct fc0012_config *cfg) 59 const struct fc0012_config *cfg)
60{ 60{
61 printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); 61 pr_warn("%s: driver disabled by Kconfig\n", __func__);
62 return NULL; 62 return NULL;
63} 63}
64#endif 64#endif