aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/rc
diff options
context:
space:
mode:
authorKevin Baradon <kevin.baradon@gmail.com>2013-02-18 13:10:22 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-03-21 17:37:32 -0400
commite9e7a16d6da4af030ccb117079dcf1ef66bd5804 (patch)
treed96ba8bb10bc361071a20180a92e02237e39a280 /drivers/media/rc
parent26ccbec44a7c62de4fef4f33bb858963e501921d (diff)
[media] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad is pressed
My 15c2:0036 device floods syslog when a keypad key is pressed: Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fef2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 This patch removes those messages from imon, following suggestion from Mauro. Unknown keys shall be correctly handled by rc/input layer. Signed-off-by: Kevin Baradon <kevin.baradon@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/rc')
-rw-r--r--drivers/media/rc/imon.c11
1 files changed, 0 insertions, 11 deletions
diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index 178b94660b58..b8f9f85a11c9 100644
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -1573,11 +1573,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
1573 if (press_type < 0) 1573 if (press_type < 0)
1574 goto not_input_data; 1574 goto not_input_data;
1575 1575
1576 spin_lock_irqsave(&ictx->kc_lock, flags);
1577 if (ictx->kc == KEY_UNKNOWN)
1578 goto unknown_key;
1579 spin_unlock_irqrestore(&ictx->kc_lock, flags);
1580
1581 if (ktype != IMON_KEY_PANEL) { 1576 if (ktype != IMON_KEY_PANEL) {
1582 if (press_type == 0) 1577 if (press_type == 0)
1583 rc_keyup(ictx->rdev); 1578 rc_keyup(ictx->rdev);
@@ -1620,12 +1615,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
1620 1615
1621 return; 1616 return;
1622 1617
1623unknown_key:
1624 spin_unlock_irqrestore(&ictx->kc_lock, flags);
1625 dev_info(dev, "%s: unknown keypress, code 0x%llx\n", __func__,
1626 (long long)scancode);
1627 return;
1628
1629not_input_data: 1618not_input_data:
1630 if (len != 8) { 1619 if (len != 8) {
1631 dev_warn(dev, "imon %s: invalid incoming packet " 1620 dev_warn(dev, "imon %s: invalid incoming packet "