aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/rc
diff options
context:
space:
mode:
authorTimo Kokkonen <timo.t.kokkonen@iki.fi>2012-08-30 12:54:25 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-09-15 14:07:31 -0400
commit362b29ba6eec506ff769ff465a2418b3fb74c8d6 (patch)
tree8f5a2b87f93a6e035ea4d25219d822b21242a6c9 /drivers/media/rc
parent3404cb5c4dbbbac884722f418d5561d81dba969f (diff)
[media] ir-rx51: Trivial fixes
-Fix typo -Change pwm_timer_num type to match type in platform data -Remove extra parenthesis -Replace magic constant with proper bit defintions -Remove duplicate exit pointer Signed-off-by: Timo Kokkonen <timo.t.kokkonen@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/rc')
-rw-r--r--drivers/media/rc/Kconfig2
-rw-r--r--drivers/media/rc/ir-rx51.c10
2 files changed, 7 insertions, 5 deletions
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index a7b31b61e2fc..6b0b9f0e6c6c 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -296,7 +296,7 @@ config IR_RX51
296 Say Y or M here if you want to enable support for the IR 296 Say Y or M here if you want to enable support for the IR
297 transmitter diode built in the Nokia N900 (RX51) device. 297 transmitter diode built in the Nokia N900 (RX51) device.
298 298
299 The driver uses omap DM timers for gereating the carrier 299 The driver uses omap DM timers for generating the carrier
300 wave and pulses. 300 wave and pulses.
301 301
302config RC_LOOPBACK 302config RC_LOOPBACK
diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
index 9487dd33a89a..546199e9ccc7 100644
--- a/drivers/media/rc/ir-rx51.c
+++ b/drivers/media/rc/ir-rx51.c
@@ -59,7 +59,7 @@ struct lirc_rx51 {
59 int wbuf[WBUF_LEN]; 59 int wbuf[WBUF_LEN];
60 int wbuf_index; 60 int wbuf_index;
61 unsigned long device_is_open; 61 unsigned long device_is_open;
62 unsigned int pwm_timer_num; 62 int pwm_timer_num;
63}; 63};
64 64
65static void lirc_rx51_on(struct lirc_rx51 *lirc_rx51) 65static void lirc_rx51_on(struct lirc_rx51 *lirc_rx51)
@@ -125,11 +125,14 @@ static irqreturn_t lirc_rx51_interrupt_handler(int irq, void *ptr)
125 if (!retval) 125 if (!retval)
126 return IRQ_NONE; 126 return IRQ_NONE;
127 127
128 if ((retval & ~OMAP_TIMER_INT_MATCH)) 128 if (retval & ~OMAP_TIMER_INT_MATCH)
129 dev_err_ratelimited(lirc_rx51->dev, 129 dev_err_ratelimited(lirc_rx51->dev,
130 ": Unexpected interrupt source: %x\n", retval); 130 ": Unexpected interrupt source: %x\n", retval);
131 131
132 omap_dm_timer_write_status(lirc_rx51->pulse_timer, 7); 132 omap_dm_timer_write_status(lirc_rx51->pulse_timer,
133 OMAP_TIMER_INT_MATCH |
134 OMAP_TIMER_INT_OVERFLOW |
135 OMAP_TIMER_INT_CAPTURE);
133 if (lirc_rx51->wbuf_index < 0) { 136 if (lirc_rx51->wbuf_index < 0) {
134 dev_err_ratelimited(lirc_rx51->dev, 137 dev_err_ratelimited(lirc_rx51->dev,
135 ": BUG wbuf_index has value of %i\n", 138 ": BUG wbuf_index has value of %i\n",
@@ -472,7 +475,6 @@ struct platform_driver lirc_rx51_platform_driver = {
472 .remove = __exit_p(lirc_rx51_remove), 475 .remove = __exit_p(lirc_rx51_remove),
473 .suspend = lirc_rx51_suspend, 476 .suspend = lirc_rx51_suspend,
474 .resume = lirc_rx51_resume, 477 .resume = lirc_rx51_resume,
475 .remove = __exit_p(lirc_rx51_remove),
476 .driver = { 478 .driver = {
477 .name = DRIVER_NAME, 479 .name = DRIVER_NAME,
478 .owner = THIS_MODULE, 480 .owner = THIS_MODULE,