diff options
author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-04 12:14:25 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-09-27 13:18:54 -0400 |
commit | 0bd0dbee3f49c46ba860f21f97a98ac64781be5d (patch) | |
tree | 36a1b8f392eda2f41a9ea3ece6125fe6b91fb986 /drivers/media/platform | |
parent | a694f1b2af4942a1e0026e7929b4f7c5c251f82d (diff) |
[media] omap3isp: Fix error return code in probe function
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
[laurent.pinchart@ideasonboard.com Replaced EBUSY with ENODEV]
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform')
-rw-r--r-- | drivers/media/platform/omap3isp/isp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index e0096e07dbdc..d7aa513dcc8d 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c | |||
@@ -2102,8 +2102,10 @@ static int __devinit isp_probe(struct platform_device *pdev) | |||
2102 | if (ret < 0) | 2102 | if (ret < 0) |
2103 | goto error; | 2103 | goto error; |
2104 | 2104 | ||
2105 | if (__omap3isp_get(isp, false) == NULL) | 2105 | if (__omap3isp_get(isp, false) == NULL) { |
2106 | ret = -ENODEV; | ||
2106 | goto error; | 2107 | goto error; |
2108 | } | ||
2107 | 2109 | ||
2108 | ret = isp_reset(isp); | 2110 | ret = isp_reset(isp); |
2109 | if (ret < 0) | 2111 | if (ret < 0) |