diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2013-03-15 05:10:40 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-24 05:47:00 -0400 |
commit | 314527acbbb3f33f72c2ef19d8cfabcada9912a5 (patch) | |
tree | 871021b9e888444f9f71f5c12ecf0272d77fdf8d /drivers/media/platform/timblogiw.c | |
parent | 2f73c7c582a685b3198b974cd6d964d0338f8ab5 (diff) |
[media] v4l2: pass std by value to the write-only s_std ioctl
This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform/timblogiw.c')
-rw-r--r-- | drivers/media/platform/timblogiw.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/platform/timblogiw.c b/drivers/media/platform/timblogiw.c index 2d91eeb1d2ae..a2f7bdd5104f 100644 --- a/drivers/media/platform/timblogiw.c +++ b/drivers/media/platform/timblogiw.c | |||
@@ -336,7 +336,7 @@ static int timblogiw_g_std(struct file *file, void *priv, v4l2_std_id *std) | |||
336 | return 0; | 336 | return 0; |
337 | } | 337 | } |
338 | 338 | ||
339 | static int timblogiw_s_std(struct file *file, void *priv, v4l2_std_id *std) | 339 | static int timblogiw_s_std(struct file *file, void *priv, v4l2_std_id std) |
340 | { | 340 | { |
341 | struct video_device *vdev = video_devdata(file); | 341 | struct video_device *vdev = video_devdata(file); |
342 | struct timblogiw *lw = video_get_drvdata(vdev); | 342 | struct timblogiw *lw = video_get_drvdata(vdev); |
@@ -348,10 +348,10 @@ static int timblogiw_s_std(struct file *file, void *priv, v4l2_std_id *std) | |||
348 | mutex_lock(&lw->lock); | 348 | mutex_lock(&lw->lock); |
349 | 349 | ||
350 | if (TIMBLOGIW_HAS_DECODER(lw)) | 350 | if (TIMBLOGIW_HAS_DECODER(lw)) |
351 | err = v4l2_subdev_call(lw->sd_enc, core, s_std, *std); | 351 | err = v4l2_subdev_call(lw->sd_enc, core, s_std, std); |
352 | 352 | ||
353 | if (!err) | 353 | if (!err) |
354 | fh->cur_norm = timblogiw_get_norm(*std); | 354 | fh->cur_norm = timblogiw_get_norm(std); |
355 | 355 | ||
356 | mutex_unlock(&lw->lock); | 356 | mutex_unlock(&lw->lock); |
357 | 357 | ||