diff options
author | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-09-03 14:50:39 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-09-03 16:59:27 -0400 |
commit | d8e8b40c067c3242b32ebe835f6bc6247fd67454 (patch) | |
tree | 7a298b2986f83eeb7f3fd21abe2a6e1de4206464 /drivers/media/platform/s5p-tv | |
parent | a04557a20be0ff3733eca454abdd1bd4c5ebc3f2 (diff) |
[media] s5p-tv: Simplify the return logic
Make sure pm_runtime_* calls does not use unnecessary
IS_ERR_VALUE().
Reported by scripts/coccinelle/api/pm_runtime.cocci script.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/platform/s5p-tv')
-rw-r--r-- | drivers/media/platform/s5p-tv/hdmi_drv.c | 2 | ||||
-rw-r--r-- | drivers/media/platform/s5p-tv/sdo_drv.c | 2 | ||||
-rw-r--r-- | drivers/media/platform/s5p-tv/sii9234_drv.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 754740f4b671..37c8bd694c5f 100644 --- a/drivers/media/platform/s5p-tv/hdmi_drv.c +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c | |||
@@ -615,7 +615,7 @@ static int hdmi_s_power(struct v4l2_subdev *sd, int on) | |||
615 | else | 615 | else |
616 | ret = pm_runtime_put_sync(hdev->dev); | 616 | ret = pm_runtime_put_sync(hdev->dev); |
617 | /* only values < 0 indicate errors */ | 617 | /* only values < 0 indicate errors */ |
618 | return IS_ERR_VALUE(ret) ? ret : 0; | 618 | return ret < 0 ? ret : 0; |
619 | } | 619 | } |
620 | 620 | ||
621 | static int hdmi_s_dv_timings(struct v4l2_subdev *sd, | 621 | static int hdmi_s_dv_timings(struct v4l2_subdev *sd, |
diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index 5a7c3796f22e..72cf892dd008 100644 --- a/drivers/media/platform/s5p-tv/sdo_drv.c +++ b/drivers/media/platform/s5p-tv/sdo_drv.c | |||
@@ -190,7 +190,7 @@ static int sdo_s_power(struct v4l2_subdev *sd, int on) | |||
190 | ret = pm_runtime_put_sync(dev); | 190 | ret = pm_runtime_put_sync(dev); |
191 | 191 | ||
192 | /* only values < 0 indicate errors */ | 192 | /* only values < 0 indicate errors */ |
193 | return IS_ERR_VALUE(ret) ? ret : 0; | 193 | return ret < 0 ? ret : 0; |
194 | } | 194 | } |
195 | 195 | ||
196 | static int sdo_streamon(struct sdo_device *sdev) | 196 | static int sdo_streamon(struct sdo_device *sdev) |
diff --git a/drivers/media/platform/s5p-tv/sii9234_drv.c b/drivers/media/platform/s5p-tv/sii9234_drv.c index 3dd762e5b67e..db8c17bb4aaa 100644 --- a/drivers/media/platform/s5p-tv/sii9234_drv.c +++ b/drivers/media/platform/s5p-tv/sii9234_drv.c | |||
@@ -289,7 +289,7 @@ static int sii9234_s_power(struct v4l2_subdev *sd, int on) | |||
289 | else | 289 | else |
290 | ret = pm_runtime_put(&ctx->client->dev); | 290 | ret = pm_runtime_put(&ctx->client->dev); |
291 | /* only values < 0 indicate errors */ | 291 | /* only values < 0 indicate errors */ |
292 | return IS_ERR_VALUE(ret) ? ret : 0; | 292 | return ret < 0 ? ret : 0; |
293 | } | 293 | } |
294 | 294 | ||
295 | static int sii9234_s_stream(struct v4l2_subdev *sd, int enable) | 295 | static int sii9234_s_stream(struct v4l2_subdev *sd, int enable) |