diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2013-03-15 05:10:40 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-24 05:47:00 -0400 |
commit | 314527acbbb3f33f72c2ef19d8cfabcada9912a5 (patch) | |
tree | 871021b9e888444f9f71f5c12ecf0272d77fdf8d /drivers/media/platform/s5p-tv | |
parent | 2f73c7c582a685b3198b974cd6d964d0338f8ab5 (diff) |
[media] v4l2: pass std by value to the write-only s_std ioctl
This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform/s5p-tv')
-rw-r--r-- | drivers/media/platform/s5p-tv/mixer_video.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv/mixer_video.c index 9961e13f683d..ef0efdf422fe 100644 --- a/drivers/media/platform/s5p-tv/mixer_video.c +++ b/drivers/media/platform/s5p-tv/mixer_video.c | |||
@@ -574,7 +574,7 @@ static int mxr_dv_timings_cap(struct file *file, void *fh, | |||
574 | return ret ? -EINVAL : 0; | 574 | return ret ? -EINVAL : 0; |
575 | } | 575 | } |
576 | 576 | ||
577 | static int mxr_s_std(struct file *file, void *fh, v4l2_std_id *norm) | 577 | static int mxr_s_std(struct file *file, void *fh, v4l2_std_id norm) |
578 | { | 578 | { |
579 | struct mxr_layer *layer = video_drvdata(file); | 579 | struct mxr_layer *layer = video_drvdata(file); |
580 | struct mxr_device *mdev = layer->mdev; | 580 | struct mxr_device *mdev = layer->mdev; |
@@ -591,7 +591,7 @@ static int mxr_s_std(struct file *file, void *fh, v4l2_std_id *norm) | |||
591 | return -EBUSY; | 591 | return -EBUSY; |
592 | } | 592 | } |
593 | 593 | ||
594 | ret = v4l2_subdev_call(to_outsd(mdev), video, s_std_output, *norm); | 594 | ret = v4l2_subdev_call(to_outsd(mdev), video, s_std_output, norm); |
595 | 595 | ||
596 | mutex_unlock(&mdev->mutex); | 596 | mutex_unlock(&mdev->mutex); |
597 | 597 | ||