diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-08-14 04:11:15 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2013-08-22 11:45:23 -0400 |
commit | 5be789fc84a752946f6bdf263b053ed7d4a12a1c (patch) | |
tree | b5670c2f949f38b42cb320bda4cb9af50bb4aed3 /drivers/media/platform/marvell-ccic | |
parent | ec532503209053bbee0c7dac410031e50835e01a (diff) |
[media] marvell-ccic/mmp-driver.c: simplify use of devm_ioremap_resource
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@
- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/platform/marvell-ccic')
-rw-r--r-- | drivers/media/platform/marvell-ccic/mmp-driver.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c index f06daa4f2502..b5a19af5c587 100644 --- a/drivers/media/platform/marvell-ccic/mmp-driver.c +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c | |||
@@ -396,10 +396,6 @@ static int mmpcam_probe(struct platform_device *pdev) | |||
396 | * Get our I/O memory. | 396 | * Get our I/O memory. |
397 | */ | 397 | */ |
398 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 398 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
399 | if (res == NULL) { | ||
400 | dev_err(&pdev->dev, "no iomem resource!\n"); | ||
401 | return -ENODEV; | ||
402 | } | ||
403 | mcam->regs = devm_ioremap_resource(&pdev->dev, res); | 399 | mcam->regs = devm_ioremap_resource(&pdev->dev, res); |
404 | if (IS_ERR(mcam->regs)) | 400 | if (IS_ERR(mcam->regs)) |
405 | return PTR_ERR(mcam->regs); | 401 | return PTR_ERR(mcam->regs); |
@@ -409,10 +405,6 @@ static int mmpcam_probe(struct platform_device *pdev) | |||
409 | * should really be managed outside of this driver? | 405 | * should really be managed outside of this driver? |
410 | */ | 406 | */ |
411 | res = platform_get_resource(pdev, IORESOURCE_MEM, 1); | 407 | res = platform_get_resource(pdev, IORESOURCE_MEM, 1); |
412 | if (res == NULL) { | ||
413 | dev_err(&pdev->dev, "no power resource!\n"); | ||
414 | return -ENODEV; | ||
415 | } | ||
416 | cam->power_regs = devm_ioremap_resource(&pdev->dev, res); | 408 | cam->power_regs = devm_ioremap_resource(&pdev->dev, res); |
417 | if (IS_ERR(cam->power_regs)) | 409 | if (IS_ERR(cam->power_regs)) |
418 | return PTR_ERR(cam->power_regs); | 410 | return PTR_ERR(cam->power_regs); |