diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2013-03-15 05:10:40 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-24 05:47:00 -0400 |
commit | 314527acbbb3f33f72c2ef19d8cfabcada9912a5 (patch) | |
tree | 871021b9e888444f9f71f5c12ecf0272d77fdf8d /drivers/media/platform/blackfin | |
parent | 2f73c7c582a685b3198b974cd6d964d0338f8ab5 (diff) |
[media] v4l2: pass std by value to the write-only s_std ioctl
This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform/blackfin')
-rw-r--r-- | drivers/media/platform/blackfin/bfin_capture.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c index 476cfc88d144..96f6a4922d0c 100644 --- a/drivers/media/platform/blackfin/bfin_capture.c +++ b/drivers/media/platform/blackfin/bfin_capture.c | |||
@@ -633,7 +633,7 @@ static int bcap_g_std(struct file *file, void *priv, v4l2_std_id *std) | |||
633 | return 0; | 633 | return 0; |
634 | } | 634 | } |
635 | 635 | ||
636 | static int bcap_s_std(struct file *file, void *priv, v4l2_std_id *std) | 636 | static int bcap_s_std(struct file *file, void *priv, v4l2_std_id std) |
637 | { | 637 | { |
638 | struct bcap_device *bcap_dev = video_drvdata(file); | 638 | struct bcap_device *bcap_dev = video_drvdata(file); |
639 | int ret; | 639 | int ret; |
@@ -641,11 +641,11 @@ static int bcap_s_std(struct file *file, void *priv, v4l2_std_id *std) | |||
641 | if (vb2_is_busy(&bcap_dev->buffer_queue)) | 641 | if (vb2_is_busy(&bcap_dev->buffer_queue)) |
642 | return -EBUSY; | 642 | return -EBUSY; |
643 | 643 | ||
644 | ret = v4l2_subdev_call(bcap_dev->sd, core, s_std, *std); | 644 | ret = v4l2_subdev_call(bcap_dev->sd, core, s_std, std); |
645 | if (ret < 0) | 645 | if (ret < 0) |
646 | return ret; | 646 | return ret; |
647 | 647 | ||
648 | bcap_dev->std = *std; | 648 | bcap_dev->std = std; |
649 | return 0; | 649 | return 0; |
650 | } | 650 | } |
651 | 651 | ||