diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2013-03-15 05:10:40 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-24 05:47:00 -0400 |
commit | 314527acbbb3f33f72c2ef19d8cfabcada9912a5 (patch) | |
tree | 871021b9e888444f9f71f5c12ecf0272d77fdf8d /drivers/media/pci/bt8xx/bttv-driver.c | |
parent | 2f73c7c582a685b3198b974cd6d964d0338f8ab5 (diff) |
[media] v4l2: pass std by value to the write-only s_std ioctl
This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci/bt8xx/bttv-driver.c')
-rw-r--r-- | drivers/media/pci/bt8xx/bttv-driver.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 7aea24bf3a37..4b9a256f506e 100644 --- a/drivers/media/pci/bt8xx/bttv-driver.c +++ b/drivers/media/pci/bt8xx/bttv-driver.c | |||
@@ -1713,7 +1713,7 @@ static void radio_enable(struct bttv *btv) | |||
1713 | } | 1713 | } |
1714 | } | 1714 | } |
1715 | 1715 | ||
1716 | static int bttv_s_std(struct file *file, void *priv, v4l2_std_id *id) | 1716 | static int bttv_s_std(struct file *file, void *priv, v4l2_std_id id) |
1717 | { | 1717 | { |
1718 | struct bttv_fh *fh = priv; | 1718 | struct bttv_fh *fh = priv; |
1719 | struct bttv *btv = fh->btv; | 1719 | struct bttv *btv = fh->btv; |
@@ -1721,14 +1721,14 @@ static int bttv_s_std(struct file *file, void *priv, v4l2_std_id *id) | |||
1721 | int err = 0; | 1721 | int err = 0; |
1722 | 1722 | ||
1723 | for (i = 0; i < BTTV_TVNORMS; i++) | 1723 | for (i = 0; i < BTTV_TVNORMS; i++) |
1724 | if (*id & bttv_tvnorms[i].v4l2_id) | 1724 | if (id & bttv_tvnorms[i].v4l2_id) |
1725 | break; | 1725 | break; |
1726 | if (i == BTTV_TVNORMS) { | 1726 | if (i == BTTV_TVNORMS) { |
1727 | err = -EINVAL; | 1727 | err = -EINVAL; |
1728 | goto err; | 1728 | goto err; |
1729 | } | 1729 | } |
1730 | 1730 | ||
1731 | btv->std = *id; | 1731 | btv->std = id; |
1732 | set_tvnorm(btv, i); | 1732 | set_tvnorm(btv, i); |
1733 | 1733 | ||
1734 | err: | 1734 | err: |