diff options
author | Manu Abraham <abraham.manu@gmail.com> | 2009-12-15 06:47:21 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-01-17 08:55:44 -0500 |
commit | f5ae4f6f482191c531ea9e50ac91d9bd2ffca171 (patch) | |
tree | a5a1c9553ae58fb19eddbb594f8f0596a3b33e20 /drivers/media/dvb/mantis | |
parent | 1e42dc78900e9d0ce89d77f3ba6aca00abd5f1b5 (diff) |
V4L/DVB (13809): Fix Checkpatch violations
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb/mantis')
-rw-r--r-- | drivers/media/dvb/mantis/hopper_cards.c | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_ca.c | 4 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_cards.c | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_core.c | 48 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_core.h | 14 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_dma.c | 11 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_dvb.c | 12 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_i2c.c | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_input.c | 28 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_reg.h | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_vp1033.c | 12 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_vp1034.c | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_vp1041.c | 9 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_vp2033.c | 2 | ||||
-rw-r--r-- | drivers/media/dvb/mantis/mantis_vp2040.c | 2 |
15 files changed, 78 insertions, 74 deletions
diff --git a/drivers/media/dvb/mantis/hopper_cards.c b/drivers/media/dvb/mantis/hopper_cards.c index 6d5d101f0ab0..ca70149f3ddf 100644 --- a/drivers/media/dvb/mantis/hopper_cards.c +++ b/drivers/media/dvb/mantis/hopper_cards.c | |||
@@ -137,7 +137,7 @@ static int __devinit hopper_pci_probe(struct pci_dev *pdev, const struct pci_dev | |||
137 | struct mantis_hwconfig *config; | 137 | struct mantis_hwconfig *config; |
138 | int err = 0; | 138 | int err = 0; |
139 | 139 | ||
140 | mantis = kzalloc(sizeof (struct mantis_pci), GFP_KERNEL); | 140 | mantis = kzalloc(sizeof(struct mantis_pci), GFP_KERNEL); |
141 | if (mantis == NULL) { | 141 | if (mantis == NULL) { |
142 | printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); | 142 | printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); |
143 | err = -ENOMEM; | 143 | err = -ENOMEM; |
diff --git a/drivers/media/dvb/mantis/mantis_ca.c b/drivers/media/dvb/mantis/mantis_ca.c index 88899ac96d63..2f3ba81eaa07 100644 --- a/drivers/media/dvb/mantis/mantis_ca.c +++ b/drivers/media/dvb/mantis/mantis_ca.c | |||
@@ -119,7 +119,7 @@ static int mantis_ts_control(struct dvb_ca_en50221 *en50221, int slot) | |||
119 | struct mantis_pci *mantis = ca->ca_priv; | 119 | struct mantis_pci *mantis = ca->ca_priv; |
120 | 120 | ||
121 | dprintk(MANTIS_DEBUG, 1, "Slot(%d): TS control", slot); | 121 | dprintk(MANTIS_DEBUG, 1, "Slot(%d): TS control", slot); |
122 | // mantis_set_direction(mantis, 1); /* Enable TS through CAM */ | 122 | /* mantis_set_direction(mantis, 1); */ /* Enable TS through CAM */ |
123 | 123 | ||
124 | return 0; | 124 | return 0; |
125 | } | 125 | } |
@@ -148,7 +148,7 @@ int mantis_ca_init(struct mantis_pci *mantis) | |||
148 | int ca_flags = 0, result; | 148 | int ca_flags = 0, result; |
149 | 149 | ||
150 | dprintk(MANTIS_DEBUG, 1, "Initializing Mantis CA"); | 150 | dprintk(MANTIS_DEBUG, 1, "Initializing Mantis CA"); |
151 | ca = kzalloc(sizeof (struct mantis_ca), GFP_KERNEL); | 151 | ca = kzalloc(sizeof(struct mantis_ca), GFP_KERNEL); |
152 | if (!ca) { | 152 | if (!ca) { |
153 | dprintk(MANTIS_ERROR, 1, "Out of memory!, exiting .."); | 153 | dprintk(MANTIS_ERROR, 1, "Out of memory!, exiting .."); |
154 | result = -ENOMEM; | 154 | result = -ENOMEM; |
diff --git a/drivers/media/dvb/mantis/mantis_cards.c b/drivers/media/dvb/mantis/mantis_cards.c index f3fefbbc876f..a4250fad6ac1 100644 --- a/drivers/media/dvb/mantis/mantis_cards.c +++ b/drivers/media/dvb/mantis/mantis_cards.c | |||
@@ -145,7 +145,7 @@ static int __devinit mantis_pci_probe(struct pci_dev *pdev, const struct pci_dev | |||
145 | struct mantis_hwconfig *config; | 145 | struct mantis_hwconfig *config; |
146 | int err = 0; | 146 | int err = 0; |
147 | 147 | ||
148 | mantis = kzalloc(sizeof (struct mantis_pci), GFP_KERNEL); | 148 | mantis = kzalloc(sizeof(struct mantis_pci), GFP_KERNEL); |
149 | if (mantis == NULL) { | 149 | if (mantis == NULL) { |
150 | printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); | 150 | printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); |
151 | err = -ENOMEM; | 151 | err = -ENOMEM; |
diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb/mantis/mantis_core.c index 52b3e9ebfcfa..3ddc9ba8440f 100644 --- a/drivers/media/dvb/mantis/mantis_core.c +++ b/drivers/media/dvb/mantis/mantis_core.c | |||
@@ -36,14 +36,16 @@ static int read_eeprom_byte(struct mantis_pci *mantis, u8 *data, u8 length) | |||
36 | .flags = 0, | 36 | .flags = 0, |
37 | .buf = data, | 37 | .buf = data, |
38 | .len = 1 | 38 | .len = 1 |
39 | },{ | 39 | }, { |
40 | .addr = 0x50, | 40 | .addr = 0x50, |
41 | .flags = I2C_M_RD, | 41 | .flags = I2C_M_RD, |
42 | .buf = data, | 42 | .buf = data, |
43 | .len = length | 43 | .len = length |
44 | }, | 44 | }, |
45 | }; | 45 | }; |
46 | if ((err = i2c_transfer(&mantis->adapter, msg, 2)) < 0) { | 46 | |
47 | err = i2c_transfer(&mantis->adapter, msg, 2); | ||
48 | if (err < 0) { | ||
47 | dprintk(verbose, MANTIS_ERROR, 1, | 49 | dprintk(verbose, MANTIS_ERROR, 1, |
48 | "ERROR: i2c read: < err=%i d0=0x%02x d1=0x%02x >", | 50 | "ERROR: i2c read: < err=%i d0=0x%02x d1=0x%02x >", |
49 | err, data[0], data[1]); | 51 | err, data[0], data[1]); |
@@ -65,7 +67,8 @@ static int write_eeprom_byte(struct mantis_pci *mantis, u8 *data, u8 length) | |||
65 | .len = length | 67 | .len = length |
66 | }; | 68 | }; |
67 | 69 | ||
68 | if ((err = i2c_transfer(&mantis->adapter, &msg, 1)) < 0) { | 70 | err = i2c_transfer(&mantis->adapter, &msg, 1); |
71 | if (err < 0) { | ||
69 | dprintk(verbose, MANTIS_ERROR, 1, | 72 | dprintk(verbose, MANTIS_ERROR, 1, |
70 | "ERROR: i2c write: < err=%i length=0x%02x d0=0x%02x, d1=0x%02x >", | 73 | "ERROR: i2c write: < err=%i length=0x%02x d0=0x%02x, d1=0x%02x >", |
71 | err, length, data[0], data[1]); | 74 | err, length, data[0], data[1]); |
@@ -81,7 +84,8 @@ static int get_mac_address(struct mantis_pci *mantis) | |||
81 | int err; | 84 | int err; |
82 | 85 | ||
83 | mantis->mac_address[0] = 0x08; | 86 | mantis->mac_address[0] = 0x08; |
84 | if ((err = read_eeprom_byte(mantis, &mantis->mac_address[0], 6)) < 0) { | 87 | err = read_eeprom_byte(mantis, &mantis->mac_address[0], 6); |
88 | if (err < 0) { | ||
85 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis EEPROM read error"); | 89 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis EEPROM read error"); |
86 | 90 | ||
87 | return err; | 91 | return err; |
@@ -106,25 +110,25 @@ struct mantis_hwconfig unknown_device = { | |||
106 | static void mantis_load_config(struct mantis_pci *mantis) | 110 | static void mantis_load_config(struct mantis_pci *mantis) |
107 | { | 111 | { |
108 | switch (mantis->subsystem_device) { | 112 | switch (mantis->subsystem_device) { |
109 | case MANTIS_VP_1033_DVB_S: // VP-1033 | 113 | case MANTIS_VP_1033_DVB_S: /* VP-1033 */ |
110 | mantis->hwconfig = &vp1033_mantis_config; | 114 | mantis->hwconfig = &vp1033_mantis_config; |
111 | break; | 115 | break; |
112 | case MANTIS_VP_1034_DVB_S: // VP-1034 | 116 | case MANTIS_VP_1034_DVB_S: /* VP-1034 */ |
113 | mantis->hwconfig = &vp1034_mantis_config; | 117 | mantis->hwconfig = &vp1034_mantis_config; |
114 | break; | 118 | break; |
115 | case MANTIS_VP_1041_DVB_S2: // VP-1041 | 119 | case MANTIS_VP_1041_DVB_S2: /* VP-1041 */ |
116 | case TECHNISAT_SKYSTAR_HD2: | 120 | case TECHNISAT_SKYSTAR_HD2: |
117 | mantis->hwconfig = &vp1041_mantis_config; | 121 | mantis->hwconfig = &vp1041_mantis_config; |
118 | break; | 122 | break; |
119 | case MANTIS_VP_2033_DVB_C: // VP-2033 | 123 | case MANTIS_VP_2033_DVB_C: /* VP-2033 */ |
120 | mantis->hwconfig = &vp2033_mantis_config; | 124 | mantis->hwconfig = &vp2033_mantis_config; |
121 | break; | 125 | break; |
122 | case MANTIS_VP_2040_DVB_C: // VP-2040 | 126 | case MANTIS_VP_2040_DVB_C: /* VP-2040 */ |
123 | case TERRATEC_CINERGY_C_PCI: // VP-2040 clone | 127 | case TERRATEC_CINERGY_C_PCI: /* VP-2040 clone */ |
124 | case TECHNISAT_CABLESTAR_HD2: | 128 | case TECHNISAT_CABLESTAR_HD2: |
125 | mantis->hwconfig = &vp2040_mantis_config; | 129 | mantis->hwconfig = &vp2040_mantis_config; |
126 | break; | 130 | break; |
127 | case MANTIS_VP_3030_DVB_T: // VP-3030 | 131 | case MANTIS_VP_3030_DVB_T: /* VP-3030 */ |
128 | mantis->hwconfig = &vp3030_mantis_config; | 132 | mantis->hwconfig = &vp3030_mantis_config; |
129 | break; | 133 | break; |
130 | default: | 134 | default: |
@@ -149,23 +153,28 @@ int mantis_core_init(struct mantis_pci *mantis) | |||
149 | mantis->pdev->irq, mantis->latency, | 153 | mantis->pdev->irq, mantis->latency, |
150 | mantis->mantis_addr, mantis->mantis_mmio); | 154 | mantis->mantis_addr, mantis->mantis_mmio); |
151 | 155 | ||
152 | if ((err = mantis_i2c_init(mantis)) < 0) { | 156 | err = mantis_i2c_init(mantis); |
157 | if (err < 0) { | ||
153 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis I2C init failed"); | 158 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis I2C init failed"); |
154 | return err; | 159 | return err; |
155 | } | 160 | } |
156 | if ((err = get_mac_address(mantis)) < 0) { | 161 | err = get_mac_address(mantis); |
162 | if (err < 0) { | ||
157 | dprintk(verbose, MANTIS_ERROR, 1, "get MAC address failed"); | 163 | dprintk(verbose, MANTIS_ERROR, 1, "get MAC address failed"); |
158 | return err; | 164 | return err; |
159 | } | 165 | } |
160 | if ((err = mantis_dma_init(mantis)) < 0) { | 166 | err = mantis_dma_init(mantis); |
167 | if (err < 0) { | ||
161 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis DMA init failed"); | 168 | dprintk(verbose, MANTIS_ERROR, 1, "Mantis DMA init failed"); |
162 | return err; | 169 | return err; |
163 | } | 170 | } |
164 | if ((err = mantis_dvb_init(mantis)) < 0) { | 171 | err = mantis_dvb_init(mantis); |
172 | if (err < 0) { | ||
165 | dprintk(verbose, MANTIS_DEBUG, 1, "Mantis DVB init failed"); | 173 | dprintk(verbose, MANTIS_DEBUG, 1, "Mantis DVB init failed"); |
166 | return err; | 174 | return err; |
167 | } | 175 | } |
168 | if ((err = mantis_uart_init(mantis)) < 0) { | 176 | err = mantis_uart_init(mantis); |
177 | if (err < 0) { | ||
169 | dprintk(verbose, MANTIS_DEBUG, 1, "Mantis UART init failed"); | 178 | dprintk(verbose, MANTIS_DEBUG, 1, "Mantis UART init failed"); |
170 | return err; | 179 | return err; |
171 | } | 180 | } |
@@ -191,7 +200,7 @@ int mantis_core_exit(struct mantis_pci *mantis) | |||
191 | return 0; | 200 | return 0; |
192 | } | 201 | } |
193 | 202 | ||
194 | // Turn the given bit on or off. | 203 | /* Turn the given bit on or off. */ |
195 | void gpio_set_bits(struct mantis_pci *mantis, u32 bitpos, u8 value) | 204 | void gpio_set_bits(struct mantis_pci *mantis, u32 bitpos, u8 value) |
196 | { | 205 | { |
197 | u32 cur; | 206 | u32 cur; |
@@ -207,14 +216,15 @@ void gpio_set_bits(struct mantis_pci *mantis, u32 bitpos, u8 value) | |||
207 | udelay(100); | 216 | udelay(100); |
208 | } | 217 | } |
209 | 218 | ||
210 | //direction = 0 , no CI passthrough ; 1 , CI passthrough | 219 | /* direction = 0 , no CI passthrough ; 1 , CI passthrough */ |
211 | void mantis_set_direction(struct mantis_pci *mantis, int direction) | 220 | void mantis_set_direction(struct mantis_pci *mantis, int direction) |
212 | { | 221 | { |
213 | u32 reg; | 222 | u32 reg; |
214 | 223 | ||
215 | reg = mmread(0x28); | 224 | reg = mmread(0x28); |
216 | dprintk(verbose, MANTIS_DEBUG, 1, "TS direction setup"); | 225 | dprintk(verbose, MANTIS_DEBUG, 1, "TS direction setup"); |
217 | if (direction == 0x01) { //to CI | 226 | if (direction == 0x01) { |
227 | /* to CI */ | ||
218 | reg |= 0x04; | 228 | reg |= 0x04; |
219 | mmwrite(reg, 0x28); | 229 | mmwrite(reg, 0x28); |
220 | reg &= 0xff - 0x04; | 230 | reg &= 0xff - 0x04; |
diff --git a/drivers/media/dvb/mantis/mantis_core.h b/drivers/media/dvb/mantis/mantis_core.h index a80939409935..8511b0cebac1 100644 --- a/drivers/media/dvb/mantis/mantis_core.h +++ b/drivers/media/dvb/mantis/mantis_core.h | |||
@@ -33,15 +33,15 @@ | |||
33 | 33 | ||
34 | 34 | ||
35 | struct vendorname { | 35 | struct vendorname { |
36 | __u8 *sub_vendor_name; | 36 | u8 *sub_vendor_name; |
37 | __u32 sub_vendor_id; | 37 | u32 sub_vendor_id; |
38 | }; | 38 | }; |
39 | 39 | ||
40 | struct devicetype { | 40 | struct devicetype { |
41 | __u8 *sub_device_name; | 41 | u8 *sub_device_name; |
42 | __u32 sub_device_id; | 42 | u32 sub_device_id; |
43 | __u8 device_type; | 43 | u8 device_type; |
44 | __u32 type_flags; | 44 | u32 type_flags; |
45 | }; | 45 | }; |
46 | 46 | ||
47 | 47 | ||
@@ -54,4 +54,4 @@ extern int mantis_i2c_exit(struct mantis_pci *mantis); | |||
54 | extern int mantis_core_init(struct mantis_pci *mantis); | 54 | extern int mantis_core_init(struct mantis_pci *mantis); |
55 | extern int mantis_core_exit(struct mantis_pci *mantis); | 55 | extern int mantis_core_exit(struct mantis_pci *mantis); |
56 | 56 | ||
57 | #endif //__MANTIS_CORE_H | 57 | #endif /* __MANTIS_CORE_H */ |
diff --git a/drivers/media/dvb/mantis/mantis_dma.c b/drivers/media/dvb/mantis/mantis_dma.c index eab3645f7acb..adad1f37efde 100644 --- a/drivers/media/dvb/mantis/mantis_dma.c +++ b/drivers/media/dvb/mantis/mantis_dma.c | |||
@@ -43,10 +43,10 @@ | |||
43 | #define RISC_IRQ (0x01 << 24) | 43 | #define RISC_IRQ (0x01 << 24) |
44 | 44 | ||
45 | #define RISC_STATUS(status) ((((~status) & 0x0f) << 20) | ((status & 0x0f) << 16)) | 45 | #define RISC_STATUS(status) ((((~status) & 0x0f) << 20) | ((status & 0x0f) << 16)) |
46 | #define RISC_FLUSH() mantis->risc_pos = 0 | 46 | #define RISC_FLUSH() (mantis->risc_pos = 0) |
47 | #define RISC_INSTR(opcode) mantis->risc_cpu[mantis->risc_pos++] = cpu_to_le32(opcode) | 47 | #define RISC_INSTR(opcode) (mantis->risc_cpu[mantis->risc_pos++] = cpu_to_le32(opcode)) |
48 | 48 | ||
49 | #define MANTIS_BUF_SIZE 64 * 1024 | 49 | #define MANTIS_BUF_SIZE (64 * 1024) |
50 | #define MANTIS_BLOCK_BYTES (MANTIS_BUF_SIZE >> 4) | 50 | #define MANTIS_BLOCK_BYTES (MANTIS_BUF_SIZE >> 4) |
51 | #define MANTIS_BLOCK_COUNT (1 << 4) | 51 | #define MANTIS_BLOCK_COUNT (1 << 4) |
52 | #define MANTIS_RISC_SIZE PAGE_SIZE | 52 | #define MANTIS_RISC_SIZE PAGE_SIZE |
@@ -158,7 +158,8 @@ int mantis_dma_init(struct mantis_pci *mantis) | |||
158 | 158 | ||
159 | goto err; | 159 | goto err; |
160 | } | 160 | } |
161 | if ((err = mantis_calc_lines(mantis)) < 0) { | 161 | err = mantis_calc_lines(mantis); |
162 | if (err < 0) { | ||
162 | dprintk(MANTIS_ERROR, 1, "Mantis calc lines failed"); | 163 | dprintk(MANTIS_ERROR, 1, "Mantis calc lines failed"); |
163 | 164 | ||
164 | goto err; | 165 | goto err; |
@@ -248,7 +249,7 @@ void mantis_dma_xfer(unsigned long data) | |||
248 | dprintk(MANTIS_DEBUG, 1, "last block=[%d] finished block=[%d]", | 249 | dprintk(MANTIS_DEBUG, 1, "last block=[%d] finished block=[%d]", |
249 | mantis->last_block, mantis->finished_block); | 250 | mantis->last_block, mantis->finished_block); |
250 | 251 | ||
251 | (config->ts_size ? dvb_dmx_swfilter_204: dvb_dmx_swfilter) | 252 | (config->ts_size ? dvb_dmx_swfilter_204 : dvb_dmx_swfilter) |
252 | (&mantis->demux, &mantis->buf_cpu[mantis->last_block * MANTIS_BLOCK_BYTES], MANTIS_BLOCK_BYTES); | 253 | (&mantis->demux, &mantis->buf_cpu[mantis->last_block * MANTIS_BLOCK_BYTES], MANTIS_BLOCK_BYTES); |
253 | mantis->last_block = (mantis->last_block + 1) % MANTIS_BLOCK_COUNT; | 254 | mantis->last_block = (mantis->last_block + 1) % MANTIS_BLOCK_COUNT; |
254 | } | 255 | } |
diff --git a/drivers/media/dvb/mantis/mantis_dvb.c b/drivers/media/dvb/mantis/mantis_dvb.c index 54bf4ea9efd7..8982d6fdf6be 100644 --- a/drivers/media/dvb/mantis/mantis_dvb.c +++ b/drivers/media/dvb/mantis/mantis_dvb.c | |||
@@ -116,7 +116,6 @@ static int mantis_dvb_start_feed(struct dvb_demux_feed *dvbdmxfeed) | |||
116 | 116 | ||
117 | if (mantis->feeds == 1) { | 117 | if (mantis->feeds == 1) { |
118 | dprintk(MANTIS_DEBUG, 1, "mantis start feed & dma"); | 118 | dprintk(MANTIS_DEBUG, 1, "mantis start feed & dma"); |
119 | printk("mantis start feed & dma\n"); | ||
120 | mantis_dma_start(mantis); | 119 | mantis_dma_start(mantis); |
121 | } | 120 | } |
122 | 121 | ||
@@ -137,7 +136,6 @@ static int mantis_dvb_stop_feed(struct dvb_demux_feed *dvbdmxfeed) | |||
137 | mantis->feeds--; | 136 | mantis->feeds--; |
138 | if (mantis->feeds == 0) { | 137 | if (mantis->feeds == 0) { |
139 | dprintk(MANTIS_DEBUG, 1, "mantis stop feed and dma"); | 138 | dprintk(MANTIS_DEBUG, 1, "mantis stop feed and dma"); |
140 | printk("mantis stop feed and dma\n"); | ||
141 | mantis_dma_stop(mantis); | 139 | mantis_dma_stop(mantis); |
142 | } | 140 | } |
143 | 141 | ||
@@ -204,9 +202,9 @@ int __devinit mantis_dvb_init(struct mantis_pci *mantis) | |||
204 | } | 202 | } |
205 | 203 | ||
206 | mantis->fe_mem.source = DMX_MEMORY_FE; | 204 | mantis->fe_mem.source = DMX_MEMORY_FE; |
207 | result = mantis->demux.dmx.add_frontend(&mantis->demux.dmx,&mantis->fe_mem); | 205 | result = mantis->demux.dmx.add_frontend(&mantis->demux.dmx, &mantis->fe_mem); |
208 | if (result < 0) { | 206 | if (result < 0) { |
209 | dprintk(MANTIS_ERROR, 1,"dvb_dmx_init failed, ERROR=%d", result); | 207 | dprintk(MANTIS_ERROR, 1, "dvb_dmx_init failed, ERROR=%d", result); |
210 | goto err3; | 208 | goto err3; |
211 | } | 209 | } |
212 | 210 | ||
@@ -224,10 +222,6 @@ int __devinit mantis_dvb_init(struct mantis_pci *mantis) | |||
224 | dprintk(MANTIS_ERROR, 1, "!!! NO Frontends found !!!"); | 222 | dprintk(MANTIS_ERROR, 1, "!!! NO Frontends found !!!"); |
225 | goto err5; | 223 | goto err5; |
226 | } else { | 224 | } else { |
227 | // if (mantis->dvb_adapter == NULL) { | ||
228 | // dprintk(MANTIS_ERROR, 1, "DVB adapter <NULL>"); | ||
229 | // goto err5; | ||
230 | // } | ||
231 | if (mantis->fe == NULL) { | 225 | if (mantis->fe == NULL) { |
232 | dprintk(MANTIS_ERROR, 1, "FE <NULL>"); | 226 | dprintk(MANTIS_ERROR, 1, "FE <NULL>"); |
233 | goto err5; | 227 | goto err5; |
@@ -277,7 +271,7 @@ int __devexit mantis_dvb_exit(struct mantis_pci *mantis) | |||
277 | int err; | 271 | int err; |
278 | 272 | ||
279 | if (mantis->fe) { | 273 | if (mantis->fe) { |
280 | // mantis_ca_exit(mantis); | 274 | /* mantis_ca_exit(mantis); */ |
281 | err = mantis_frontend_shutdown(mantis); | 275 | err = mantis_frontend_shutdown(mantis); |
282 | if (err != 0) | 276 | if (err != 0) |
283 | dprintk(MANTIS_ERROR, 1, "Frontend exit while POWER ON! <%d>", err); | 277 | dprintk(MANTIS_ERROR, 1, "Frontend exit while POWER ON! <%d>", err); |
diff --git a/drivers/media/dvb/mantis/mantis_i2c.c b/drivers/media/dvb/mantis/mantis_i2c.c index 7bb4e78aa714..dd38b9333537 100644 --- a/drivers/media/dvb/mantis/mantis_i2c.c +++ b/drivers/media/dvb/mantis/mantis_i2c.c | |||
@@ -225,7 +225,7 @@ int __devinit mantis_i2c_init(struct mantis_pci *mantis) | |||
225 | 225 | ||
226 | init_waitqueue_head(&mantis->i2c_wq); | 226 | init_waitqueue_head(&mantis->i2c_wq); |
227 | mutex_init(&mantis->i2c_lock); | 227 | mutex_init(&mantis->i2c_lock); |
228 | strncpy(i2c_adapter->name, "Mantis I2C", sizeof (i2c_adapter->name)); | 228 | strncpy(i2c_adapter->name, "Mantis I2C", sizeof(i2c_adapter->name)); |
229 | i2c_set_adapdata(i2c_adapter, mantis); | 229 | i2c_set_adapdata(i2c_adapter, mantis); |
230 | 230 | ||
231 | i2c_adapter->owner = THIS_MODULE; | 231 | i2c_adapter->owner = THIS_MODULE; |
diff --git a/drivers/media/dvb/mantis/mantis_input.c b/drivers/media/dvb/mantis/mantis_input.c index b27d7759788b..487d149c802d 100644 --- a/drivers/media/dvb/mantis/mantis_input.c +++ b/drivers/media/dvb/mantis/mantis_input.c | |||
@@ -36,9 +36,9 @@ static struct ir_scancode mantis_ir_table[] = { | |||
36 | { 0x29, KEY_POWER }, | 36 | { 0x29, KEY_POWER }, |
37 | { 0x28, KEY_FAVORITES }, | 37 | { 0x28, KEY_FAVORITES }, |
38 | { 0x30, KEY_TEXT }, | 38 | { 0x30, KEY_TEXT }, |
39 | { 0x17, KEY_INFO }, // Preview | 39 | { 0x17, KEY_INFO }, /* Preview */ |
40 | { 0x23, KEY_EPG }, | 40 | { 0x23, KEY_EPG }, |
41 | { 0x3b, KEY_F22 },// Record List | 41 | { 0x3b, KEY_F22 }, /* Record List */ |
42 | { 0x3c, KEY_1 }, | 42 | { 0x3c, KEY_1 }, |
43 | { 0x3e, KEY_2 }, | 43 | { 0x3e, KEY_2 }, |
44 | { 0x39, KEY_3 }, | 44 | { 0x39, KEY_3 }, |
@@ -71,22 +71,22 @@ static struct ir_scancode mantis_ir_table[] = { | |||
71 | 71 | ||
72 | { 0x1f, KEY_REWIND }, | 72 | { 0x1f, KEY_REWIND }, |
73 | { 0x2d, KEY_FASTFORWARD }, | 73 | { 0x2d, KEY_FASTFORWARD }, |
74 | { 0x1e, KEY_PREVIOUS }, // Replay |< | 74 | { 0x1e, KEY_PREVIOUS }, /* Replay |< */ |
75 | { 0x1d, KEY_NEXT }, // Skip >| | 75 | { 0x1d, KEY_NEXT }, /* Skip >| */ |
76 | 76 | ||
77 | { 0x0b, KEY_CAMERA }, // Capture | 77 | { 0x0b, KEY_CAMERA }, /* Capture */ |
78 | { 0x0f, KEY_LANGUAGE }, // SAP | 78 | { 0x0f, KEY_LANGUAGE }, /* SAP */ |
79 | { 0x18, KEY_MODE }, // PIP | 79 | { 0x18, KEY_MODE }, /* PIP */ |
80 | { 0x12, KEY_ZOOM }, // Full screen, | 80 | { 0x12, KEY_ZOOM }, /* Full screen */ |
81 | { 0x1c, KEY_SUBTITLE }, | 81 | { 0x1c, KEY_SUBTITLE }, |
82 | { 0x2f, KEY_MUTE }, | 82 | { 0x2f, KEY_MUTE }, |
83 | { 0x16, KEY_F20 }, // L/R, | 83 | { 0x16, KEY_F20 }, /* L/R */ |
84 | { 0x38, KEY_F21 }, // Hibernate, | 84 | { 0x38, KEY_F21 }, /* Hibernate */ |
85 | 85 | ||
86 | { 0x37, KEY_SWITCHVIDEOMODE }, // A/V | 86 | { 0x37, KEY_SWITCHVIDEOMODE }, /* A/V */ |
87 | { 0x31, KEY_AGAIN }, // Recall, | 87 | { 0x31, KEY_AGAIN }, /* Recall */ |
88 | { 0x1a, KEY_KPPLUS }, // Zoom+, | 88 | { 0x1a, KEY_KPPLUS }, /* Zoom+ */ |
89 | { 0x19, KEY_KPMINUS }, // Zoom-, | 89 | { 0x19, KEY_KPMINUS }, /* Zoom- */ |
90 | { 0x27, KEY_RED }, | 90 | { 0x27, KEY_RED }, |
91 | { 0x0C, KEY_GREEN }, | 91 | { 0x0C, KEY_GREEN }, |
92 | { 0x01, KEY_YELLOW }, | 92 | { 0x01, KEY_YELLOW }, |
diff --git a/drivers/media/dvb/mantis/mantis_reg.h b/drivers/media/dvb/mantis/mantis_reg.h index 0072e149a561..c2f572b49faf 100644 --- a/drivers/media/dvb/mantis/mantis_reg.h +++ b/drivers/media/dvb/mantis/mantis_reg.h | |||
@@ -29,7 +29,7 @@ | |||
29 | #define MANTIS_INT_RISCEN (0x01 << 27) | 29 | #define MANTIS_INT_RISCEN (0x01 << 27) |
30 | #define MANTIS_INT_I2CRACK (0x01 << 26) | 30 | #define MANTIS_INT_I2CRACK (0x01 << 26) |
31 | 31 | ||
32 | //#define MANTIS_INT_GPIF (0xff << 12) | 32 | /* #define MANTIS_INT_GPIF (0xff << 12) */ |
33 | 33 | ||
34 | #define MANTIS_INT_PCMCIA7 (0x01 << 19) | 34 | #define MANTIS_INT_PCMCIA7 (0x01 << 19) |
35 | #define MANTIS_INT_PCMCIA6 (0x01 << 18) | 35 | #define MANTIS_INT_PCMCIA6 (0x01 << 18) |
diff --git a/drivers/media/dvb/mantis/mantis_vp1033.c b/drivers/media/dvb/mantis/mantis_vp1033.c index c9760b00d0ab..3c62be30bbb6 100644 --- a/drivers/media/dvb/mantis/mantis_vp1033.c +++ b/drivers/media/dvb/mantis/mantis_vp1033.c | |||
@@ -93,7 +93,7 @@ int lgtdqcs001f_tuner_set(struct dvb_frontend *fe, | |||
93 | u32 div; | 93 | u32 div; |
94 | 94 | ||
95 | 95 | ||
96 | struct i2c_msg msg = {.addr = 0x61, .flags = 0, .buf = buf, .len = sizeof (buf) }; | 96 | struct i2c_msg msg = {.addr = 0x61, .flags = 0, .buf = buf, .len = sizeof(buf)}; |
97 | 97 | ||
98 | div = params->frequency / 250; | 98 | div = params->frequency / 250; |
99 | 99 | ||
@@ -140,12 +140,12 @@ int lgtdqcs001f_set_symbol_rate(struct dvb_frontend *fe, | |||
140 | aclk = 0xb4; | 140 | aclk = 0xb4; |
141 | bclk = 0x51; | 141 | bclk = 0x51; |
142 | } | 142 | } |
143 | stv0299_writereg (fe, 0x13, aclk); | 143 | stv0299_writereg(fe, 0x13, aclk); |
144 | stv0299_writereg (fe, 0x14, bclk); | 144 | stv0299_writereg(fe, 0x14, bclk); |
145 | 145 | ||
146 | stv0299_writereg (fe, 0x1f, (ratio >> 16) & 0xff); | 146 | stv0299_writereg(fe, 0x1f, (ratio >> 16) & 0xff); |
147 | stv0299_writereg (fe, 0x20, (ratio >> 8) & 0xff); | 147 | stv0299_writereg(fe, 0x20, (ratio >> 8) & 0xff); |
148 | stv0299_writereg (fe, 0x21, (ratio ) & 0xf0); | 148 | stv0299_writereg(fe, 0x21, ratio & 0xf0); |
149 | 149 | ||
150 | return 0; | 150 | return 0; |
151 | } | 151 | } |
diff --git a/drivers/media/dvb/mantis/mantis_vp1034.c b/drivers/media/dvb/mantis/mantis_vp1034.c index 7ddd149b0fea..36486b53f677 100644 --- a/drivers/media/dvb/mantis/mantis_vp1034.c +++ b/drivers/media/dvb/mantis/mantis_vp1034.c | |||
@@ -62,7 +62,7 @@ int vp1034_set_voltage(struct dvb_frontend *fe, fe_sec_voltage_t voltage) | |||
62 | dprintk(MANTIS_ERROR, 1, "Frontend (dummy) POWERDOWN"); | 62 | dprintk(MANTIS_ERROR, 1, "Frontend (dummy) POWERDOWN"); |
63 | break; | 63 | break; |
64 | default: | 64 | default: |
65 | dprintk(MANTIS_ERROR, 1, "Invalid = (%d)", (u32 ) voltage); | 65 | dprintk(MANTIS_ERROR, 1, "Invalid = (%d)", (u32) voltage); |
66 | return -EINVAL; | 66 | return -EINVAL; |
67 | } | 67 | } |
68 | mmwrite(0x00, MANTIS_GPIF_DOUT); | 68 | mmwrite(0x00, MANTIS_GPIF_DOUT); |
diff --git a/drivers/media/dvb/mantis/mantis_vp1041.c b/drivers/media/dvb/mantis/mantis_vp1041.c index 368fc815a61d..515346dd31d0 100644 --- a/drivers/media/dvb/mantis/mantis_vp1041.c +++ b/drivers/media/dvb/mantis/mantis_vp1041.c | |||
@@ -44,7 +44,7 @@ | |||
44 | 44 | ||
45 | static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { | 45 | static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { |
46 | 46 | ||
47 | // 0x0000000b , /* SYSREG */ | 47 | /* 0x0000000b, *//* SYSREG */ |
48 | { STB0899_DEV_ID , 0x30 }, | 48 | { STB0899_DEV_ID , 0x30 }, |
49 | { STB0899_DISCNTRL1 , 0x32 }, | 49 | { STB0899_DISCNTRL1 , 0x32 }, |
50 | { STB0899_DISCNTRL2 , 0x80 }, | 50 | { STB0899_DISCNTRL2 , 0x80 }, |
@@ -55,7 +55,7 @@ static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { | |||
55 | { STB0899_DISSTATUS , 0x20 }, | 55 | { STB0899_DISSTATUS , 0x20 }, |
56 | { STB0899_DISF22 , 0x99 }, | 56 | { STB0899_DISF22 , 0x99 }, |
57 | { STB0899_DISF22RX , 0xa8 }, | 57 | { STB0899_DISF22RX , 0xa8 }, |
58 | //SYSREG ? | 58 | /* SYSREG ? */ |
59 | { STB0899_ACRPRESC , 0x11 }, | 59 | { STB0899_ACRPRESC , 0x11 }, |
60 | { STB0899_ACRDIV1 , 0x0a }, | 60 | { STB0899_ACRDIV1 , 0x0a }, |
61 | { STB0899_ACRDIV2 , 0x05 }, | 61 | { STB0899_ACRDIV2 , 0x05 }, |
@@ -323,9 +323,8 @@ static int vp1041_frontend_init(struct mantis_pci *mantis, struct dvb_frontend * | |||
323 | vp1041_stb0899_config.demod_address); | 323 | vp1041_stb0899_config.demod_address); |
324 | 324 | ||
325 | if (stb6100_attach(mantis->fe, &vp1041_stb6100_config, adapter)) { | 325 | if (stb6100_attach(mantis->fe, &vp1041_stb6100_config, adapter)) { |
326 | if (!lnbp21_attach(mantis->fe, adapter, 0, 0)) { | 326 | if (!lnbp21_attach(mantis->fe, adapter, 0, 0)) |
327 | printk("%s: No LNBP21 found!\n", __func__); | 327 | dprintk(MANTIS_ERROR, 1, "No LNBP21 found!"); |
328 | } | ||
329 | } | 328 | } |
330 | } else { | 329 | } else { |
331 | return -EREMOTEIO; | 330 | return -EREMOTEIO; |
diff --git a/drivers/media/dvb/mantis/mantis_vp2033.c b/drivers/media/dvb/mantis/mantis_vp2033.c index 45f71749bb98..07d468ff5e13 100644 --- a/drivers/media/dvb/mantis/mantis_vp2033.c +++ b/drivers/media/dvb/mantis/mantis_vp2033.c | |||
@@ -71,7 +71,7 @@ static int tda1002x_cu1216_tuner_set(struct dvb_frontend *fe, struct dvb_fronten | |||
71 | struct i2c_adapter *adapter = &mantis->adapter; | 71 | struct i2c_adapter *adapter = &mantis->adapter; |
72 | 72 | ||
73 | u8 buf[6]; | 73 | u8 buf[6]; |
74 | struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof (buf) }; | 74 | struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof(buf)}; |
75 | int i; | 75 | int i; |
76 | 76 | ||
77 | #define CU1216_IF 36125000 | 77 | #define CU1216_IF 36125000 |
diff --git a/drivers/media/dvb/mantis/mantis_vp2040.c b/drivers/media/dvb/mantis/mantis_vp2040.c index 8471bff672f3..a7ca233e800b 100644 --- a/drivers/media/dvb/mantis/mantis_vp2040.c +++ b/drivers/media/dvb/mantis/mantis_vp2040.c | |||
@@ -53,7 +53,7 @@ static int tda1002x_cu1216_tuner_set(struct dvb_frontend *fe, struct dvb_fronten | |||
53 | struct i2c_adapter *adapter = &mantis->adapter; | 53 | struct i2c_adapter *adapter = &mantis->adapter; |
54 | 54 | ||
55 | u8 buf[6]; | 55 | u8 buf[6]; |
56 | struct i2c_msg msg = {.addr = 0x60,.flags = 0,.buf = buf,.len = sizeof (buf) }; | 56 | struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof(buf)}; |
57 | int i; | 57 | int i; |
58 | 58 | ||
59 | #define CU1216_IF 36125000 | 59 | #define CU1216_IF 36125000 |