diff options
author | Patrick Boettcher <pb@linuxtv.org> | 2006-05-14 04:01:31 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-06-25 01:00:42 -0400 |
commit | dea74869f3c62b0b7addd67017b22b394e942aac (patch) | |
tree | d1a597caea6615c76f34896cc832fd1371f2e776 /drivers/media/dvb/frontends/lnbp21.c | |
parent | 332bed5fc25ab0eb84215ecd89a4acd48219eee0 (diff) |
V4L/DVB (4028): Change dvb_frontend_ops to be a real field instead of a pointer field inside dvb_frontend
The dvb_frontend_ops is a pointer inside dvb_frontend. That's why every demod-driver
is having a field of dvb_frontend_ops in its private-state-struct and
using the reference for filling the pointer-field in dvb_frontend.
- It saves at least two lines of code per demod-driver,
- reduces object size (one less dereference per frontend_ops-access),
- be coherent with dvb_tuner_ops,
- makes it a little bit easier for newbies to understand how it works and
- avoids stupid mistakes because you would have to copy the dvb_frontend_ops
always, before you could assign the static pointer directly, which was
dangerous.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/dvb/frontends/lnbp21.c')
-rw-r--r-- | drivers/media/dvb/frontends/lnbp21.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/media/dvb/frontends/lnbp21.c b/drivers/media/dvb/frontends/lnbp21.c index c9152c1fbc3f..e933edc8dd29 100644 --- a/drivers/media/dvb/frontends/lnbp21.c +++ b/drivers/media/dvb/frontends/lnbp21.c | |||
@@ -97,11 +97,11 @@ static void lnbp21_release(struct dvb_frontend *fe) | |||
97 | lnbp21_set_voltage(fe, SEC_VOLTAGE_OFF); | 97 | lnbp21_set_voltage(fe, SEC_VOLTAGE_OFF); |
98 | 98 | ||
99 | /* free data & call next release routine */ | 99 | /* free data & call next release routine */ |
100 | fe->ops->release = lnbp21->release_chain; | 100 | fe->ops.release = lnbp21->release_chain; |
101 | kfree(fe->misc_priv); | 101 | kfree(fe->misc_priv); |
102 | fe->misc_priv = NULL; | 102 | fe->misc_priv = NULL; |
103 | if (fe->ops->release) | 103 | if (fe->ops.release) |
104 | fe->ops->release(fe); | 104 | fe->ops.release(fe); |
105 | } | 105 | } |
106 | 106 | ||
107 | int lnbp21_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 override_set, u8 override_clear) | 107 | int lnbp21_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 override_set, u8 override_clear) |
@@ -129,12 +129,12 @@ int lnbp21_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 override_ | |||
129 | } | 129 | } |
130 | 130 | ||
131 | /* install release callback */ | 131 | /* install release callback */ |
132 | lnbp21->release_chain = fe->ops->release; | 132 | lnbp21->release_chain = fe->ops.release; |
133 | fe->ops->release = lnbp21_release; | 133 | fe->ops.release = lnbp21_release; |
134 | 134 | ||
135 | /* override frontend ops */ | 135 | /* override frontend ops */ |
136 | fe->ops->set_voltage = lnbp21_set_voltage; | 136 | fe->ops.set_voltage = lnbp21_set_voltage; |
137 | fe->ops->enable_high_lnb_voltage = lnbp21_enable_high_lnb_voltage; | 137 | fe->ops.enable_high_lnb_voltage = lnbp21_enable_high_lnb_voltage; |
138 | 138 | ||
139 | return 0; | 139 | return 0; |
140 | } | 140 | } |