V4L/DVB (7469): Preparation for supporting new devices, cleanup and saneness

To prepare the support for new device to the flexcop-family some preparation and cleanups was done + some saneness:

- created an i2c-adapter for each i2c-port available. Easier usage for devices with several device on different i2c-busses
- initialize i2c before doing the eeprom read
- changed the way to attach the different frontends, easier to read now
- enabled support for i2c-devices having no register address (1-byte access)

Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

1 files changed, 64 insertions, 47 deletions

diff --git a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
index 441ffdf0d9c9..46d6f5d8cd1c 100644
--- a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
+++ b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
@@ -183,13 +183,13 @@ static int samsung_tbmu24112_tuner_set_params(struct dvb_frontend* fe, struct dv
         buf[2] = 0x84;  /* 0xC4 */
         buf[3] = 0x08;
 
-        if (params->frequency < 1500000) buf[3] |= 0x10;
+        if (params->frequency < 1500000)
+                buf[3] |= 0x10;
 
         if (fe->ops.i2c_gate_ctrl)
                 fe->ops.i2c_gate_ctrl(fe, 1);
-        if (i2c_transfer(&fc->i2c_adap, &msg, 1) != 1) {
+        if (i2c_transfer(&fc->fc_i2c_adap[0].i2c_adap, &msg, 1) != 1)
                 return -EIO;
-        }
         return 0;
 }
 
@@ -340,7 +340,7 @@ static int skystar23_samsung_tbdu18132_tuner_set_params(struct dvb_frontend* fe,
 
         if (fe->ops.i2c_gate_ctrl)
                 fe->ops.i2c_gate_ctrl(fe, 1);
-        if (i2c_transfer(&fc->i2c_adap, &msg, 1) != 1)
+        if (i2c_transfer(&fc->fc_i2c_adap[0].i2c_adap, &msg, 1) != 1)
                 return -EIO;
         return 0;
 }
@@ -389,10 +389,11 @@ static int alps_tdee4_stv0297_tuner_set_params(struct dvb_frontend* fe,
         if (fe->ops.i2c_gate_ctrl)
                 fe->ops.i2c_gate_ctrl(fe, 0);
         deb_tuner("tuner buffer for %d Hz: %x %x %x %x\n",fep->frequency, buf[0],buf[1],buf[2],buf[3]);
-        ret = fc->i2c_request(fc, FC_WRITE, FC_I2C_PORT_TUNER, 0x61, buf[0], &buf[1], 3);
+        ret = fc->i2c_request(&fc->fc_i2c_adap[2],
+                FC_WRITE, 0x61, buf[0], &buf[1], 3);
         deb_tuner("tuner write returned: %d\n",ret);
 
-        return 0;
+        return ret;
 }
 
 static u8 alps_tdee4_stv0297_inittab[] = {
@@ -479,53 +480,67 @@ static struct stv0297_config alps_tdee4_stv0297_config = {
 int flexcop_frontend_init(struct flexcop_device *fc)
 {
         struct dvb_frontend_ops *ops;
+        struct i2c_adapter *i2c = &fc->fc_i2c_adap[0].i2c_adap;
 
         /* try the sky v2.6 (stv0299/Samsung tbmu24112(sl1935)) */
-        if ((fc->fe = dvb_attach(stv0299_attach, &samsung_tbmu24112_config, &fc->i2c_adap)) != NULL) {
+        fc->fe = dvb_attach(stv0299_attach, &samsung_tbmu24112_config, i2c);
+        if (fc->fe != NULL) {
                 ops = &fc->fe->ops;
 
                 ops->tuner_ops.set_params = samsung_tbmu24112_tuner_set_params;
 
                 ops->set_voltage = flexcop_set_voltage;
 
-                fc->fe_sleep             = ops->sleep;
-                ops->sleep               = flexcop_sleep;
+                fc->fe_sleep = ops->sleep;
+                ops->sleep = flexcop_sleep;
+
+                fc->dev_type = FC_SKY;
+                goto fe_found;
+        }
 
-                fc->dev_type          = FC_SKY;
-                info("found the stv0299 at i2c address: 0x%02x",samsung_tbmu24112_config.demod_address);
-        } else
         /* try the air dvb-t (mt352/Samsung tdtc9251dh0(??)) */
-        if ((fc->fe = dvb_attach(mt352_attach, &samsung_tdtc9251dh0_config, &fc->i2c_adap)) != NULL ) {
-                fc->dev_type          = FC_AIR_DVB;
+        fc->fe = dvb_attach(mt352_attach, &samsung_tdtc9251dh0_config, i2c);
+        if (fc->fe != NULL) {
+                fc->dev_type = FC_AIR_DVB;
                 fc->fe->ops.tuner_ops.calc_regs = samsung_tdtc9251dh0_calc_regs;
-                info("found the mt352 at i2c address: 0x%02x",samsung_tdtc9251dh0_config.demod_address);
-        } else
+                goto fe_found;
+        }
+
         /* try the air atsc 2nd generation (nxt2002) */
-        if ((fc->fe = dvb_attach(nxt200x_attach, &samsung_tbmv_config, &fc->i2c_adap)) != NULL) {
-                fc->dev_type          = FC_AIR_ATSC2;
+        fc->fe = dvb_attach(nxt200x_attach, &samsung_tbmv_config, i2c);
+        if (fc->fe != NULL) {
+                fc->dev_type = FC_AIR_ATSC2;
                 dvb_attach(dvb_pll_attach, fc->fe, 0x61, NULL, DVB_PLL_SAMSUNG_TBMV);
-                info("found the nxt2002 at i2c address: 0x%02x",samsung_tbmv_config.demod_address);
-        } else
-        /* try the air atsc 3nd generation (lgdt3303) */
-        if ((fc->fe = dvb_attach(lgdt330x_attach, &air2pc_atsc_hd5000_config, &fc->i2c_adap)) != NULL) {
-                fc->dev_type          = FC_AIR_ATSC3;
-                dvb_attach(simple_tuner_attach, fc->fe,
-                           &fc->i2c_adap, 0x61, TUNER_LG_TDVS_H06XF);
-                info("found the lgdt3303 at i2c address: 0x%02x",air2pc_atsc_hd5000_config.demod_address);
-        } else
+                goto fe_found;
+        }
+
+        fc->fe = dvb_attach(lgdt330x_attach, &air2pc_atsc_hd5000_config, i2c);
+        if (fc->fe != NULL) {
+                fc->dev_type = FC_AIR_ATSC3;
+                dvb_attach(simple_tuner_attach, fc->fe, i2c, 0x61,
+                                TUNER_LG_TDVS_H06XF);
+                goto fe_found;
+        }
+
         /* try the air atsc 1nd generation (bcm3510)/panasonic ct10s */
-        if ((fc->fe = dvb_attach(bcm3510_attach, &air2pc_atsc_first_gen_config, &fc->i2c_adap)) != NULL) {
-                fc->dev_type          = FC_AIR_ATSC1;
-                info("found the bcm3510 at i2c address: 0x%02x",air2pc_atsc_first_gen_config.demod_address);
-        } else
+        fc->fe = dvb_attach(bcm3510_attach, &air2pc_atsc_first_gen_config, i2c);
+        if (fc->fe != NULL) {
+                fc->dev_type = FC_AIR_ATSC1;
+                goto fe_found;
+        }
+
         /* try the cable dvb (stv0297) */
-        if ((fc->fe = dvb_attach(stv0297_attach, &alps_tdee4_stv0297_config, &fc->i2c_adap)) != NULL) {
-                fc->dev_type                        = FC_CABLE;
+        fc->fe = dvb_attach(stv0297_attach, &alps_tdee4_stv0297_config, i2c);
+        if (fc->fe != NULL) {
+                fc->dev_type = FC_CABLE;
                 fc->fe->ops.tuner_ops.set_params = alps_tdee4_stv0297_tuner_set_params;
-                info("found the stv0297 at i2c address: 0x%02x",alps_tdee4_stv0297_config.demod_address);
-        } else
+                goto fe_found;
+        }
+
         /* try the sky v2.3 (vp310/Samsung tbdu18132(tsa5059)) */
-        if ((fc->fe = dvb_attach(vp310_mt312_attach, &skystar23_samsung_tbdu18132_config, &fc->i2c_adap)) != NULL) {
+        fc->fe = dvb_attach(vp310_mt312_attach,
+                &skystar23_samsung_tbdu18132_config, i2c);
+        if (fc->fe != NULL) {
                 ops = &fc->fe->ops;
 
                 ops->tuner_ops.set_params = skystar23_samsung_tbdu18132_tuner_set_params;
@@ -539,19 +554,21 @@ int flexcop_frontend_init(struct flexcop_device *fc)
                 ops->sleep                  = flexcop_sleep;
 
                 fc->dev_type                = FC_SKY_OLD;
-                info("found the vp310 (aka mt312) at i2c address: 0x%02x",skystar23_samsung_tbdu18132_config.demod_address);
+                goto fe_found;
         }
 
-        if (fc->fe == NULL) {
-                err("no frontend driver found for this B2C2/FlexCop adapter");
-                return -ENODEV;
-        } else {
-                if (dvb_register_frontend(&fc->dvb_adapter, fc->fe)) {
-                        err("frontend registration failed!");
-                        dvb_frontend_detach(fc->fe);
-                        fc->fe = NULL;
-                        return -EINVAL;
-                }
+        err("no frontend driver found for this B2C2/FlexCop adapter");
+        return -ENODEV;
+
+fe_found:
+        info("found '%s' .", fc->fe->ops.info.name);
+        if (dvb_register_frontend(&fc->dvb_adapter, fc->fe)) {
+                err("frontend registration failed!");
+                ops = &fc->fe->ops;
+                if (ops->release != NULL)
+                        ops->release(fc->fe);
+                fc->fe = NULL;
+                return -EINVAL;
         }
         fc->init_state |= FC_STATE_FE_INIT;
         return 0;