diff options
author | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-03-09 09:10:19 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-03-11 06:37:15 -0400 |
commit | 1d001c3fde34992bd3607ad57221655cbfc74068 (patch) | |
tree | ca18543510a89e6db34347fcb81ccef29d85c49c /drivers/media/dvb-frontends | |
parent | d1f2aae3d91ba107b68540aad7fbf188b734b566 (diff) |
[media] drx-j: don't use mc_info before checking if its not NULL
smatch warning:
drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code() warn: variable dereferenced before check 'mc_info' (see line 20800)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/dvb-frontends')
-rw-r--r-- | drivers/media/dvb-frontends/drx39xyj/drxj.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-frontends/drx39xyj/drxj.c index 1e6dab7e5892..a8fd53b612ae 100644 --- a/drivers/media/dvb-frontends/drx39xyj/drxj.c +++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c | |||
@@ -20208,12 +20208,14 @@ static int drx_ctrl_u_code(struct drx_demod_instance *demod, | |||
20208 | const u8 *mc_data_init = NULL; | 20208 | const u8 *mc_data_init = NULL; |
20209 | u8 *mc_data = NULL; | 20209 | u8 *mc_data = NULL; |
20210 | unsigned size; | 20210 | unsigned size; |
20211 | char *mc_file = mc_info->mc_file; | 20211 | char *mc_file; |
20212 | 20212 | ||
20213 | /* Check arguments */ | 20213 | /* Check arguments */ |
20214 | if (!mc_info || !mc_file) | 20214 | if (!mc_info || !mc_info->mc_file) |
20215 | return -EINVAL; | 20215 | return -EINVAL; |
20216 | 20216 | ||
20217 | mc_file = mc_info->mc_file; | ||
20218 | |||
20217 | if (!demod->firmware) { | 20219 | if (!demod->firmware) { |
20218 | const struct firmware *fw = NULL; | 20220 | const struct firmware *fw = NULL; |
20219 | 20221 | ||