aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/common
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-08-08 17:24:21 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-08 18:57:28 -0400
commit6850aeabdd1fde7cd35f26d4e8779bec943e1cd9 (patch)
tree8bf82328936e4762df92a48129bc0bc65c580d60 /drivers/media/common
parent59e2623b433552d7402dfacd2bc2d7a22a360a4f (diff)
media: use pci_zalloc_consistent
Remove the now unnecessary memset too. Signed-off-by: Joe Perches <joe@perches.com> Cc: Hans Verkuil <hverkuil@xs4all.nl> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/media/common')
-rw-r--r--drivers/media/common/saa7146/saa7146_core.c15
-rw-r--r--drivers/media/common/saa7146/saa7146_fops.c5
2 files changed, 9 insertions, 11 deletions
diff --git a/drivers/media/common/saa7146/saa7146_core.c b/drivers/media/common/saa7146/saa7146_core.c
index 34b0d0ddeef3..97afee672d07 100644
--- a/drivers/media/common/saa7146/saa7146_core.c
+++ b/drivers/media/common/saa7146/saa7146_core.c
@@ -421,23 +421,20 @@ static int saa7146_init_one(struct pci_dev *pci, const struct pci_device_id *ent
421 err = -ENOMEM; 421 err = -ENOMEM;
422 422
423 /* get memory for various stuff */ 423 /* get memory for various stuff */
424 dev->d_rps0.cpu_addr = pci_alloc_consistent(pci, SAA7146_RPS_MEM, 424 dev->d_rps0.cpu_addr = pci_zalloc_consistent(pci, SAA7146_RPS_MEM,
425 &dev->d_rps0.dma_handle); 425 &dev->d_rps0.dma_handle);
426 if (!dev->d_rps0.cpu_addr) 426 if (!dev->d_rps0.cpu_addr)
427 goto err_free_irq; 427 goto err_free_irq;
428 memset(dev->d_rps0.cpu_addr, 0x0, SAA7146_RPS_MEM);
429 428
430 dev->d_rps1.cpu_addr = pci_alloc_consistent(pci, SAA7146_RPS_MEM, 429 dev->d_rps1.cpu_addr = pci_zalloc_consistent(pci, SAA7146_RPS_MEM,
431 &dev->d_rps1.dma_handle); 430 &dev->d_rps1.dma_handle);
432 if (!dev->d_rps1.cpu_addr) 431 if (!dev->d_rps1.cpu_addr)
433 goto err_free_rps0; 432 goto err_free_rps0;
434 memset(dev->d_rps1.cpu_addr, 0x0, SAA7146_RPS_MEM);
435 433
436 dev->d_i2c.cpu_addr = pci_alloc_consistent(pci, SAA7146_RPS_MEM, 434 dev->d_i2c.cpu_addr = pci_zalloc_consistent(pci, SAA7146_RPS_MEM,
437 &dev->d_i2c.dma_handle); 435 &dev->d_i2c.dma_handle);
438 if (!dev->d_i2c.cpu_addr) 436 if (!dev->d_i2c.cpu_addr)
439 goto err_free_rps1; 437 goto err_free_rps1;
440 memset(dev->d_i2c.cpu_addr, 0x0, SAA7146_RPS_MEM);
441 438
442 /* the rest + print status message */ 439 /* the rest + print status message */
443 440
diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c
index d9e1d6395ed9..6c47f3fe9b0f 100644
--- a/drivers/media/common/saa7146/saa7146_fops.c
+++ b/drivers/media/common/saa7146/saa7146_fops.c
@@ -520,14 +520,15 @@ int saa7146_vv_init(struct saa7146_dev* dev, struct saa7146_ext_vv *ext_vv)
520 configuration data) */ 520 configuration data) */
521 dev->ext_vv_data = ext_vv; 521 dev->ext_vv_data = ext_vv;
522 522
523 vv->d_clipping.cpu_addr = pci_alloc_consistent(dev->pci, SAA7146_CLIPPING_MEM, &vv->d_clipping.dma_handle); 523 vv->d_clipping.cpu_addr =
524 pci_zalloc_consistent(dev->pci, SAA7146_CLIPPING_MEM,
525 &vv->d_clipping.dma_handle);
524 if( NULL == vv->d_clipping.cpu_addr ) { 526 if( NULL == vv->d_clipping.cpu_addr ) {
525 ERR("out of memory. aborting.\n"); 527 ERR("out of memory. aborting.\n");
526 kfree(vv); 528 kfree(vv);
527 v4l2_ctrl_handler_free(hdl); 529 v4l2_ctrl_handler_free(hdl);
528 return -1; 530 return -1;
529 } 531 }
530 memset(vv->d_clipping.cpu_addr, 0x0, SAA7146_CLIPPING_MEM);
531 532
532 saa7146_video_uops.init(dev,vv); 533 saa7146_video_uops.init(dev,vv);
533 if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE) 534 if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)