diff options
author | Michael Krufky <mkrufky@linuxtv.org> | 2008-09-06 13:56:58 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-10-12 07:37:01 -0400 |
commit | 30650961907368b1077cade35455fe931b14da6b (patch) | |
tree | a27bbcb9319529b6d13da933adff4c069a12b853 /drivers/media/common/tuners/xc5000.h | |
parent | 2a6003c20771ca16fc6386b5fd258df2f2fa8232 (diff) |
V4L/DVB (8951): xc5000: dont pass devptr in xc5000_attach()
Dont pass devptr in xc5000_attach, dont store it in xc5000_priv.
This pointer is passed into the tuner_callback function, which always
expects a pointer to fe->dvb->priv or i2c_adapter->algo_data.
This prevents future possible bugs in new drivers, such as using a "devptr"
other that the standard fe->dvb->priv in a DVB driver.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/common/tuners/xc5000.h')
-rw-r--r-- | drivers/media/common/tuners/xc5000.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/common/tuners/xc5000.h b/drivers/media/common/tuners/xc5000.h index 5389f740945a..fa0321cfd179 100644 --- a/drivers/media/common/tuners/xc5000.h +++ b/drivers/media/common/tuners/xc5000.h | |||
@@ -49,13 +49,11 @@ struct xc5000_config { | |||
49 | (defined(CONFIG_MEDIA_TUNER_XC5000_MODULE) && defined(MODULE)) | 49 | (defined(CONFIG_MEDIA_TUNER_XC5000_MODULE) && defined(MODULE)) |
50 | extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, | 50 | extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, |
51 | struct i2c_adapter *i2c, | 51 | struct i2c_adapter *i2c, |
52 | struct xc5000_config *cfg, | 52 | struct xc5000_config *cfg); |
53 | void *devptr); | ||
54 | #else | 53 | #else |
55 | static inline struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, | 54 | static inline struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe, |
56 | struct i2c_adapter *i2c, | 55 | struct i2c_adapter *i2c, |
57 | struct xc5000_config *cfg, | 56 | struct xc5000_config *cfg) |
58 | void *devptr) | ||
59 | { | 57 | { |
60 | printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); | 58 | printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); |
61 | return NULL; | 59 | return NULL; |