diff options
author | Markus Stockhausen <stockhausen@collogia.de> | 2014-08-23 06:19:27 -0400 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2014-10-13 22:08:28 -0400 |
commit | b8e6a15a1af9b1c203002e7768e60136c4e0e5c6 (patch) | |
tree | 551414765bf408c6e4c1e26e82597724973eda9f /drivers/md | |
parent | c4796e215f487de9bc93731a81e885ac866ef7dc (diff) |
md/raid5: fix init_stripe() inconsistencies
raid5: fix init_stripe() inconsistencies
1) remove_hash() is not necessary. We will only be called right after
get_free_stripe(). There we have already a call to remove_hash().
2) Tracing prints out the sector of the freed stripe and not the sector
that we want to initialize.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r-- | drivers/md/raid5.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index b177cc4c111e..741134d429a4 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
@@ -531,9 +531,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous) | |||
531 | BUG_ON(stripe_operations_active(sh)); | 531 | BUG_ON(stripe_operations_active(sh)); |
532 | 532 | ||
533 | pr_debug("init_stripe called, stripe %llu\n", | 533 | pr_debug("init_stripe called, stripe %llu\n", |
534 | (unsigned long long)sh->sector); | 534 | (unsigned long long)sector); |
535 | |||
536 | remove_hash(sh); | ||
537 | retry: | 535 | retry: |
538 | seq = read_seqcount_begin(&conf->gen_lock); | 536 | seq = read_seqcount_begin(&conf->gen_lock); |
539 | sh->generation = conf->generation - previous; | 537 | sh->generation = conf->generation - previous; |