aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorJonathan Brassow <jbrassow@redhat.com>2007-05-09 05:33:08 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-09 15:30:48 -0400
commitba8b45cea5f632540d561d37d94c71c07f6af1aa (patch)
tree03604401cd4162a16d1888b71e7d65c8cc14ec31 /drivers/md
parentb997b82d266c9fb910fc2ad95b9bb93b3bccf9be (diff)
dm log: fix resume failed log device
This patch removes the possibility of having uninitialized log state if the log device has failed. When a mirror resumes operation, it calls 'resume' on the logging module. If disk based logging is being used, the log device is read to fill in the log state. If the log device has failed, we cannot simply return, because this would leave the in-memory log state uninitialized. Instead, we assume all regions are out-of-sync and reset the log state. Failure to do this could result in the logging code reporting a region as in-sync, even though it isn't; which could result in a corrupted mirror. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/dm-log.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index a60acf8d385a..a66428d860fe 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -478,7 +478,14 @@ static int disk_resume(struct dirty_log *log)
478 DMWARN("%s: Failed to read header on mirror log device", 478 DMWARN("%s: Failed to read header on mirror log device",
479 lc->log_dev->name); 479 lc->log_dev->name);
480 fail_log_device(lc); 480 fail_log_device(lc);
481 return r; 481 /*
482 * If the log device cannot be read, we must assume
483 * all regions are out-of-sync. If we simply return
484 * here, the state will be uninitialized and could
485 * lead us to return 'in-sync' status for regions
486 * that are actually 'out-of-sync'.
487 */
488 lc->header.nr_regions = 0;
482 } 489 }
483 490
484 /* set or clear any new bits -- device has grown */ 491 /* set or clear any new bits -- device has grown */