aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorJonathan Brassow <jbrassow@redhat.com>2011-01-13 17:14:33 -0500
committerNeilBrown <neilb@suse.de>2011-01-13 17:14:33 -0500
commit43c73ca43b3e03bb228ff9350b6b44d0e560f262 (patch)
tree2a6fcff1e62c53ba0a95295cf02ae785b1efb501 /drivers/md
parent0ca69886a8273ac1350143d562280bfcbe4760dc (diff)
md/raid5: use sysfs_notify_dirent_safe to avoid NULL pointer
With the module parameter 'start_dirty_degraded' set, raid5_spare_active() previously called sysfs_notify_dirent() with a NULL argument (rdev->sysfs_state) when a rebuild finished. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/raid5.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 316fbe79389a..9212c077095c 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5338,7 +5338,7 @@ static int raid5_spare_active(mddev_t *mddev)
5338 && !test_bit(Faulty, &tmp->rdev->flags) 5338 && !test_bit(Faulty, &tmp->rdev->flags)
5339 && !test_and_set_bit(In_sync, &tmp->rdev->flags)) { 5339 && !test_and_set_bit(In_sync, &tmp->rdev->flags)) {
5340 count++; 5340 count++;
5341 sysfs_notify_dirent(tmp->rdev->sysfs_state); 5341 sysfs_notify_dirent_safe(tmp->rdev->sysfs_state);
5342 } 5342 }
5343 } 5343 }
5344 spin_lock_irqsave(&conf->device_lock, flags); 5344 spin_lock_irqsave(&conf->device_lock, flags);