aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2011-07-27 21:39:24 -0400
committerNeilBrown <neilb@suse.de>2011-07-27 21:39:24 -0400
commit8dbed5cebdf6796bf2618457b3653cf820934366 (patch)
treeb8e8421a3aae1ee8f21df97f76b116fd0a0a9b1c /drivers/md
parent7399c31bc92a26bb8388a73f8e14acadcc512fe5 (diff)
md/raid10 - avoid reading from known bad blocks - part 3
When attempting to repair a read error, don't read from devices with a known bad block. As we are only reading PAGE_SIZE blocks, we don't try to narrow down to smaller regions in the hope that only part of this page is bad - it isn't worth the effort. Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/raid10.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 37801d68a4cd..a5ecea2672b5 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1594,10 +1594,15 @@ static void fix_read_error(conf_t *conf, mddev_t *mddev, r10bio_t *r10_bio)
1594 1594
1595 rcu_read_lock(); 1595 rcu_read_lock();
1596 do { 1596 do {
1597 sector_t first_bad;
1598 int bad_sectors;
1599
1597 d = r10_bio->devs[sl].devnum; 1600 d = r10_bio->devs[sl].devnum;
1598 rdev = rcu_dereference(conf->mirrors[d].rdev); 1601 rdev = rcu_dereference(conf->mirrors[d].rdev);
1599 if (rdev && 1602 if (rdev &&
1600 test_bit(In_sync, &rdev->flags)) { 1603 test_bit(In_sync, &rdev->flags) &&
1604 is_badblock(rdev, r10_bio->devs[sl].addr + sect, s,
1605 &first_bad, &bad_sectors) == 0) {
1601 atomic_inc(&rdev->nr_pending); 1606 atomic_inc(&rdev->nr_pending);
1602 rcu_read_unlock(); 1607 rcu_read_unlock();
1603 success = sync_page_io(rdev, 1608 success = sync_page_io(rdev,