diff options
author | NeilBrown <neilb@suse.de> | 2005-11-28 16:44:10 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-28 17:42:25 -0500 |
commit | 700e432d8364ce59c521abbe03a522051610ebc2 (patch) | |
tree | 50293a973edfc2cc39858367d50497416473fb5b /drivers/md/raid5.c | |
parent | 22dfdf5212e5864b844f629736fb993d4611f190 (diff) |
[PATCH] md: fix locking problem in r5/r6
bitmap_unplug actually writes data (bits) to storage, so we shouldn't be
holding a spinlock...
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/raid5.c')
-rw-r--r-- | drivers/md/raid5.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index e2a40283e323..36d5f8ac8265 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
@@ -1704,7 +1704,9 @@ static void raid5d (mddev_t *mddev) | |||
1704 | 1704 | ||
1705 | if (conf->seq_flush - conf->seq_write > 0) { | 1705 | if (conf->seq_flush - conf->seq_write > 0) { |
1706 | int seq = conf->seq_flush; | 1706 | int seq = conf->seq_flush; |
1707 | spin_unlock_irq(&conf->device_lock); | ||
1707 | bitmap_unplug(mddev->bitmap); | 1708 | bitmap_unplug(mddev->bitmap); |
1709 | spin_lock_irq(&conf->device_lock); | ||
1708 | conf->seq_write = seq; | 1710 | conf->seq_write = seq; |
1709 | activate_bit_delay(conf); | 1711 | activate_bit_delay(conf); |
1710 | } | 1712 | } |