diff options
author | NeilBrown <neilb@cse.unsw.edu.au> | 2005-05-17 00:53:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-05-17 10:59:12 -0400 |
commit | 7a5febe9ffeecd1e78c5b505260ccc1ef18021b4 (patch) | |
tree | f3d61987a3f961f33a77334052805457a2ef2460 /drivers/md/raid5.c | |
parent | 29ac8e056f2016a8404edc02749d095019aa1f82 (diff) |
[PATCH] md: set the unplug_fn and issue_flush_fn for md devices *after* committed to creation
We we set the too early, they may still be in place and possibly get called
even though the array didn't get set up properly.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/raid5.c')
-rw-r--r-- | drivers/md/raid5.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index e96e2a10a9c9..3cb11ac232fa 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
@@ -1620,9 +1620,6 @@ static int run (mddev_t *mddev) | |||
1620 | atomic_set(&conf->active_stripes, 0); | 1620 | atomic_set(&conf->active_stripes, 0); |
1621 | atomic_set(&conf->preread_active_stripes, 0); | 1621 | atomic_set(&conf->preread_active_stripes, 0); |
1622 | 1622 | ||
1623 | mddev->queue->unplug_fn = raid5_unplug_device; | ||
1624 | mddev->queue->issue_flush_fn = raid5_issue_flush; | ||
1625 | |||
1626 | PRINTK("raid5: run(%s) called.\n", mdname(mddev)); | 1623 | PRINTK("raid5: run(%s) called.\n", mdname(mddev)); |
1627 | 1624 | ||
1628 | ITERATE_RDEV(mddev,rdev,tmp) { | 1625 | ITERATE_RDEV(mddev,rdev,tmp) { |
@@ -1728,6 +1725,10 @@ memory = conf->max_nr_stripes * (sizeof(struct stripe_head) + | |||
1728 | } | 1725 | } |
1729 | 1726 | ||
1730 | /* Ok, everything is just fine now */ | 1727 | /* Ok, everything is just fine now */ |
1728 | |||
1729 | mddev->queue->unplug_fn = raid5_unplug_device; | ||
1730 | mddev->queue->issue_flush_fn = raid5_issue_flush; | ||
1731 | |||
1731 | mddev->array_size = mddev->size * (mddev->raid_disks - 1); | 1732 | mddev->array_size = mddev->size * (mddev->raid_disks - 1); |
1732 | return 0; | 1733 | return 0; |
1733 | abort: | 1734 | abort: |