aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/raid1.c
diff options
context:
space:
mode:
authorJesper Juhl <juhl-lkml@dif.dk>2005-06-21 20:17:30 -0400
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-06-21 22:07:48 -0400
commit990a8baf568ca1d0ae65e59783ff821794118d07 (patch)
tree1fe187b2f119f7a9d96d56380b211f9ddb9f8390 /drivers/md/raid1.c
parent8a5e9cf1d6626586ff08e49f400a006a9f0c3275 (diff)
[PATCH] md: remove unneeded NULL checks before kfree
This patch removes some unneeded checks of pointers being NULL before calling kfree() on them. kfree() handles NULL pointers just fine, checking first is pointless. Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/raid1.c')
-rw-r--r--drivers/md/raid1.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 98b09773e79e..ff1dbec864af 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1427,10 +1427,8 @@ out_free_conf:
1427 if (conf) { 1427 if (conf) {
1428 if (conf->r1bio_pool) 1428 if (conf->r1bio_pool)
1429 mempool_destroy(conf->r1bio_pool); 1429 mempool_destroy(conf->r1bio_pool);
1430 if (conf->mirrors) 1430 kfree(conf->mirrors);
1431 kfree(conf->mirrors); 1431 kfree(conf->poolinfo);
1432 if (conf->poolinfo)
1433 kfree(conf->poolinfo);
1434 kfree(conf); 1432 kfree(conf);
1435 mddev->private = NULL; 1433 mddev->private = NULL;
1436 } 1434 }
@@ -1447,10 +1445,8 @@ static int stop(mddev_t *mddev)
1447 blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/ 1445 blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/
1448 if (conf->r1bio_pool) 1446 if (conf->r1bio_pool)
1449 mempool_destroy(conf->r1bio_pool); 1447 mempool_destroy(conf->r1bio_pool);
1450 if (conf->mirrors) 1448 kfree(conf->mirrors);
1451 kfree(conf->mirrors); 1449 kfree(conf->poolinfo);
1452 if (conf->poolinfo)
1453 kfree(conf->poolinfo);
1454 kfree(conf); 1450 kfree(conf);
1455 mddev->private = NULL; 1451 mddev->private = NULL;
1456 return 0; 1452 return 0;