Drop 'size' argument from bio_endio and bi_end_io

As bi_end_io is only called once when the reqeust is complete,
the 'size' argument is now redundant.  Remove it.

Now there is no need for bio_endio to subtract the size completed
from bi_size.  So don't do that either.

While we are at it, change bi_end_io to return void.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

1 files changed, 8 insertions, 17 deletions

diff --git a/drivers/md/md.c b/drivers/md/md.c
index f883b7e37f3d..e8f102ea9b03 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -213,7 +213,7 @@ static DEFINE_SPINLOCK(all_mddevs_lock);
 
 static int md_fail_request (struct request_queue *q, struct bio *bio)
 {
-        bio_io_error(bio, bio->bi_size);
+        bio_io_error(bio);
         return 0;
 }
 
@@ -384,12 +384,10 @@ static void free_disk_sb(mdk_rdev_t * rdev)
 }
 
 
-static int super_written(struct bio *bio, unsigned int bytes_done, int error)
+static void super_written(struct bio *bio, int error)
 {
         mdk_rdev_t *rdev = bio->bi_private;
         mddev_t *mddev = rdev->mddev;
-        if (bio->bi_size)
-                return 1;
 
         if (error || !test_bit(BIO_UPTODATE, &bio->bi_flags)) {
                 printk("md: super_written gets error=%d, uptodate=%d\n",
@@ -401,16 +399,13 @@ static int super_written(struct bio *bio, unsigned int bytes_done, int error)
         if (atomic_dec_and_test(&mddev->pending_writes))
                 wake_up(&mddev->sb_wait);
         bio_put(bio);
-        return 0;
 }
 
-static int super_written_barrier(struct bio *bio, unsigned int bytes_done, int error)
+static void super_written_barrier(struct bio *bio, int error)
 {
         struct bio *bio2 = bio->bi_private;
         mdk_rdev_t *rdev = bio2->bi_private;
         mddev_t *mddev = rdev->mddev;
-        if (bio->bi_size)
-                return 1;
 
         if (!test_bit(BIO_UPTODATE, &bio->bi_flags) &&
             error == -EOPNOTSUPP) {
@@ -424,11 +419,11 @@ static int super_written_barrier(struct bio *bio, unsigned int bytes_done, int e
                 spin_unlock_irqrestore(&mddev->write_lock, flags);
                 wake_up(&mddev->sb_wait);
                 bio_put(bio);
-                return 0;
+        } else {
+                bio_put(bio2);
+                bio->bi_private = rdev;
+                super_written(bio, error);
         }
-        bio_put(bio2);
-        bio->bi_private = rdev;
-        return super_written(bio, bytes_done, error);
 }
 
 void md_super_write(mddev_t *mddev, mdk_rdev_t *rdev,
@@ -489,13 +484,9 @@ void md_super_wait(mddev_t *mddev)
         finish_wait(&mddev->sb_wait, &wq);
 }
 
-static int bi_complete(struct bio *bio, unsigned int bytes_done, int error)
+static void bi_complete(struct bio *bio, int error)
 {
-        if (bio->bi_size)
-                return 1;
-
         complete((struct completion*)bio->bi_private);
-        return 0;
 }
 
 int sync_page_io(struct block_device *bdev, sector_t sector, int size,