aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/linear.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2006-01-06 03:20:36 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-06 11:34:06 -0500
commit2604b703b6b3db80e3c75ce472a54dfd0b7bf9f4 (patch)
tree8c0e985c455ff35af24fbe60d8a3f5a276034370 /drivers/md/linear.c
parenta24a8dd858e0ba50f06a9fd8f61fe8c4fe7a8d8e (diff)
[PATCH] md: remove personality numbering from md
md supports multiple different RAID level, each being implemented by a 'personality' (which is often in a separate module). These personalities have fairly artificial 'numbers'. The numbers are use to: 1- provide an index into an array where the various personalities are recorded 2- identify the module (via an alias) which implements are particular personality. Neither of these uses really justify the existence of personality numbers. The array can be replaced by a linked list which is searched (array lookup only happens very rarely). Module identification can be done using an alias based on level rather than 'personality' number. The current 'raid5' modules support two level (4 and 5) but only one personality. This slight awkwardness (which was handled in the mapping from level to personality) can be better handled by allowing raid5 to register 2 personalities. With this change in place, the core md module does not need to have an exhaustive list of all possible personalities, so other personalities can be added independently. This patch also moves the check for chunksize being non-zero into the ->run routines for the personalities that need it, rather than having it in core-md. This has a side effect of allowing 'faulty' and 'linear' not to have a chunk-size set. Signed-off-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/linear.c')
-rw-r--r--drivers/md/linear.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/md/linear.c b/drivers/md/linear.c
index f46c98d05b44..79dee8159217 100644
--- a/drivers/md/linear.c
+++ b/drivers/md/linear.c
@@ -351,9 +351,10 @@ static void linear_status (struct seq_file *seq, mddev_t *mddev)
351} 351}
352 352
353 353
354static mdk_personality_t linear_personality= 354static struct mdk_personality linear_personality =
355{ 355{
356 .name = "linear", 356 .name = "linear",
357 .level = LEVEL_LINEAR,
357 .owner = THIS_MODULE, 358 .owner = THIS_MODULE,
358 .make_request = linear_make_request, 359 .make_request = linear_make_request,
359 .run = linear_run, 360 .run = linear_run,
@@ -363,16 +364,17 @@ static mdk_personality_t linear_personality=
363 364
364static int __init linear_init (void) 365static int __init linear_init (void)
365{ 366{
366 return register_md_personality (LINEAR, &linear_personality); 367 return register_md_personality (&linear_personality);
367} 368}
368 369
369static void linear_exit (void) 370static void linear_exit (void)
370{ 371{
371 unregister_md_personality (LINEAR); 372 unregister_md_personality (&linear_personality);
372} 373}
373 374
374 375
375module_init(linear_init); 376module_init(linear_init);
376module_exit(linear_exit); 377module_exit(linear_exit);
377MODULE_LICENSE("GPL"); 378MODULE_LICENSE("GPL");
378MODULE_ALIAS("md-personality-1"); /* LINEAR */ 379MODULE_ALIAS("md-personality-1"); /* LINEAR - degrecated*/
380MODULE_ALIAS("md-level--1");