diff options
author | Kiyoshi Ueda <k-ueda@ct.jp.nec.com> | 2010-09-08 12:07:01 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-09-10 06:35:38 -0400 |
commit | 05447420f99c1c44063c7f00054667c022cc1365 (patch) | |
tree | 9d70e7c0037d821784b76d9d7d99c174c73d0576 /drivers/md/dm.c | |
parent | 6a8736d10cb413be95ea443ba40f25c93f4ef9b2 (diff) |
dm: fix locking context in queue_io()
Now queue_io() is called from dec_pending(), which may be called with
interrupts disabled, so queue_io() must not enable interrupts
unconditionally and must save/restore the current interrupts status.
Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/md/dm.c')
-rw-r--r-- | drivers/md/dm.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 2011704b8ba0..cd2f7e77b625 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c | |||
@@ -512,9 +512,11 @@ static void end_io_acct(struct dm_io *io) | |||
512 | */ | 512 | */ |
513 | static void queue_io(struct mapped_device *md, struct bio *bio) | 513 | static void queue_io(struct mapped_device *md, struct bio *bio) |
514 | { | 514 | { |
515 | spin_lock_irq(&md->deferred_lock); | 515 | unsigned long flags; |
516 | |||
517 | spin_lock_irqsave(&md->deferred_lock, flags); | ||
516 | bio_list_add(&md->deferred, bio); | 518 | bio_list_add(&md->deferred, bio); |
517 | spin_unlock_irq(&md->deferred_lock); | 519 | spin_unlock_irqrestore(&md->deferred_lock, flags); |
518 | queue_work(md->wq, &md->work); | 520 | queue_work(md->wq, &md->work); |
519 | } | 521 | } |
520 | 522 | ||